Mbh\Tree\Visitor\InOrder

Complexity

Total Complexity

3

Size/Duplication

Total Lines	15
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	visit()	0	13	3

<?php namespace Mbh\Tree\Visitor;

use Mbh\Tree\Interfaces\Node as NodeInterface;
use Mbh\Tree\Visitor;

class InOrder extends Visitor
{
    public function visit(NodeInterface $node)
    {
        if ($node->isLeaf()) {
            return [$node];
        }

        $yield = [];

        foreach ($node->getChildren() as $child) {
            $yield = array_merge($yield, $child->accept($this));

Are you sure the usage of $child->accept($this) targeting Mbh\Tree\Interfaces\Node::accept() seems to always return null.

$child->accept($this) of type void is incompatible with the type null|array expected by parameter $array2 of array_merge().

        }

        return $yield;
    }
}