MAXakaWIZARD /
xls-writer
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 6 | View Code Duplication | class Note extends AbstractRecord |
|
|
|
|||
| 7 | { |
||
| 8 | const NAME = 'NOTE'; |
||
| 9 | const ID = 0x001C; |
||
| 10 | |||
| 11 | /** |
||
| 12 | * Generate a note associated with the cell given by the row and column. |
||
| 13 | * NOTE records don't have a length limit |
||
| 14 | * @param integer $row |
||
| 15 | * @param integer $col |
||
| 16 | * @param integer $objId |
||
| 17 | * |
||
| 18 | * @return string |
||
| 19 | */ |
||
| 20 | public function getData($row, $col, $objId) |
||
| 29 | } |
||
| 30 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.