M-Contributions / m2-connector

Gateway/Client/Ftp.php

<?php
declare(strict_types=1);

/**
 * Gateway Client Class
 * @category    Ticaje
 * @package     Ticaje_Connector
 * @author      Hector Luis Barrientos <ticaje@filetea.me>
 */

namespace Ticaje\Connector\Gateway\Client;

use Ticaje\Connector\Interfaces\CredentialInterface;
use Ticaje\Connector\Interfaces\Protocol\FtpClientInterface;

/**
 * Class Ftp
 * @package Ticaje\Connector\Gateway\Client
 */
class Ftp extends Base implements FtpClientInterface
{
    private $connected;

    /**
     * @inheritDoc
     */
    public function isConnected(): bool
    {
        return $this->connected;
    }

    /**
     * @inheritDoc
     */
    public function connect(CredentialInterface $credentials)
    {
        try {
            $this->client = $this->clientFactory->create($credentials->getAll());
            $this->connected = $this->client->login($credentials->username, $credentials->password) ? true : false;

Accessing username on the interface Ticaje\Connector\Interfaces\CredentialInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing password on the interface Ticaje\Connector\Interfaces\CredentialInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        } catch (\Exception $exception) {
            $this->connected = false;
        }
        return $this->connected;
    }

    /**
     * @inheritDoc
     */
    public function get($path = '')
    {
        return $this->client->get($path);
    }

    /**
     * @inheritDoc
     */
    public function ls($dir = '.'): array
    {
        return $this->client->nlist($dir);
    }

    /**
     * @inheritDoc
     */
    public function download($path = '', $destination = false)
    {
        return $this->client->get($path, $destination);
    }
}