Ftp::connect() - Code Metrics - Inspection of "Bump upto 1.0.5 version" - M-Contributions/m2-connector - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 30e7f6...e34ab3 )

by Hector Luis

created 2020-02-01 16:21 UTC

Ftp::connect() A

↳ Parent: Ftp

Complexity

Conditions	3
Paths	4

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	6
c	1
b	0
f	0
dl	0
loc	9
rs	10
cc	3
nc	4
nop	1

<?php
declare(strict_types=1);

/**
 * Gateway Client Class
 * @category    Ticaje
 * @package     Ticaje_Connector
 * @author      Hector Luis Barrientos <[email protected]>
 */

namespace Ticaje\Connector\Gateway\Client;

use Ticaje\Connector\Interfaces\CredentialInterface;
use Ticaje\Connector\Interfaces\Protocol\FtpClientInterface;

/**
 * Class Ftp
 * @package Ticaje\Connector\Gateway\Client
 */
class Ftp extends Base implements FtpClientInterface
{
    private $connected;

    /**
     * @inheritDoc
     */
    public function isConnected(): bool
    {
        return $this->connected;
    }

    /**
     * @inheritDoc
     */
    public function connect(CredentialInterface $credentials)
    {
        try {
            $this->client = $this->clientFactory->create($credentials->getAll());
            $this->connected = $this->client->login($credentials->username, $credentials->password) ? true : false;

        } catch (\Exception $exception) {
            $this->connected = false;
        }
        return $this->connected;
    }

    /**
     * @inheritDoc
     */
    public function get($path = '')
    {
        return $this->client->get($path);
    }

    /**
     * @inheritDoc
     */
    public function ls($dir = '.'): array
    {
        return $this->client->nlist($dir);
    }

    /**
     * @inheritDoc
     */
    public function download($path = '', $destination = false)
    {
        return $this->client->get($path, $destination);
    }
}


1			<?php
2			declare(strict_types=1);
3
4			/**
5			* Gateway Client Class
6			* @category Ticaje
7			* @package Ticaje_Connector
8			* @author Hector Luis Barrientos <[email protected]>
9			*/
10
11			namespace Ticaje\Connector\Gateway\Client;
12
13			use Ticaje\Connector\Interfaces\CredentialInterface;
14			use Ticaje\Connector\Interfaces\Protocol\FtpClientInterface;
15
16			/**
17			* Class Ftp
18			* @package Ticaje\Connector\Gateway\Client
19			*/
20			class Ftp extends Base implements FtpClientInterface
21			{
22			private $connected;
23
24			/**
25			* @inheritDoc
26			*/
27			public function isConnected(): bool
28			{
29			return $this->connected;
30			}
31
32			/**
33			* @inheritDoc
34			*/
35			public function connect(CredentialInterface $credentials)
36			{
37			try {
38			$this->client = $this->clientFactory->create($credentials->getAll());
39			$this->connected = $this->client->login($credentials->username, $credentials->password) ? true : false;
			0 ignored issues – show Bug introduced 2020-02-01 16:33 UTC by Report Bug Copy Issue Report Accessing `username` on the interface `Ticaje\Connector\Interfaces\CredentialInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history... Bug introduced 2020-02-01 16:33 UTC by Report Bug Copy Issue Report Accessing `password` on the interface `Ticaje\Connector\Interfaces\CredentialInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
40			} catch (\Exception $exception) {
41			$this->connected = false;
42			}
43			return $this->connected;
44			}
45
46			/**
47			* @inheritDoc
48			*/
49			public function get($path = '')
50			{
51			return $this->client->get($path);
52			}
53
54			/**
55			* @inheritDoc
56			*/
57			public function ls($dir = '.'): array
58			{
59			return $this->client->nlist($dir);
60			}
61
62			/**
63			* @inheritDoc
64			*/
65			public function download($path = '', $destination = false)
66			{
67			return $this->client->get($path, $destination);
68			}
69			}
70

M-Contributions / m2-connector

Push — master ( 30e7f6...e34ab3 )

Ftp::connect() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like