M-Contributions / Setting

Traits/Status.php

<?php
declare(strict_types=1);

/**
 * Status Trait
 * @category    Ticaje
 * @package     Ticaje_Setting
 * @author      Hector Luis Barrientos <ticaje@filetea.me>
 */

namespace Ticaje\Configuration\Traits;

use Magento\Store\Model\ScopeInterface;

/**
 * Trait Status
 * @package Ticaje\Configuration\Traits
 * Classes using this trait must implement Ticaje\Configuration\GeneralInterface
 */
trait Status
{
    /**
     * @inheritDoc
     */
    public function isEnabled($storeId = null): bool
    {
        $field = self::XML_FIELD_ENABLED;

The constant Ticaje\Configuration\Traits\Status::XML_FIELD_ENABLED was not found. Maybe you did not declare it correctly or list all dependencies?

        $config = $this->scopeConfig->getValue($this->getXmlGeneralPath($field), ScopeInterface::SCOPE_STORE, $storeId) ?: '';

It seems like getXmlGeneralPath() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return (bool)$config;
    }

    /**
     * @inheritDoc
     */
    public function enable($storeId = null)
    {
        $value = (string)(int)(bool)self::ENABLED_VALUE;

The constant Ticaje\Configuration\Traits\Status::ENABLED_VALUE was not found. Maybe you did not declare it correctly or list all dependencies?

        $this->setValue(self::XML_FIELD_ENABLED, $value, $storeId);

The constant Ticaje\Configuration\Traits\Status::XML_FIELD_ENABLED was not found. Maybe you did not declare it correctly or list all dependencies?

It seems like setValue() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @inheritDoc
     */
    public function disable($storeId = null)
    {
        $value = (string)(int)(bool)self::DISABLED_VALUE;

The constant Ticaje\Configuration\Traits\Status::DISABLED_VALUE was not found. Maybe you did not declare it correctly or list all dependencies?

        $this->setValue(self::XML_FIELD_ENABLED, $value, $storeId);

The constant Ticaje\Configuration\Traits\Status::XML_FIELD_ENABLED was not found. Maybe you did not declare it correctly or list all dependencies?

    }
}