Bitrix24 - Code Metrics - Inspection of "Merge branch 'v1.0'" - Lusitanian/PHPoAuthLib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7928ab...1cefdb )

by Georgio

created 2020-06-30 20:32 UTC

Bitrix24 A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	171
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

Metric	Value
dl	0
loc	171
c	0
b	0
f	0
wmc	8
lcom	1
cbo	6
rs	10

8 Methods

Rating	Name	Size	Complexity
A	testConstructCorrectInstanceWithCustomUri()	12	1
A	testGetAuthorizationEndpoint()	12	1
A	testGetAccessTokenEndpoint()	12	1
A	testGetAuthorizationMethod()	25	1
A	testParseAccessTokenResponseThrowsExceptionOnNulledResponse()	17	1
A	testParseAccessTokenResponseThrowsExceptionOnError()	17	1
A	testParseAccessTokenResponseValidWithoutRefreshToken()	15	1
A	testGetExtraOAuthHeaders()	20	1

<?php

namespace OAuthTest\Unit\OAuth2\Service;

use OAuth\Common\Token\TokenInterface;
use OAuth\OAuth2\Service\Bitrix24;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use PHPUnit\Framework\Assert;
use PHPUnit\Framework\TestCase;

class Bitrix24 extends TestCase
{
    /**
     * @covers \OAuth\OAuth2\Service\Bitrix24::__construct
     */
    public function testConstructCorrectInstanceWithCustomUri(): void
    {
        $service = new Bitrix24(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            [],
            $this->createMock('\\OAuth\\Common\\Http\\Uri\\UriInterface')
        );

        self::assertInstanceOf('\\OAuth\\OAuth2\\Service\\AbstractService', $service);
    }

    /**
     * @covers \OAuth\OAuth2\Service\Bitrix24::__construct
     * @covers \OAuth\OAuth2\Service\Bitrix24::getAuthorizationEndpoint
     */
    public function testGetAuthorizationEndpoint(): void
    {
        $service = new Bitrix24(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            [],
            $this->createMock('\\OAuth\\Common\\Http\\Uri\\UriInterface')
        );

        self::assertSame('https://bitrix24.com/oauth/authorize/', $service->getAuthorizationEndpoint()->getAbsoluteUri());
    }

    /**
     * @covers \OAuth\OAuth2\Service\Bitrix24::__construct
     * @covers \OAuth\OAuth2\Service\Bitrix24::getAccessTokenEndpoint
     */
    public function testGetAccessTokenEndpoint(): void
    {
        $service = new Bitrix24(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            [],
            $this->createMock('\\OAuth\\Common\\Http\\Uri\\UriInterface')
        );

        self::assertSame('https://bitrix24.com/oauth/token/', $service->getAccessTokenEndpoint()->getAbsoluteUri());
    }

    /**
     * @covers \OAuth\OAuth2\Service\Bitrix24::__construct
     * @covers \OAuth\OAuth2\Service\Bitrix24::getAuthorizationMethod
     */
    public function testGetAuthorizationMethod(): void
    {
        $client = $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface');
        $client->expects(self::once())->method('retrieveResponse')->willReturnArgument(0);

        $token = $this->createMock('\\OAuth\\OAuth2\\Token\\TokenInterface');
        $token->expects(self::once())->method('getEndOfLife')->willReturn(TokenInterface::EOL_NEVER_EXPIRES);
        $token->expects(self::once())->method('getAccessToken')->willReturn('foo');

        $storage = $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface');
        $storage->expects(self::once())->method('retrieveAccessToken')->willReturn($token);

        $service = new Bitrix24(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $client,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $storage,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            [],
            $this->createMock('\\OAuth\\Common\\Http\\Uri\\UriInterface')
        );

        $uri = $service->request('https://pieterhordijk.com/my/awesome/path');
        $absoluteUri = parse_url($uri->getAbsoluteUri());


        self::assertSame('access_token=foo', $absoluteUri['query']);
    }

    /**
     * @covers \OAuth\OAuth2\Service\Bitrix24::__construct
     * @covers \OAuth\OAuth2\Service\Bitrix24::parseAccessTokenResponse
     */
    public function testParseAccessTokenResponseThrowsExceptionOnNulledResponse(): void
    {
        $client = $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface');
        $client->expects(self::once())->method('retrieveResponse')->willReturn(null);

        $service = new Bitrix24(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $client,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            [],
            $this->createMock('\\OAuth\\Common\\Http\\Uri\\UriInterface')
        );

        $this->expectException('\\OAuth\\Common\\Http\\Exception\\TokenResponseException');

        $service->requestAccessToken('foo');
    }

    /**
     * @covers \OAuth\OAuth2\Service\Bitrix24::__construct
     * @covers \OAuth\OAuth2\Service\Bitrix24::parseAccessTokenResponse
     */
    public function testParseAccessTokenResponseThrowsExceptionOnError(): void
    {
        $client = $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface');
        $client->expects(self::once())->method('retrieveResponse')->willReturn('{"error":"some_error"}');

        $service = new Bitrix24(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $client,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            [],
            $this->createMock('\\OAuth\\Common\\Http\\Uri\\UriInterface')
        );

        $this->expectException('\\OAuth\\Common\\Http\\Exception\\TokenResponseException');

        $service->requestAccessToken('foo');
    }

    /**
     * @covers \OAuth\OAuth2\Service\Bitrix24::__construct
     * @covers \OAuth\OAuth2\Service\Bitrix24::parseAccessTokenResponse
     */
    public function testParseAccessTokenResponseValidWithoutRefreshToken(): void
    {
        $client = $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface');
        $client->expects(self::once())->method('retrieveResponse')->willReturn('{"access_token":"foo","expires_in":"bar"}');

        $service = new Bitrix24(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $client,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            [],
            $this->createMock('\\OAuth\\Common\\Http\\Uri\\UriInterface')
        );

        self::assertInstanceOf('\\OAuth\\OAuth2\\Token\\StdOAuth2Token', $service->requestAccessToken('foo'));
    }

    /**
     * @covers \OAuth\OAuth2\Service\Bitrix24::__construct
     * @covers \OAuth\OAuth2\Service\Bitrix24::getExtraOAuthHeaders
     */
    public function testGetExtraOAuthHeaders(): void
    {
        $client = $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface');
        $client->expects(self::once())->method('retrieveResponse')->willReturnCallback(function ($uri, $params, $extraHeaders) {
            Assert::assertTrue(array_key_exists('Accept', $extraHeaders));
            Assert::assertTrue(in_array('application/json', $extraHeaders, true));

            return '{"access_token":"foo","expires_in":"bar"}';
        });

        $service = new Bitrix24(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $client,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            [],
            $this->createMock('\\OAuth\\Common\\Http\\Uri\\UriInterface')
        );

        self::assertInstanceOf('\\OAuth\\OAuth2\\Token\\StdOAuth2Token', $service->requestAccessToken('foo'));
    }
}


1			<?php
2
3			namespace OAuthTest\Unit\OAuth2\Service;
4
5			use OAuth\Common\Token\TokenInterface;
6			use OAuth\OAuth2\Service\Bitrix24;
			0 ignored issues – show Bug introduced 2020-06-30 20:36 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `OAuthTest\Unit\OAuth2\Service\Bitrix24`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
7			use PHPUnit\Framework\Assert;
8			use PHPUnit\Framework\TestCase;
9
10			class Bitrix24 extends TestCase
11			{
12			/**
13			* @covers \OAuth\OAuth2\Service\Bitrix24::__construct
14			*/
15			public function testConstructCorrectInstanceWithCustomUri(): void
16			{
17			$service = new Bitrix24(
18			$this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
			0 ignored issues – show Documentation introduced 2020-06-30 20:36 UTC by Report Bug Copy Issue Report `$this->createMock('\\OAu...\CredentialsInterface')` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<OAuth\Common\Cons...r\CredentialsInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
19			$this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface'),
			0 ignored issues – show Documentation introduced 2020-06-30 20:36 UTC by Report Bug Copy Issue Report `$this->createMock('\\OAu...ient\\ClientInterface')` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<OAuth\Common\Http\Client\ClientInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
20			$this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface'),
			0 ignored issues – show Documentation introduced 2020-06-30 20:36 UTC by Report Bug Copy Issue Report `$this->createMock('\\OAu...TokenStorageInterface')` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<OAuth\Common\Stor...\TokenStorageInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
21			[],
22			$this->createMock('\\OAuth\\Common\\Http\\Uri\\UriInterface')
23			);
24
25			self::assertInstanceOf('\\OAuth\\OAuth2\\Service\\AbstractService', $service);
26			}
27
28			/**
29			* @covers \OAuth\OAuth2\Service\Bitrix24::__construct
30			* @covers \OAuth\OAuth2\Service\Bitrix24::getAuthorizationEndpoint
31			*/
32			public function testGetAuthorizationEndpoint(): void
33			{
34			$service = new Bitrix24(
35			$this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
			0 ignored issues – show Documentation introduced 2020-06-30 20:36 UTC by Report Bug Copy Issue Report `$this->createMock('\\OAu...\CredentialsInterface')` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<OAuth\Common\Cons...r\CredentialsInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...

Lusitanian / PHPoAuthLib

Push — master ( 7928ab...1cefdb )

Bitrix24 A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

Duplication Side-by-Side

Filter issues like