BattleNet::parseAccessTokenResponse() - Code Metrics - Inspection of "Multiple accounts per Service" - Lusitanian/PHPoAuthLib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#498)

by Dragonqos

created 2016-11-16 10:27 UTC

BattleNet::parseAccessTokenResponse() A

↳ Parent: BattleNet

Complexity

Conditions	4
Paths	3

Size

Total Lines	21
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	21
rs	9.0534
c	0
b	0
f	0
cc	4
eloc	14
nc	3
nop	1

<?php

namespace OAuth\OAuth2\Service;

use OAuth\OAuth2\Token\StdOAuth2Token;
use OAuth\Common\Http\Exception\TokenResponseException;
use OAuth\Common\Http\Uri\Uri;

/**
 * Class BattleNet
 * @package OAuth\OAuth2\Service
 */
class BattleNet extends AbstractService { 
    
    /** 
     * Defined scopes.
     *
     * @link https://dev.battle.net/docs
     */
    const SCOPE_WOW_PROFILE = "wow.profile";
    const SCOPE_SC2_PROFILE = "sc2.profile";
    
    /** 
     * Defined API URIs.
     *
     * @link https://dev.battle.net/docs
     */
    const API_URI_US  = 'https://us.api.battle.net/';
    const API_URI_EU  = 'https://eu.api.battle.net/';
    const API_URI_KR  = 'https://kr.api.battle.net/';
    const API_URI_TW  = 'https://tw.api.battle.net/';
    const API_URI_CN  = 'https://api.battlenet.com.cn/';
    const API_URI_SEA = 'https://sea.api.battle.net/';
    
    /**
     * {@inheritdoc}
     */
    protected function init()
    {
        if( $this->baseApiUri === null ) {

            $this->baseApiUri = new Uri( self::API_URI_US );
        }
    }

    
    /** 
     * Translates the current base API URI into an OAuth base URI. 
     *
     * @returns string Base URI of oauth services.
     */
    private function GetOAuthBaseUri() {

    
        // i love china
        switch( $this->baseApiUri ) {

            case self::API_URI_US:  return 'https://us.battle.net/oauth/';
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case self::API_URI_EU:  return 'https://eu.battle.net/oauth/';
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case self::API_URI_KR:  return 'https://kr.battle.net/oauth/';
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case self::API_URI_TW:  return 'https://tw.battle.net/oauth/';
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case self::API_URI_CN:  return 'https://www.battlenet.com.cn/oauth/';
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case self::API_URI_SEA: return 'https://sea.battle.net/oauth/'; 
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
        }
        
    }
    
    /** 
     * {@inheritdoc}
     */
    public function getAuthorizationEndpoint() {
        return new Uri( $this->GetOAuthBaseUri() . 'authorize' );
    }
    
    /** 
     * {@inheritdoc}
     */
    public function getAccessTokenEndpoint() {
        return new Uri( $this->GetOAuthBaseUri() . 'token' );
    }
    
    /** 
     * {@inheritdoc}
     */
    protected function getAuthorizationMethod()
    {
        return static::AUTHORIZATION_METHOD_QUERY_STRING;
    }
    
    /** 
     * {@inheritdoc}
     */
    protected function parseAccessTokenResponse( $responseBody )

    {
        $data = json_decode($responseBody, true);
        if( $data === null || !is_array($data) ) {

            throw new TokenResponseException( 'Unable to parse response.' );
        } elseif( isset($data['error']) ) {

            $err = $data['error'];
            throw new TokenResponseException( 
                                "Error in retrieving token: \"$err\"" );
        }
        
        $token = new StdOAuth2Token( $data['access_token'], null, 
                                     $data['expires_in'] );
        
        unset( $data['access_token'] );
        unset( $data['expires_in'] );
        
        $token->setExtraParams( $data );
        
        return $token;
    }
}


1			<?php
2
3			namespace OAuth\OAuth2\Service;
4
5			use OAuth\OAuth2\Token\StdOAuth2Token;
6			use OAuth\Common\Http\Exception\TokenResponseException;
7			use OAuth\Common\Http\Uri\Uri;
8
9			/**
10			* Class BattleNet
11			* @package OAuth\OAuth2\Service
12			*/
13			class BattleNet extends AbstractService {
14
15			/**
16			* Defined scopes.
17			*
18			* @link https://dev.battle.net/docs
19			*/
20			const SCOPE_WOW_PROFILE = "wow.profile";
21			const SCOPE_SC2_PROFILE = "sc2.profile";
22
23			/**
24			* Defined API URIs.
25			*
26			* @link https://dev.battle.net/docs
27			*/
28			const API_URI_US = 'https://us.api.battle.net/';
29			const API_URI_EU = 'https://eu.api.battle.net/';
30			const API_URI_KR = 'https://kr.api.battle.net/';
31			const API_URI_TW = 'https://tw.api.battle.net/';
32			const API_URI_CN = 'https://api.battlenet.com.cn/';
33			const API_URI_SEA = 'https://sea.api.battle.net/';
34
35			/**
36			* {@inheritdoc}
37			*/
38			protected function init()
39			{
40			if( $this->baseApiUri === null ) {
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Expected 1 space after IF keyword; 0 found Loading history... Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Expected 0 spaces before closing bracket; 1 found Loading history...
41			$this->baseApiUri = new Uri( self::API_URI_US );
42			}
43			}
44
45
46			/**
47			* Translates the current base API URI into an OAuth base URI.
48			*
49			* @returns string Base URI of oauth services.
50			*/
51			private function GetOAuthBaseUri() {
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Method name "BattleNet::GetOAuthBaseUri" is not in camel caps format Loading history...
52
53			// i love china
54			switch( $this->baseApiUri ) {
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Expected 1 space after SWITCH keyword; 0 found Loading history... Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Expected 0 spaces before closing bracket; 1 found Loading history...
55			case self::API_URI_US: return 'https://us.battle.net/oauth/';
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
56			case self::API_URI_EU: return 'https://eu.battle.net/oauth/';
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
57			case self::API_URI_KR: return 'https://kr.battle.net/oauth/';
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
58			case self::API_URI_TW: return 'https://tw.battle.net/oauth/';
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
59			case self::API_URI_CN: return 'https://www.battlenet.com.cn/oauth/';
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
60			case self::API_URI_SEA: return 'https://sea.battle.net/oauth/';
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
61			}
62
63			}
64
65			/**
66			* {@inheritdoc}
67			*/
68			public function getAuthorizationEndpoint() {
69			return new Uri( $this->GetOAuthBaseUri() . 'authorize' );
70			}
71
72			/**
73			* {@inheritdoc}
74			*/
75			public function getAccessTokenEndpoint() {
76			return new Uri( $this->GetOAuthBaseUri() . 'token' );
77			}
78
79			/**
80			* {@inheritdoc}
81			*/
82			protected function getAuthorizationMethod()
83			{
84			return static::AUTHORIZATION_METHOD_QUERY_STRING;
85			}
86
87			/**
88			* {@inheritdoc}
89			*/
90			protected function parseAccessTokenResponse( $responseBody )
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Expected 0 spaces between opening bracket and argument "$responseBody"; 1 found Loading history... Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Expected 0 spaces between argument "$responseBody" and closing bracket; 1 found Loading history...
91			{
92			$data = json_decode($responseBody, true);
93			if( $data === null \|\| !is_array($data) ) {
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Expected 1 space after IF keyword; 0 found Loading history... Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Expected 0 spaces before closing bracket; 1 found Loading history...
94			throw new TokenResponseException( 'Unable to parse response.' );
95			} elseif( isset($data['error']) ) {
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Expected 1 space after ELSEIF keyword; 0 found Loading history... Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Expected 0 spaces before closing bracket; 1 found Loading history...
96			$err = $data['error'];
97			throw new TokenResponseException(
98			"Error in retrieving token: \"$err\"" );
99			}
100
101			$token = new StdOAuth2Token( $data['access_token'], null,
102			$data['expires_in'] );
103
104			unset( $data['access_token'] );
105			unset( $data['expires_in'] );
106
107			$token->setExtraParams( $data );
108
109			return $token;
110			}
111			}
112

Lusitanian / PHPoAuthLib

Pull Request — master (#498)

BattleNet::parseAccessTokenResponse() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like