BattleNet::GetOAuthBaseUri() - Code Metrics - Inspection of "Merge pull request #473 from mukunda-/master" - Lusitanian/PHPoAuthLib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c69bbe...09f4af )

by David

created 2016-07-12 22:15 UTC

BattleNet::GetOAuthBaseUri() B

↳ Parent: BattleNet

Complexity

Conditions	7
Paths	7

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	1

Metric	Value
c	4
b	0
f	1
dl	0
loc	13
rs	8.2222
cc	7
eloc	8
nc	7
nop	0

<?php

namespace OAuth\OAuth2\Service;

//-----------------------------------------------------------------------------
use OAuth\OAuth2\Token\StdOAuth2Token;
use OAuth\Common\Http\Exception\TokenResponseException;
use OAuth\Common\Http\Uri\Uri;
use OAuth\Common\Consumer\CredentialsInterface;
use OAuth\Common\Http\Client\ClientInterface;
use OAuth\Common\Storage\TokenStorageInterface;
use OAuth\Common\Http\Uri\UriInterface;

//-----------------------------------------------------------------------------
class BattleNet extends AbstractService { 
    
    /** -----------------------------------------------------------------------
     * Defined scopes.
     *
     * @link https://dev.battle.net/docs
     */
    const SCOPE_WOW_PROFILE = "wow.profile";
    const SCOPE_SC2_PROFILE = "sc2.profile";
    
    /** -----------------------------------------------------------------------
     * Defined API URIs.
     *
     * @link https://dev.battle.net/docs
     */
    const API_URI_US  = 'https://us.api.battle.net/';
    const API_URI_EU  = 'https://eu.api.battle.net/';
    const API_URI_KR  = 'https://kr.api.battle.net/';
    const API_URI_TW  = 'https://tw.api.battle.net/';
    const API_URI_CN  = 'https://api.battlenet.com.cn/';
    const API_URI_SEA = 'https://sea.api.battle.net/';
    
    public function __construct( CredentialsInterface $credentials,

                                 ClientInterface $httpClient,

                                 TokenStorageInterface $storage,

                                 $scopes = array(),

                                 UriInterface $baseApiUri = null ) {

                                 
        parent::__construct( $credentials, $httpClient, $storage, 
                             $scopes, $baseApiUri );
        
        if( $baseApiUri === null ) {

            $this->baseApiUri = new Uri( self::API_URI_US );
        }
    }
    
    /** -----------------------------------------------------------------------
     * Translates the current base API URI into an OAuth base URI. 
     *
     * @returns string Base URI of oauth services.
     */
    private function GetOAuthBaseUri() {

    
        // i love china
        switch( $this->baseApiUri ) {

            case self::API_URI_US:  return 'https://us.battle.net/oauth/';
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case self::API_URI_EU:  return 'https://eu.battle.net/oauth/';
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case self::API_URI_KR:  return 'https://kr.battle.net/oauth/';
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case self::API_URI_TW:  return 'https://tw.battle.net/oauth/';
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case self::API_URI_CN:  return 'https://www.battlenet.com.cn/oauth/';
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
            case self::API_URI_SEA: return 'https://sea.battle.net/oauth/'; 
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;
        }
        
    }
    
    /** -----------------------------------------------------------------------
     * {@inheritdoc}
     */
    public function getAuthorizationEndpoint() {
        return new Uri( $this->GetOAuthBaseUri() . 'authorize' );
    }
    
    /** -----------------------------------------------------------------------
     * {@inheritdoc}
     */
    public function getAccessTokenEndpoint() {
        return new Uri( $this->GetOAuthBaseUri() . 'token' );
    }
    
    /** -----------------------------------------------------------------------
     * {@inheritdoc}
     */
    protected function getAuthorizationMethod()
    {
        return static::AUTHORIZATION_METHOD_QUERY_STRING;
    }
    
    /** -----------------------------------------------------------------------
     * {@inheritdoc}
     */
    protected function parseAccessTokenResponse( $responseBody )

    {
        $data = json_decode($responseBody, true);
        if( $data === null || !is_array($data) ) {

            throw new TokenResponseException( 'Unable to parse response.' );
        } elseif( isset($data['error']) ) {

            $err = $data['error'];
            throw new TokenResponseException( 
                                "Error in retrieving token: \"$err\"" );
        }
        
        $token = new StdOAuth2Token( $data['access_token'], null, 
                                     $data['expires_in'] );
        
        unset( $data['access_token'] );
        unset( $data['expires_in'] );
        
        $token->setExtraParams( $data );
        
        return $token;
    }
}


1			<?php
2
3			namespace OAuth\OAuth2\Service;
4
5			//-----------------------------------------------------------------------------
6			use OAuth\OAuth2\Token\StdOAuth2Token;
7			use OAuth\Common\Http\Exception\TokenResponseException;
8			use OAuth\Common\Http\Uri\Uri;
9			use OAuth\Common\Consumer\CredentialsInterface;
10			use OAuth\Common\Http\Client\ClientInterface;
11			use OAuth\Common\Storage\TokenStorageInterface;
12			use OAuth\Common\Http\Uri\UriInterface;
13
14			//-----------------------------------------------------------------------------
15			class BattleNet extends AbstractService {
16
17			/** -----------------------------------------------------------------------
18			* Defined scopes.
19			*
20			* @link https://dev.battle.net/docs
21			*/
22			const SCOPE_WOW_PROFILE = "wow.profile";
23			const SCOPE_SC2_PROFILE = "sc2.profile";
24
25			/** -----------------------------------------------------------------------
26			* Defined API URIs.
27			*
28			* @link https://dev.battle.net/docs
29			*/
30			const API_URI_US = 'https://us.api.battle.net/';
31			const API_URI_EU = 'https://eu.api.battle.net/';
32			const API_URI_KR = 'https://kr.api.battle.net/';
33			const API_URI_TW = 'https://tw.api.battle.net/';
34			const API_URI_CN = 'https://api.battlenet.com.cn/';
35			const API_URI_SEA = 'https://sea.api.battle.net/';
36
37			public function __construct( CredentialsInterface $credentials,
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report The first parameter of a multi-line function declaration must be on the line after the opening bracket Loading history...
38			ClientInterface $httpClient,
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Multi-line function declaration not indented correctly; expected 8 spaces but found 33 Loading history...
39			TokenStorageInterface $storage,
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Multi-line function declaration not indented correctly; expected 8 spaces but found 33 Loading history...
40			$scopes = array(),
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Multi-line function declaration not indented correctly; expected 8 spaces but found 33 Loading history...
41			UriInterface $baseApiUri = null ) {
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Multi-line function declaration not indented correctly; expected 8 spaces but found 33 Loading history... Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report The closing parenthesis of a multi-line function declaration must be on a new line Loading history...
42
43			parent::__construct( $credentials, $httpClient, $storage,
44			$scopes, $baseApiUri );
45
46			if( $baseApiUri === null ) {
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Expected 0 spaces before closing bracket; 1 found Loading history... Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Expected 1 space after IF keyword; 0 found Loading history...
47			$this->baseApiUri = new Uri( self::API_URI_US );
48			}
49			}
50
51			/** -----------------------------------------------------------------------
52			* Translates the current base API URI into an OAuth base URI.
53			*
54			* @returns string Base URI of oauth services.
55			*/
56			private function GetOAuthBaseUri() {
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Method name "BattleNet::GetOAuthBaseUri" is not in camel caps format Loading history...
57
58			// i love china
59			switch( $this->baseApiUri ) {
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Expected 0 spaces before closing bracket; 1 found Loading history... Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Expected 1 space after SWITCH keyword; 0 found Loading history...
60			case self::API_URI_US: return 'https://us.battle.net/oauth/';
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
61			case self::API_URI_EU: return 'https://eu.battle.net/oauth/';
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
62			case self::API_URI_KR: return 'https://kr.battle.net/oauth/';
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
63			case self::API_URI_TW: return 'https://tw.battle.net/oauth/';
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
64			case self::API_URI_CN: return 'https://www.battlenet.com.cn/oauth/';
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
65			case self::API_URI_SEA: return 'https://sea.battle.net/oauth/';
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history... Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Terminating statement must be on a line by itself As per the PSR-2 coding standard, the `break` (or other terminating) statement must be on a line of its own. switch ($expr) { case "A": doSomething(); break; //wrong case "B": doSomething(); break; //right case "C:": doSomething(); return true; //right } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
66			}
67
68			}
69
70			/** -----------------------------------------------------------------------
71			* {@inheritdoc}
72			*/
73			public function getAuthorizationEndpoint() {
74			return new Uri( $this->GetOAuthBaseUri() . 'authorize' );
75			}
76
77			/** -----------------------------------------------------------------------
78			* {@inheritdoc}
79			*/
80			public function getAccessTokenEndpoint() {
81			return new Uri( $this->GetOAuthBaseUri() . 'token' );
82			}
83
84			/** -----------------------------------------------------------------------
85			* {@inheritdoc}
86			*/
87			protected function getAuthorizationMethod()
88			{
89			return static::AUTHORIZATION_METHOD_QUERY_STRING;
90			}
91
92			/** -----------------------------------------------------------------------
93			* {@inheritdoc}
94			*/
95			protected function parseAccessTokenResponse( $responseBody )
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Expected 0 spaces between opening bracket and argument "$responseBody"; 1 found Loading history... Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Expected 0 spaces between argument "$responseBody" and closing bracket; 1 found Loading history...
96			{
97			$data = json_decode($responseBody, true);
98			if( $data === null \|\| !is_array($data) ) {
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Expected 0 spaces before closing bracket; 1 found Loading history... Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Expected 1 space after IF keyword; 0 found Loading history...
99			throw new TokenResponseException( 'Unable to parse response.' );
100			} elseif( isset($data['error']) ) {
			0 ignored issues – show Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Expected 0 spaces before closing bracket; 1 found Loading history... Coding Style introduced 2016-04-24 23:07 UTC by Report Bug Copy Issue Report Expected 1 space after ELSEIF keyword; 0 found Loading history...
101			$err = $data['error'];
102			throw new TokenResponseException(
103			"Error in retrieving token: \"$err\"" );
104			}
105
106			$token = new StdOAuth2Token( $data['access_token'], null,
107			$data['expires_in'] );
108
109			unset( $data['access_token'] );
110			unset( $data['expires_in'] );
111
112			$token->setExtraParams( $data );
113
114			return $token;
115			}
116			}
117

Lusitanian / PHPoAuthLib

Push — master ( c69bbe...09f4af )

BattleNet::GetOAuthBaseUri() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like