SlackTest::testConstructCorrectInstanceWithoutCustomUri() - Code Metrics - Inspection of "Added Slack OAuth2 v2" - Lusitanian/PHPoAuthLib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#571)

unknown

created 2020-12-28 18:47 UTC

testConstructCorrectInstanceWithoutCustomUri() A

↳ Parent: SlackTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace OAuthTest\Unit\OAuth2\Service;

use OAuth\Common\Token\TokenInterface;
use OAuth\OAuth2\Token\StdOAuth2Token;
use OAuth\OAuth2\Service\Slack;
use PHPUnit\Framework\TestCase;

class SlackTest extends TestCase
{
    /**
     * @covers \OAuth\OAuth2\Service\Slack::__construct
     */
    public function testConstructCorrectInterfaceWithoutCustomUri(): void
    {
        $service = new Slack(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        self::assertInstanceOf('\\OAuth\\OAuth2\\Service\\ServiceInterface', $service);
    }

    /**
     * @covers \OAuth\OAuth2\Service\Slack::__construct
     */
    public function testConstructCorrectInstanceWithoutCustomUri(): void
    {
        $service = new Slack(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        self::assertInstanceOf('\\OAuth\\OAuth2\\Service\\AbstractService', $service);
    }

    /**
     * @covers \OAuth\OAuth2\Service\Slack::__construct
     */
    public function testConstructCorrectInstanceWithCustomUri(): void
    {
        $service = new Slack(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            [],
            $this->createMock('\\OAuth\\Common\\Http\\Uri\\UriInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        self::assertInstanceOf('\\OAuth\\OAuth2\\Service\\AbstractService', $service);
    }

    /**
     * @covers \OAuth\OAuth2\Service\Slack::__construct
     * @covers \OAuth\OAuth2\Service\Slack::getAuthorizationEndpoint
     */
    public function testGetAuthorizationEndpoint(): void
    {
        $service = new Slack(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        self::assertSame(
            'https://slack.com/oauth/v2/authorize',
            $service->getAuthorizationEndpoint()->getAbsoluteUri()
        );
    }

    /**
     * @covers \OAuth\OAuth2\Service\Slack::__construct
     * @covers \OAuth\OAuth2\Service\Slack::getAccessTokenEndpoint
     */
    public function testGetAccessTokenEndpoint(): void
    {
        $service = new Slack(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        self::assertSame(
            'https://slack.com/api/oauth.v2.access',
            $service->getAccessTokenEndpoint()->getAbsoluteUri()
        );
    }

    /**
     * @covers \OAuth\OAuth2\Service\Slack::__construct
     * @covers \OAuth\OAuth2\Service\Slack::getAuthorizationMethod
     */
    public function testGetAuthorizationMethod(): void
    {
        $client = $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface');
        $client->expects(self::once())->method('retrieveResponse')->willReturnArgument(2);

        $token = $this->createMock('\\OAuth\\OAuth2\\Token\\TokenInterface');
        $token->expects(self::once())->method('getEndOfLife')->willReturn(TokenInterface::EOL_NEVER_EXPIRES);
        $token->expects(self::once())->method('getAccessToken')->willReturn('foo');

        $storage = $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface');
        $storage->expects(self::once())->method('retrieveAccessToken')->willReturn($token);

        $service = new Slack(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $client,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $storage
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        $headers = $service->request('https://pieterhordijk.com/my/awesome/path');
        self::assertArrayHasKey('Authorization', $headers);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        self::assertTrue(in_array('Bearer foo', $headers, true));
    }

    /**
     * @covers \OAuth\OAuth2\Service\Slack::__construct
     * @covers \OAuth\OAuth2\Service\Slack::parseAccessTokenResponse
     */
    public function testParseAccessTokenResponseThrowsExceptionOnNulledResponse(): void
    {
        $client = $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface');
        $client->expects(self::once())->method('retrieveResponse')->willReturn(null);

        $service = new Slack(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $client,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        $this->expectException('\\OAuth\\Common\\Http\\Exception\\TokenResponseException');

        $service->requestAccessToken('foo');
    }

    /**
     * @covers \OAuth\OAuth2\Service\Slack::__construct
     * @covers \OAuth\OAuth2\Service\Slack::parseAccessTokenResponse
     */
    public function testParseAccessTokenResponseThrowsExceptionOnErrorDescription(): void
    {
        $client = $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface');
        $client->expects(self::once())->method('retrieveResponse')->willReturn('error_description=some_error');

        $service = new Slack(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $client,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        $this->expectException('\\OAuth\\Common\\Http\\Exception\\TokenResponseException');

        $service->requestAccessToken('foo');
    }

    /**
     * @covers \OAuth\OAuth2\Service\Slack::__construct
     * @covers \OAuth\OAuth2\Service\Slack::parseAccessTokenResponse
     */
    public function testParseAccessTokenResponseThrowsExceptionOnError(): void
    {
        $client = $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface');
        $client->expects(self::once())->method('retrieveResponse')->willReturn('error=some_error');

        $service = new Slack(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $client,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        $this->expectException('\\OAuth\\Common\\Http\\Exception\\TokenResponseException');

        $service->requestAccessToken('foo');
    }

    /**
     * @covers \OAuth\OAuth2\Service\Slack::__construct
     * @covers \OAuth\OAuth2\Service\Slack::parseAccessTokenResponse
     */
    public function testParseAccessTokenResponseValidWithoutRefreshToken(): void
    {
        
        $client = $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface');
        $client->expects(self::once())->method('retrieveResponse')->willReturn('{"access_token":"foo","expires_in":"bar"}');

        $service = new Slack(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $client,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        self::assertInstanceOf('\\OAuth\\OAuth2\\Token\\StdOAuth2Token', $service->requestAccessToken('foo'));

    }
}


1			<?php
2
3			namespace OAuthTest\Unit\OAuth2\Service;
4
5			use OAuth\Common\Token\TokenInterface;
6			use OAuth\OAuth2\Token\StdOAuth2Token;
7			use OAuth\OAuth2\Service\Slack;
8			use PHPUnit\Framework\TestCase;
9
10			class SlackTest extends TestCase
11			{
12			/**
13			* @covers \OAuth\OAuth2\Service\Slack::__construct
14			*/
15			public function testConstructCorrectInterfaceWithoutCustomUri(): void
16			{
17			$service = new Slack(
18			$this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
			0 ignored issues – show Documentation introduced 2020-12-28 18:48 UTC by Report Bug Copy Issue Report `$this->createMock('\\OAu...\CredentialsInterface')` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<OAuth\Common\Cons...r\CredentialsInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
19			$this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface'),
			0 ignored issues – show Documentation introduced 2020-12-28 18:48 UTC by Report Bug Copy Issue Report `$this->createMock('\\OAu...ient\\ClientInterface')` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<OAuth\Common\Http\Client\ClientInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
20			$this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
			0 ignored issues – show Documentation introduced 2020-12-28 18:48 UTC by Report Bug Copy Issue Report `$this->createMock('\\OAu...TokenStorageInterface')` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<OAuth\Common\Stor...\TokenStorageInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
21			);
22
23			self::assertInstanceOf('\\OAuth\\OAuth2\\Service\\ServiceInterface', $service);
24			}
25
26			/**
27			* @covers \OAuth\OAuth2\Service\Slack::__construct
28			*/
29			public function testConstructCorrectInstanceWithoutCustomUri(): void
30			{
31			$service = new Slack(
32			$this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
			0 ignored issues – show Documentation introduced 2020-12-28 18:48 UTC by Report Bug Copy Issue Report `$this->createMock('\\OAu...\CredentialsInterface')` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<OAuth\Common\Cons...r\CredentialsInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
33			$this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface'),
			0 ignored issues – show Documentation introduced 2020-12-28 18:48 UTC by Report Bug Copy Issue Report `$this->createMock('\\OAu...ient\\ClientInterface')` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<OAuth\Common\Http\Client\ClientInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
34			$this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
			0 ignored issues – show Documentation introduced 2020-12-28 18:48 UTC by Report Bug Copy Issue Report `$this->createMock('\\OAu...TokenStorageInterface')` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<OAuth\Common\Stor...\TokenStorageInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...

Lusitanian / PHPoAuthLib

Pull Request — master (#571)

testConstructCorrectInstanceWithoutCustomUri() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like