StravaTest - Code Metrics - Lusitanian/PHPoAuthLib - Measure and Improve Code Quality continuously with Scrutinizer

StravaTest A
last analyzed 2020-10-09 22:28 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	169
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

Metric	Value
dl	0
loc	169
c	0
b	0
f	0
wmc	10
lcom	1
cbo	5
rs	10

9 Methods

Rating	Name	Size	Complexity
A	testConstructCorrectInterfaceWithoutCustomUri()	10	1
A	testConstructCorrectInstanceWithoutCustomUri()	10	1
A	testConstructCorrectInstanceWithCustomUri()	12	1
A	testGetAuthorizationEndpoint()	20	1
A	testGetAuthorizationEndpointException()	17	2
A	testGetAccessTokenEndpoint()	13	1
A	testParseAccessTokenResponseThrowsExceptionOnNulledResponse()	15	1
A	testParseAccessTokenResponseThrowsExceptionOnError()	15	1
A	testParseAccessTokenResponseValid()	13	1

<?php

namespace OAuthTest\Unit\OAuth2\Service;

use OAuth\OAuth2\Service\Strava;
use PHPUnit\Framework\TestCase;

class StravaTest extends TestCase
{
    /**
     * @covers \OAuth\OAuth2\Service\Strava::__construct
     */
    public function testConstructCorrectInterfaceWithoutCustomUri(): void
    {
        $service = new Strava(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        self::assertInstanceOf('\\OAuth\\OAuth2\\Service\\ServiceInterface', $service);
    }

    /**
     * @covers \OAuth\OAuth2\Service\Strava::__construct
     */
    public function testConstructCorrectInstanceWithoutCustomUri(): void
    {
        $service = new Strava(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        self::assertInstanceOf('\\OAuth\\OAuth2\\Service\\AbstractService', $service);
    }

    /**
     * @covers \OAuth\OAuth2\Service\Strava::__construct
     */
    public function testConstructCorrectInstanceWithCustomUri(): void
    {
        $service = new Strava(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            [],
            $this->createMock('\\OAuth\\Common\\Http\\Uri\\UriInterface')
        );

        self::assertInstanceOf('\\OAuth\\OAuth2\\Service\\AbstractService', $service);
    }

    /**
     * @covers \OAuth\OAuth2\Service\Strava::__construct
     * @covers \OAuth\OAuth2\Service\Strava::getAuthorizationEndpoint
     */
    public function testGetAuthorizationEndpoint(): void
    {
        $service = new Strava(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        self::assertSame(
            'https://www.strava.com/oauth/authorize?approval_prompt=auto',
            $service->getAuthorizationEndpoint()->getAbsoluteUri()
        );

        // Verify that 'offine' works
        $service->setApprouvalPrompt('force');
        self::assertSame(
            'https://www.strava.com/oauth/authorize?approval_prompt=force',
            $service->getAuthorizationEndpoint()->getAbsoluteUri()
        );
    }

    /**
     * @covers \OAuth\OAuth2\Service\Strava::__construct
     * @covers \OAuth\OAuth2\Service\Strava::getAuthorizationEndpoint
     */
    public function testGetAuthorizationEndpointException(): void
    {
        $service = new Strava(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        $this->expectException('OAuth\OAuth2\Service\Exception\InvalidAccessTypeException');

        try {
            $service->setApprouvalPrompt('invalid');
        } catch (InvalidAccessTypeException $e) {

            return;
        }
        self::fail('Expected InvalidAccessTypeException not thrown');
    }

    /**
     * @covers \OAuth\OAuth2\Service\Strava::__construct
     * @covers \OAuth\OAuth2\Service\Strava::getAccessTokenEndpoint
     */
    public function testGetAccessTokenEndpoint(): void
    {
        $service = new Strava(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        self::assertSame(
            'https://www.strava.com/oauth/token',
            $service->getAccessTokenEndpoint()->getAbsoluteUri()
        );
    }

    /**
     * @covers \OAuth\OAuth2\Service\Strava::__construct
     * @covers \OAuth\OAuth2\Service\Strava::parseAccessTokenResponse
     */
    public function testParseAccessTokenResponseThrowsExceptionOnNulledResponse(): void
    {
        $client = $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface');
        $client->expects(self::once())->method('retrieveResponse')->willReturn(null);

        $service = new Strava(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $client,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        $this->expectException('\\OAuth\\Common\\Http\\Exception\\TokenResponseException');

        $service->requestAccessToken('foo');
    }

    /**
     * @covers \OAuth\OAuth2\Service\Strava::__construct
     * @covers \OAuth\OAuth2\Service\Strava::parseAccessTokenResponse
     */
    public function testParseAccessTokenResponseThrowsExceptionOnError(): void
    {
        $client = $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface');
        $client->expects(self::once())->method('retrieveResponse')->willReturn('error=some_error');

        $service = new Strava(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $client,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        $this->expectException('\\OAuth\\Common\\Http\\Exception\\TokenResponseException');

        $service->requestAccessToken('foo');
    }

    /**
     * @covers \OAuth\OAuth2\Service\Strava::__construct
     * @covers \OAuth\OAuth2\Service\Strava::parseAccessTokenResponse
     */
    public function testParseAccessTokenResponseValid(): void
    {
        $client = $this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface');
        $client->expects(self::once())->method('retrieveResponse')->willReturn('{"access_token":"foo","expires_in":"bar"}');

        $service = new Strava(
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $client,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        self::assertInstanceOf('\\OAuth\\OAuth2\\Token\\StdOAuth2Token', $service->requestAccessToken('foo'));
    }
}


1			<?php
2
3			namespace OAuthTest\Unit\OAuth2\Service;
4
5			use OAuth\OAuth2\Service\Strava;
6			use PHPUnit\Framework\TestCase;
7
8			class StravaTest extends TestCase
9			{
10			/**
11			* @covers \OAuth\OAuth2\Service\Strava::__construct
12			*/
13			public function testConstructCorrectInterfaceWithoutCustomUri(): void
14			{
15			$service = new Strava(
16			$this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
			0 ignored issues – show Documentation introduced 2020-06-30 20:36 UTC by Report Bug Copy Issue Report `$this->createMock('\\OAu...\CredentialsInterface')` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<OAuth\Common\Cons...r\CredentialsInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
17			$this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface'),
			0 ignored issues – show Documentation introduced 2020-06-30 20:36 UTC by Report Bug Copy Issue Report `$this->createMock('\\OAu...ient\\ClientInterface')` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<OAuth\Common\Http\Client\ClientInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
18			$this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
			0 ignored issues – show Documentation introduced 2020-06-30 20:36 UTC by Report Bug Copy Issue Report `$this->createMock('\\OAu...TokenStorageInterface')` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<OAuth\Common\Stor...\TokenStorageInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
19			);
20
21			self::assertInstanceOf('\\OAuth\\OAuth2\\Service\\ServiceInterface', $service);
22			}
23
24			/**
25			* @covers \OAuth\OAuth2\Service\Strava::__construct
26			*/
27			public function testConstructCorrectInstanceWithoutCustomUri(): void
28			{
29			$service = new Strava(
30			$this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
			0 ignored issues – show Documentation introduced 2020-06-30 20:36 UTC by Report Bug Copy Issue Report `$this->createMock('\\OAu...\CredentialsInterface')` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<OAuth\Common\Cons...r\CredentialsInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
31			$this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface'),
			0 ignored issues – show Documentation introduced 2020-06-30 20:36 UTC by Report Bug Copy Issue Report `$this->createMock('\\OAu...ient\\ClientInterface')` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<OAuth\Common\Http\Client\ClientInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32			$this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
			0 ignored issues – show Documentation introduced 2020-06-30 20:36 UTC by Report Bug Copy Issue Report `$this->createMock('\\OAu...TokenStorageInterface')` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<OAuth\Common\Stor...\TokenStorageInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
33			);
34

Lusitanian / PHPoAuthLib

StravaTest A last analyzed 2020-10-09 22:28 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

Duplication Side-by-Side

Filter issues like

StravaTest A
last analyzed 2020-10-09 22:28 UTC