ServiceFactoryTest - Code Metrics - Lusitanian/PHPoAuthLib - Measure and Improve Code Quality continuously with Scrutinizer

ServiceFactoryTest A
last analyzed 2020-10-09 22:28 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	297
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
dl	0
loc	297
c	0
b	0
f	0
wmc	16
lcom	1
cbo	2
rs	10

16 Methods

Rating	Name	Size	Complexity
A	testSetHttpClient()	9	1
A	testRegisterServiceThrowsExceptionNonExistentClass()	7	1
A	testRegisterServiceThrowsExceptionWithClassIncorrectImplementation()	7	1
A	testRegisterServiceSuccessOAuth1()	9	1
A	testRegisterServiceSuccessOAuth2()	9	1
A	testCreateServiceOAuth1NonRegistered()	12	1
A	testCreateServiceOAuth1Registered()	15	1
A	testCreateServiceOAuth1RegisteredAndNonRegisteredSameName()	15	1
A	testCreateServiceOAuth2NonRegistered()	12	1
A	testCreateServiceOAuth2Registered()	15	1
A	testCreateServiceOAuth2RegisteredAndNonRegisteredSameName()	15	1
A	testCreateServiceThrowsExceptionOnPassingScopesToV1Service()	15	1
A	testCreateServiceNonExistentService()	12	1
A	testCreateServicePrefersOauth2()	16	1
A	testCreateServiceOAuth2RegisteredWithClassConstantsAsScope()	16	1
A	testCreateServiceOAuth2RegisteredWithCustomScope()	16	1

<?php
/**
 * @author     David Desberg <[email protected]>
 * @author     Chris Heng <[email protected]>
 * @author     Pieter Hordijk <[email protected]>
 * @license    http://www.opensource.org/licenses/mit-license.html  MIT License
 */

namespace OAuth\Unit;

use OAuth\ServiceFactory;
use PHPUnit\Framework\TestCase;

class ServiceFactoryTest extends TestCase
{
    /**
     * @covers \OAuth\ServiceFactory::setHttpClient
     */
    public function testSetHttpClient(): void
    {
        $factory = new ServiceFactory();

        self::assertInstanceOf(
            '\\OAuth\\ServiceFactory',
            $factory->setHttpClient($this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface'))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );
    }

    /**
     * @covers \OAuth\ServiceFactory::registerService
     */
    public function testRegisterServiceThrowsExceptionNonExistentClass(): void
    {
        $this->expectException('\\OAuth\Common\Exception\Exception');

        $factory = new ServiceFactory();
        $factory->registerService('foo', 'bar');
    }

    /**
     * @covers \OAuth\ServiceFactory::registerService
     */
    public function testRegisterServiceThrowsExceptionWithClassIncorrectImplementation(): void
    {
        $this->expectException('\\OAuth\Common\Exception\Exception');

        $factory = new ServiceFactory();
        $factory->registerService('foo', 'OAuth\\ServiceFactory');
    }

    /**
     * @covers \OAuth\ServiceFactory::registerService
     */
    public function testRegisterServiceSuccessOAuth1(): void
    {
        $factory = new ServiceFactory();

        self::assertInstanceOf(
            '\\OAuth\\ServiceFactory',
            $factory->registerService('foo', '\\OAuthTest\\Mocks\\OAuth1\\Service\\Fake')
        );
    }

    /**
     * @covers \OAuth\ServiceFactory::registerService
     */
    public function testRegisterServiceSuccessOAuth2(): void
    {
        $factory = new ServiceFactory();

        self::assertInstanceOf(
            '\\OAuth\\ServiceFactory',
            $factory->registerService('foo', '\\OAuthTest\\Mocks\\OAuth2\\Service\\Fake')
        );
    }

    /**
     * @covers \OAuth\ServiceFactory::buildV1Service
     * @covers \OAuth\ServiceFactory::createService
     * @covers \OAuth\ServiceFactory::getFullyQualifiedServiceName
     */
    public function testCreateServiceOAuth1NonRegistered(): void
    {
        $factory = new ServiceFactory();

        $service = $factory->createService(
            'twitter',
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        self::assertInstanceOf('\\OAuth\\OAuth1\\Service\\Twitter', $service);
    }

    /**
     * @covers \OAuth\ServiceFactory::buildV1Service
     * @covers \OAuth\ServiceFactory::createService
     * @covers \OAuth\ServiceFactory::getFullyQualifiedServiceName
     * @covers \OAuth\ServiceFactory::registerService
     */
    public function testCreateServiceOAuth1Registered(): void
    {
        $factory = new ServiceFactory();

        $factory->registerService('foo', '\\OAuthTest\\Mocks\\OAuth1\\Service\\Fake');

        $service = $factory->createService(
            'foo',
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        self::assertInstanceOf('\\OAuth\OAuth1\Service\\ServiceInterface', $service);
        self::assertInstanceOf('\\OAuthTest\\Mocks\\OAuth1\\Service\\Fake', $service);
    }

    /**
     * @covers \OAuth\ServiceFactory::buildV1Service
     * @covers \OAuth\ServiceFactory::createService
     * @covers \OAuth\ServiceFactory::getFullyQualifiedServiceName
     * @covers \OAuth\ServiceFactory::registerService
     */
    public function testCreateServiceOAuth1RegisteredAndNonRegisteredSameName(): void
    {
        $factory = new ServiceFactory();

        $factory->registerService('twitter', '\\OAuthTest\\Mocks\\OAuth1\\Service\\Fake');

        $service = $factory->createService(
            'twitter',
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        self::assertInstanceOf('\\OAuth\OAuth1\Service\\ServiceInterface', $service);
        self::assertInstanceOf('\\OAuthTest\\Mocks\\OAuth1\\Service\\Fake', $service);
    }

    /**
     * @covers \OAuth\ServiceFactory::buildV2Service
     * @covers \OAuth\ServiceFactory::createService
     * @covers \OAuth\ServiceFactory::getFullyQualifiedServiceName
     * @covers \OAuth\ServiceFactory::resolveScopes
     */
    public function testCreateServiceOAuth2NonRegistered(): void
    {
        $factory = new ServiceFactory();

        $service = $factory->createService(
            'facebook',
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        self::assertInstanceOf('\\OAuth\\OAuth2\\Service\\Facebook', $service);
    }

    /**
     * @covers \OAuth\ServiceFactory::buildV2Service
     * @covers \OAuth\ServiceFactory::createService
     * @covers \OAuth\ServiceFactory::getFullyQualifiedServiceName
     * @covers \OAuth\ServiceFactory::resolveScopes
     */
    public function testCreateServiceOAuth2Registered(): void
    {
        $factory = new ServiceFactory();

        $factory->registerService('foo', '\\OAuthTest\\Mocks\\OAuth2\\Service\\Fake');

        $service = $factory->createService(
            'foo',
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        self::assertInstanceOf('\\OAuth\OAuth2\Service\\ServiceInterface', $service);
        self::assertInstanceOf('\\OAuthTest\\Mocks\\OAuth2\\Service\\Fake', $service);
    }

    /**
     * @covers \OAuth\ServiceFactory::buildV2Service
     * @covers \OAuth\ServiceFactory::createService
     * @covers \OAuth\ServiceFactory::getFullyQualifiedServiceName
     * @covers \OAuth\ServiceFactory::resolveScopes
     */
    public function testCreateServiceOAuth2RegisteredAndNonRegisteredSameName(): void
    {
        $factory = new ServiceFactory();

        $factory->registerService('facebook', '\\OAuthTest\\Mocks\\OAuth2\\Service\\Fake');

        $service = $factory->createService(
            'facebook',
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        self::assertInstanceOf('\\OAuth\OAuth2\Service\\ServiceInterface', $service);
        self::assertInstanceOf('\\OAuthTest\\Mocks\\OAuth2\\Service\\Fake', $service);
    }

    /**
     * @covers \OAuth\ServiceFactory::buildV1Service
     * @covers \OAuth\ServiceFactory::createService
     * @covers \OAuth\ServiceFactory::getFullyQualifiedServiceName
     * @covers \OAuth\ServiceFactory::registerService
     */
    public function testCreateServiceThrowsExceptionOnPassingScopesToV1Service(): void
    {
        $this->expectException('\\OAuth\Common\Exception\Exception');

        $factory = new ServiceFactory();

        $factory->registerService('foo', '\\OAuthTest\\Mocks\\OAuth1\\Service\\Fake');

        $service = $factory->createService(
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            'foo',
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ['bar']
        );
    }

    /**
     * @covers \OAuth\ServiceFactory::createService
     * @covers \OAuth\ServiceFactory::getFullyQualifiedServiceName
     */
    public function testCreateServiceNonExistentService(): void
    {
        $factory = new ServiceFactory();

        $service = $factory->createService(
            'foo',
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        self::assertNull($service);
    }

    /**
     * @covers \OAuth\ServiceFactory::buildV2Service
     * @covers \OAuth\ServiceFactory::createService
     * @covers \OAuth\ServiceFactory::getFullyQualifiedServiceName
     * @covers \OAuth\ServiceFactory::registerService
     * @covers \OAuth\ServiceFactory::resolveScopes
     */
    public function testCreateServicePrefersOauth2(): void
    {
        $factory = new ServiceFactory();

        $factory->registerService('foo', '\\OAuthTest\\Mocks\\OAuth1\\Service\\Fake');
        $factory->registerService('foo', '\\OAuthTest\\Mocks\\OAuth2\\Service\\Fake');

        $service = $factory->createService(
            'foo',
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        self::assertInstanceOf('\\OAuth\OAuth2\Service\\ServiceInterface', $service);
        self::assertInstanceOf('\\OAuthTest\\Mocks\\OAuth2\\Service\\Fake', $service);
    }

    /**
     * @covers \OAuth\ServiceFactory::buildV2Service
     * @covers \OAuth\ServiceFactory::createService
     * @covers \OAuth\ServiceFactory::getFullyQualifiedServiceName
     * @covers \OAuth\ServiceFactory::resolveScopes
     */
    public function testCreateServiceOAuth2RegisteredWithClassConstantsAsScope(): void
    {
        $factory = new ServiceFactory();

        $factory->registerService('foo', '\\OAuthTest\\Mocks\\OAuth2\\Service\\Fake');

        $service = $factory->createService(
            'foo',
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ['FOO']
        );

        self::assertInstanceOf('\\OAuth\OAuth2\Service\\ServiceInterface', $service);
        self::assertInstanceOf('\\OAuthTest\\Mocks\\OAuth2\\Service\\Fake', $service);
    }

    /**
     * @covers \OAuth\ServiceFactory::buildV2Service
     * @covers \OAuth\ServiceFactory::createService
     * @covers \OAuth\ServiceFactory::getFullyQualifiedServiceName
     * @covers \OAuth\ServiceFactory::resolveScopes
     */
    public function testCreateServiceOAuth2RegisteredWithCustomScope(): void
    {
        $factory = new ServiceFactory();

        $factory->registerService('foo', '\\OAuthTest\\Mocks\\OAuth2\\Service\\Fake');

        $service = $factory->createService(
            'foo',
            $this->createMock('\\OAuth\\Common\\Consumer\\CredentialsInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->createMock('\\OAuth\\Common\\Storage\\TokenStorageInterface'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ['custom']
        );

        self::assertInstanceOf('\\OAuth\OAuth2\Service\\ServiceInterface', $service);
        self::assertInstanceOf('\\OAuthTest\\Mocks\\OAuth2\\Service\\Fake', $service);
    }
}


1			<?php
2			/**
3			* @author David Desberg <[email protected]>
4			* @author Chris Heng <[email protected]>
5			* @author Pieter Hordijk <[email protected]>
6			* @license http://www.opensource.org/licenses/mit-license.html MIT License
7			*/
8
9			namespace OAuth\Unit;
10
11			use OAuth\ServiceFactory;
12			use PHPUnit\Framework\TestCase;
13
14			class ServiceFactoryTest extends TestCase
15			{
16			/**
17			* @covers \OAuth\ServiceFactory::setHttpClient
18			*/
19			public function testSetHttpClient(): void
20			{
21			$factory = new ServiceFactory();
22
23			self::assertInstanceOf(
24			'\\OAuth\\ServiceFactory',
25			$factory->setHttpClient($this->createMock('\\OAuth\\Common\\Http\\Client\\ClientInterface'))
			0 ignored issues – show Documentation introduced 2020-06-30 20:36 UTC by Report Bug Copy Issue Report `$this->createMock('\\OAu...ient\\ClientInterface')` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<OAuth\Common\Http\Client\ClientInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
26			);
27			}
28
29			/**
30			* @covers \OAuth\ServiceFactory::registerService
31			*/
32			public function testRegisterServiceThrowsExceptionNonExistentClass(): void
33			{
34			$this->expectException('\\OAuth\Common\Exception\Exception');
35
36			$factory = new ServiceFactory();
37			$factory->registerService('foo', 'bar');
38			}
39

Lusitanian / PHPoAuthLib

ServiceFactoryTest A last analyzed 2020-10-09 22:28 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

16 Methods

Duplication Side-by-Side

Filter issues like

ServiceFactoryTest A
last analyzed 2020-10-09 22:28 UTC