Issues in ComponentSpecification.php (master) - Issues in master - LukeCarrier/moodle-componentmgr - Measure and Improve Code Quality continuously with Scrutinizer

Issues (73)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/ComponentManager/ComponentSpecification.php (3 issues)

Labels

Documentation 3

Severity

Informational 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Moodle component manager.
 *
 * @author Luke Carrier <[email protected]>
 * @copyright 2016 Luke Carrier
 * @license GPL-3.0+
 */

namespace ComponentManager;

use OutOfBoundsException;
use stdClass;

/**
 * Component specification.
 *
 * A component specification is a structure used to hold all information about a
 * specific component before we're able to look up the component in the
 * associated package source. We should resolve this to obtain a Component
 * object as soon as we can during installation.
 */
class ComponentSpecification {
    /**
     * Component name.
     *
     * @var string
     */
    protected $name;

    /**
     * Package repository.
     *
     * @var string
     */
    protected $packageRepository;

    /**
     * Package source.
     *
     * @var string
     */
    protected $packageSource;

    /**
     * Component version.
     *
     * @var string
     */
    protected $version;

    /**
     * Extra metadata.
     *
     * @var stdClass
     */
    protected $extra;

    /**
     * Initialiser.
     *
     * @param string   $name
     * @param string   $version
     * @param string   $packageRepository

     * @param string   $packageSource

     * @param stdClass $extra

     */
    public function __construct($name, $version, $packageRepository=null,
                                $packageSource=null, stdClass $extra=null) {
        $this->name    = $name;
        $this->version = $version;

        $this->packageRepository = $packageRepository;
        $this->packageSource     = $packageSource;

        $this->extra = $extra;
    }

    /**
     * Get the component's name.
     *
     * @return string
     *
     * @codeCoverageIgnore
     */
    public function getName() {
        return $this->name;
    }

    /**
     * Get the ID of the component's package repository.
     *
     * @return string
     *
     * @codeCoverageIgnore
     */
    public function getPackageRepository() {
        return $this->packageRepository;
    }

    /**
     * Get the ID of the component's package source.
     *
     * @return string
     *
     * @codeCoverageIgnore
     */
    public function getPackageSource() {
        return $this->packageSource;
    }

    /**
     * Get the component's version.
     *
     * @return string
     *
     * @codeCoverageIgnore
     */
    public function getVersion() {
        return $this->version;
    }

    /**
     * Get the specified extra key.
     *
     * @param string $property
     *
     * @return mixed
     *
     * @throws OutOfBoundsException
     */
    public function getExtra($property) {
        if (!property_exists($this->extra, $property)) {
            throw new OutOfBoundsException(sprintf(
                    'No value specified in project file for "%s"', $property));
        }

        return $this->extra->{$property};
    }
}


1		<?php
2
3		/**
4		* Moodle component manager.
5		*
6		* @author Luke Carrier <[email protected]>
7		* @copyright 2016 Luke Carrier
8		* @license GPL-3.0+
9		*/
10
11		namespace ComponentManager;
12
13		use OutOfBoundsException;
14		use stdClass;
15
16		/**
17		* Component specification.
18		*
19		* A component specification is a structure used to hold all information about a
20		* specific component before we're able to look up the component in the
21		* associated package source. We should resolve this to obtain a Component
22		* object as soon as we can during installation.
23		*/
24		class ComponentSpecification {
25		/**
26		* Component name.
27		*
28		* @var string
29		*/
30		protected $name;
31
32		/**
33		* Package repository.
34		*
35		* @var string
36		*/
37		protected $packageRepository;
38
39		/**
40		* Package source.
41		*
42		* @var string
43		*/
44		protected $packageSource;
45
46		/**
47		* Component version.
48		*
49		* @var string
50		*/
51		protected $version;
52
53		/**
54		* Extra metadata.
55		*
56		* @var stdClass
57		*/
58		protected $extra;
59
60		/**
61		* Initialiser.
62		*
63		* @param string $name
64		* @param string $version
65		* @param string $packageRepository
		0 ignored issues – show Documentation introduced 2016-04-30 16:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$packageRepository` not be `string\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
66		* @param string $packageSource
		0 ignored issues – show Documentation introduced 2016-04-30 16:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$packageSource` not be `string\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
67		* @param stdClass $extra
		0 ignored issues – show Documentation introduced 2016-04-30 16:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$extra` not be `null\|stdClass`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
68		*/
69	1	public function __construct($name, $version, $packageRepository=null,
70		$packageSource=null, stdClass $extra=null) {
71	1	$this->name = $name;
72	1	$this->version = $version;
73
74	1	$this->packageRepository = $packageRepository;
75	1	$this->packageSource = $packageSource;
76
77	1	$this->extra = $extra;
78	1	}
79
80		/**
81		* Get the component's name.
82		*
83		* @return string
84		*
85		* @codeCoverageIgnore
86		*/
87		public function getName() {
88		return $this->name;
89		}
90
91		/**
92		* Get the ID of the component's package repository.
93		*
94		* @return string
95		*
96		* @codeCoverageIgnore
97		*/
98		public function getPackageRepository() {
99		return $this->packageRepository;
100		}
101
102		/**
103		* Get the ID of the component's package source.
104		*
105		* @return string
106		*
107		* @codeCoverageIgnore
108		*/
109		public function getPackageSource() {
110		return $this->packageSource;
111		}
112
113		/**
114		* Get the component's version.
115		*
116		* @return string
117		*
118		* @codeCoverageIgnore
119		*/
120		public function getVersion() {
121		return $this->version;
122		}
123
124		/**
125		* Get the specified extra key.
126		*
127		* @param string $property
128		*
129		* @return mixed
130		*
131		* @throws OutOfBoundsException
132		*/
133	1	public function getExtra($property) {
134	1	if (!property_exists($this->extra, $property)) {
135	1	throw new OutOfBoundsException(sprintf(
136	1	'No value specified in project file for "%s"', $property));
137		}
138
139	1	return $this->extra->{$property};
140		}
141		}
142

LukeCarrier / moodle-componentmgr

Issues (73)

Security Analysis no request data

lib/ComponentManager/ComponentSpecification.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like