LukeCarrier / moodle-componentmgr

lib/ComponentManager/VersionControl/Git/GitVersionControl.php

Unused Use Statements +1 added lines, -1 removed lines

@@ -16,8 +16,8 @@
 use ComponentManager\VersionControl\Git\Command\Command;
 use ComponentManager\VersionControl\Git\Command\FetchCommand;
 use ComponentManager\VersionControl\Git\Command\InitCommand;
-use ComponentManager\VersionControl\Git\Command\RevParseCommand;
 use ComponentManager\VersionControl\Git\Command\RemoteAddCommand;
+use ComponentManager\VersionControl\Git\Command\RevParseCommand;
 use Symfony\Component\Process\Process;
 use Symfony\Component\Process\ProcessBuilder;
 

Doc Comments +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
      *
      * @param string       $gitExecutable
      * @param string       $directory
-     * @param integer|null $timeout
+     * @param integer $timeout
      */
     public function __construct($gitExecutable, $directory, $timeout=60) {
         $this->gitExecutable = $gitExecutable;

Spacing +4 added lines, -4 removed lines

@@ -60,7 +60,7 @@ 
      * @param string       $directory
      * @param integer|null $timeout
      */
-    public function __construct($gitExecutable, $directory, $timeout=60) {
+    public function __construct($gitExecutable, $directory, $timeout = 60) {
         $this->gitExecutable = $gitExecutable;
         $this->timeout       = $timeout;
 
@@ -95,7 +95,7 @@ 
      *
      * @throws VersionControlException
      */
-    public function runCommand(Command $command, $exceptionCode=null) {
+    public function runCommand(Command $command, $exceptionCode = null) {
         $process = $this->createProcess($command->getCommandLine());
         $process->run();
 
@@ -169,7 +169,7 @@ 
      *
      * @codeCoverageIgnore
      */
-    public function fetch($remote=null) {
+    public function fetch($remote = null) {
         $command = new FetchCommand($remote);
         return $this->runCommand(
                 $command, VersionControlException::CODE_FETCH_FAILED);
@@ -186,7 +186,7 @@ 
      *
      * @codeCoverageIgnore
      */
-    public function fetchTags($remote=null) {
+    public function fetchTags($remote = null) {
         $command = new FetchCommand($remote);
         $command->setTags(true);
         return $this->runCommand(

lib/ComponentManager/VersionControl/Git/Command/FetchCommand.php

Spacing +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
      *
      * @param string|null $remote
      */
-    public function __construct($remote=null) {
+    public function __construct($remote = null) {
         $this->remote = $remote;
     }
 

lib/ComponentManager/PackageRepository/PackageRepository.php

Doc Comments +1 added lines

@@ -33,6 +33,7 @@
      * @param HttpClient $httpClient
      * @param Platform   $platform
      * @param stdClass   $options
+     * @return void
      */
     public function __construct(Filesystem $filesystem, HttpClient $httpClient,
                                 Platform $platform, stdClass $options);

Unused Use Statements +1 added lines, -1 removed lines

@@ -17,8 +17,8 @@
 use ComponentManager\HttpClient;
 use ComponentManager\Platform\Platform;
 use Psr\Log\LoggerInterface;
-use stdClass;
 use Symfony\Component\Filesystem\Filesystem;
+use stdClass;
 
 /**
  * Package repository interface.

Indentation +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
      * @throws InvalidProjectException
      */
     public function resolveComponent(ComponentSpecification $componentSpecification,
-                                     LoggerInterface $logger);
+                                        LoggerInterface $logger);
 
     /**
      * Determine whether the version specification is satisfied by the given version.

lib/ComponentManager/Platform/Platform.php

Doc Comments +1 added lines

@@ -24,6 +24,7 @@
      * Initialiser.
      *
      * @param Filesystem $filesystem
+     * @return void
      */
     public function __construct(Filesystem $filesystem);
 

lib/ComponentManager/ComponentSpecification.php

Spacing +2 added lines, -2 removed lines

@@ -66,8 +66,8 @@
      * @param string   $packageSource
      * @param stdClass $extra
      */
-    public function __construct($name, $version, $packageRepository=null,
-                                $packageSource=null, stdClass $extra=null) {
+    public function __construct($name, $version, $packageRepository = null,
+                                $packageSource = null, stdClass $extra = null) {
         $this->name    = $name;
         $this->version = $version;
 

lib/ComponentManager/Command/ProjectAwareCommand.php

Spacing +2 added lines, -2 removed lines

@@ -137,7 +137,7 @@ 
      *
      * @return Moodle
      */
-    protected function getMoodle($moodleDirectory=null) {
+    protected function getMoodle($moodleDirectory = null) {
         if ($this->moodle === null) {
             $moodleDirectory = ($moodleDirectory === null)
                     ? $this->platform->getWorkingDirectory() : $moodleDirectory;
@@ -156,7 +156,7 @@ 
      *
      * @return Project
      */
-    protected function getProject($projectFilename=null, $projectLockFilename=null) {
+    protected function getProject($projectFilename = null, $projectLockFilename = null) {
         $workingDirectory = $this->platform->getWorkingDirectory();
 
         if ($this->project === null) {

lib/ComponentManager/Command/InstallCommand.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
     const HELP = <<<HELP
 Installs, into the Moodle installation in the present working directory, all of
 the components listed in its componentmgr.json file.
-HELP;
+help;
 
     /**
      * Initialiser.

lib/ComponentManager/Component.php

Spacing +2 added lines, -2 removed lines

@@ -65,7 +65,7 @@ 
      * @param ComponentVersion[]     $versions
      * @param PackageRepository|null $packageRepository
      */
-    public function __construct($name, $versions, $packageRepository=null) {
+    public function __construct($name, $versions, $packageRepository = null) {
         $this->name     = $name;
         $this->versions = $versions;
 
@@ -126,7 +126,7 @@ 
      * @return string
      */
     public function getPluginType() {
-        list($type, ) = $this->getNameParts();
+        list($type,) = $this->getNameParts();
 
         return $type;
     }

lib/ComponentManager/ComponentVersion.php

Spacing +1 added lines, -1 removed lines

@@ -84,7 +84,7 @@
      * @param integer                $maturity
      * @param ComponentSource[]|null $sources
      */
-    public function __construct($version, $release, $maturity, $sources=null) {
+    public function __construct($version, $release, $maturity, $sources = null) {
         $this->version  = $version;
         $this->release  = $release;
         $this->maturity = $maturity;