PlatformFactory::getPlatform() - Code Metrics - Inspection of "Rework package repository constructors" - LukeCarrier/moodle-componentmgr - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — develop (e3b860)

by Luke

created 2016-06-08 11:19 UTC

PlatformFactory::getPlatform() B

↳ Parent: PlatformFactory

Complexity

Conditions	6
Paths	6

Size

Total Lines	19
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	19
rs	8.8571
cc	6
eloc	15
nc	6
nop	1

<?php

/**
 * Moodle component manager.
 *
 * @author Luke Carrier <[email protected]>
 * @copyright 2016 Luke Carrier
 * @license GPL-3.0+
 */

namespace ComponentManager\Platform;

use ComponentManager\Exception\PlatformException;
use Symfony\Component\DependencyInjection\Definition;

class PlatformFactory {
    /**
     * Get the platform with the specified name.
     *
     * @param string $platformName The name of the platform (retrieved from
     *                             PHP_OS).
     *
     * @return \ComponentManager\Platform\Platform

     *
     * @throws \ComponentManager\Exception\PlatformException
     */
    public function getPlatform($platformName) {
        switch ($platformName) {
            case 'Darwin':
            case 'FreeBSD':
            case 'Linux':
                return new LinuxPlatform();
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

            case 'WINNT':
            case 'Windows':
                return new WindowsPlatform();
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

            default:
                throw new PlatformException(
                        sprintf('Unsupported platform %s', PHP_OS),
                        PlatformException::CODE_UNKNOWN_PLATFORM);
        }
    }
}


1			<?php
2
3			/**
4			* Moodle component manager.
5			*
6			* @author Luke Carrier <[email protected]>
7			* @copyright 2016 Luke Carrier
8			* @license GPL-3.0+
9			*/
10
11			namespace ComponentManager\Platform;
12
13			use ComponentManager\Exception\PlatformException;
14			use Symfony\Component\DependencyInjection\Definition;
15
16			class PlatformFactory {
17			/**
18			* Get the platform with the specified name.
19			*
20			* @param string $platformName The name of the platform (retrieved from
21			* PHP_OS).
22			*
23			* @return \ComponentManager\Platform\Platform
			0 ignored issues – show Documentation introduced 2016-06-08 11:33 UTC by Report Bug Copy Issue Report Should the return type not be `LinuxPlatform\|null\|WindowsPlatform`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
24			*
25			* @throws \ComponentManager\Exception\PlatformException
26			*/
27			public function getPlatform($platformName) {
28			switch ($platformName) {
29			case 'Darwin':
30			case 'FreeBSD':
31			case 'Linux':
32			return new LinuxPlatform();
33			break;
			0 ignored issues – show Unused Code introduced 2016-06-08 11:33 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
34
35			case 'WINNT':
36			case 'Windows':
37			return new WindowsPlatform();
38			break;
			0 ignored issues – show Unused Code introduced 2016-06-08 11:33 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
39
40			default:
41			throw new PlatformException(
42			sprintf('Unsupported platform %s', PHP_OS),
43			PlatformException::CODE_UNKNOWN_PLATFORM);
44			}
45			}
46			}
47

LukeCarrier / moodle-componentmgr

Branch — develop (e3b860)

PlatformFactory::getPlatform() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like