FetchCommand - Code Metrics - Inspection of "GitVersionControl: testify" - LukeCarrier/moodle-componentmgr - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — unit ( fc9abb...3cd14f )

by Luke

created 2017-10-13 19:39 UTC

FetchCommand A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	98
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	11
c	0
b	0
f	0
lcom	1
cbo	0
dl	0
loc	98
ccs	14
cts	14
cp	1
rs	10

7 Methods

Rating	Name	Size	Complexity
A	__construct()	3	1
A	getCommandLine()	13	3
A	getRemote()	3	1
A	getTags()	3	1
A	getTagsArgument()	7	3
A	setRemote()	3	1
A	setTags()	3	1

<?php

/**
 * Moodle component manager.
 *
 * @author Luke Carrier <[email protected]>
 * @copyright 2016 Luke Carrier
 * @license GPL-3.0+
 */

namespace ComponentManager\VersionControl\Git\Command;

/**
 * Fetch references from a remote.
 */
class FetchCommand implements Command {
    /**
     * The remote name.
     *
     * @var string|null
     */
    protected $remote;

    /**
     * Include tags?
     *
     * @var boolean|null
     */
    protected $tags;

    /**
     * Initialiser.
     *
     * @param string|null $remote
     */
    public function __construct($remote=null) {
        $this->remote = $remote;
    }

    /**
     * @override Command
     */
    public function getCommandLine() {
        $args = ['fetch'];

        if ($tags = $this->getTagsArgument()) {
            $args[] = $tags;
        }

        if ($this->remote) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $args[] = $this->remote;
        }

        return $args;
    }

    /**
     * Get the remote name.
     *
     * @return string

     *
     * @codeCoverageIgnore
     */
    public function getRemote() {
        return $this->remote;
    }

    /**
     * Is the fetch with tags?
     *
     * @return boolean|null
     *
     * @codeCoverageIgnore
     */
    public function getTags() {
        return $this->tags;
    }

    /**
     * Get the tags argument.
     *
     * @return string|null
     */
    protected function getTagsArgument() {
        if ($this->tags === null) {
            return null;
        }

        return '--' . ($this->tags ? '' : 'no-') . 'tags';
    }

    /**
     * Set the remote name.
     *
     * @param string $remote
     *
     * @codeCoverageIgnore
     */
    public function setRemote($remote) {
        $this->remote = $remote;
    }

    /**
     * Enable or disable tags.
     *
     * @param boolean|null $tags
     *
     * @codeCoverageIgnore
     */
    public function setTags($tags) {
        $this->tags = $tags;
    }
}


1		<?php
2
3		/**
4		* Moodle component manager.
5		*
6		* @author Luke Carrier <[email protected]>
7		* @copyright 2016 Luke Carrier
8		* @license GPL-3.0+
9		*/
10
11		namespace ComponentManager\VersionControl\Git\Command;
12
13		/**
14		* Fetch references from a remote.
15		*/
16		class FetchCommand implements Command {
17		/**
18		* The remote name.
19		*
20		* @var string\|null
21		*/
22		protected $remote;
23
24		/**
25		* Include tags?
26		*
27		* @var boolean\|null
28		*/
29		protected $tags;
30
31		/**
32		* Initialiser.
33		*
34		* @param string\|null $remote
35		*/
36	2	public function __construct($remote=null) {
37	2	$this->remote = $remote;
38	2	}
39
40		/**
41		* @override Command
42		*/
43	2	public function getCommandLine() {
44	2	$args = ['fetch'];
45
46	2	if ($tags = $this->getTagsArgument()) {
47	1	$args[] = $tags;
48		}
49
50	2	if ($this->remote) {
		0 ignored issues – show Bug Best Practice introduced 2017-10-13 19:42 UTC by Report Bug Copy Issue Report The expression `$this->remote` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
51	2	$args[] = $this->remote;
52		}
53
54	2	return $args;
55		}
56
57		/**
58		* Get the remote name.
59		*
60		* @return string
		0 ignored issues – show Documentation introduced 2017-10-13 19:42 UTC by Report Bug Copy Issue Report Should the return type not be `string\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
61		*
62		* @codeCoverageIgnore
63		*/
64		public function getRemote() {
65		return $this->remote;
66		}
67
68		/**
69		* Is the fetch with tags?
70		*
71		* @return boolean\|null
72		*
73		* @codeCoverageIgnore
74		*/
75		public function getTags() {
76		return $this->tags;
77		}
78
79		/**
80		* Get the tags argument.
81		*
82		* @return string\|null
83		*/
84	2	protected function getTagsArgument() {
85	2	if ($this->tags === null) {
86	1	return null;
87		}
88
89	1	return '--' . ($this->tags ? '' : 'no-') . 'tags';
90		}
91
92		/**
93		* Set the remote name.
94		*
95		* @param string $remote
96		*
97		* @codeCoverageIgnore
98		*/
99		public function setRemote($remote) {
100		$this->remote = $remote;
101		}
102
103		/**
104		* Enable or disable tags.
105		*
106		* @param boolean\|null $tags
107		*
108		* @codeCoverageIgnore
109		*/
110		public function setTags($tags) {
111		$this->tags = $tags;
112		}
113		}
114

LukeCarrier / moodle-componentmgr

Push — unit ( fc9abb...3cd14f )

FetchCommand A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

7 Methods

Duplication Side-by-Side

Filter issues like