LinuxPlatformTest - Code Metrics - LukeCarrier/moodle-componentmgr - Measure and Improve Code Quality continuously with Scrutinizer

LinuxPlatformTest A
last analyzed 2018-03-07 12:10 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	84
Duplicated Lines	8.33 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	7
lcom	1
cbo	2
dl	7
loc	84
rs	10
c	0
b	0
f	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	tearDown()	0	3	1
A	testExpandPath()	0	6	1
A	testGetExecutablePath()	0	4	1
A	testGetExecutablePathThrows()	0	3	1
A	testGetHomeDirectory()	0	3	1
A	testGetLocalSharedDirectory()	0	3	1
A	setUp()	7	7	1

How to fix Duplicated Code

<?php

/**
 * Moodle component manager.
 *
 * @author Luke Carrier <[email protected]>
 * @copyright 2016 Luke Carrier
 * @license GPL-3.0+
 */

namespace ComponentManager\Test\Platform;

use ComponentManager\Platform\LinuxPlatform;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Filesystem\Filesystem;

/**
 * @coversDefaultClass \ComponentManager\Platform\LinuxPlatform
 * @group platform
 * @group platform-linux
 */
class LinuxPlatformTest extends TestCase {
    /**
     * @var string
     */
    protected $oldPath;

    /**
     * @var LinuxPlatform
     */
    protected $platform;

    /**
     * @inheritdoc TestCase
     */
    public function setUp() {

        $this->oldPath = getenv('PATH');
        putenv("PATH=/bin:{$this->oldPath}");
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);

        $filesystem = $this->createMock(Filesystem::class);
        $this->platform = new LinuxPlatform($filesystem);
    }

    /**
     * @inheritdoc TestCase
     */
    public function tearDown() {
        putenv("PATH={$this->oldPath}");
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
    }

    /**
     * @covers ::expandPath
     * @covers \ComponentManager\Platform\AbstractPlatform::__construct
     * @covers \ComponentManager\Platform\AbstractPlatform::getDirectorySeparator
     * @covers \ComponentManager\Platform\LinuxPlatform::getHomeDirectory
     */
    public function testExpandPath() {
        $expected = getenv('HOME') . '/test';
        $actual   = $this->platform->expandPath('~/test');

        $this->assertEquals($expected, $actual);
    }

    /**
     * @covers ::getExecutablePath
     * @covers \ComponentManager\Platform\AbstractPlatform::__construct
     * @covers \ComponentManager\Platform\AbstractPlatform::getDirectorySeparator
     * @covers \ComponentManager\Platform\AbstractPlatform::joinPaths
     */
    public function testGetExecutablePath() {
        $this->assertEquals(
                '/bin/sh', $this->platform->getExecutablePath('sh'));
    }

    /**
     * @covers ::getExecutablePath
     * @covers \ComponentManager\Platform\AbstractPlatform::__construct
     * @covers \ComponentManager\Platform\AbstractPlatform::getDirectorySeparator
     * @covers \ComponentManager\Platform\AbstractPlatform::joinPaths
     * @expectedException \ComponentManager\Exception\PlatformException
     * @expectedExceptionCode 2
     */
    public function testGetExecutablePathThrows() {
        $this->platform->getExecutablePath('likelynotathing');
    }

    /**
     * @covers ::getHomeDirectory
     * @covers \ComponentManager\Platform\AbstractPlatform::__construct
     */
    public function testGetHomeDirectory() {
        $this->assertFileExists($this->platform->getHomeDirectory());
    }

    /**
     * @covers ::getHomeDirectory
     * @covers ::getLocalSharedDirectory
     * @covers \ComponentManager\Platform\AbstractPlatform::__construct
     * @covers \ComponentManager\Platform\AbstractPlatform::getDirectorySeparator
     * @covers \ComponentManager\Platform\AbstractPlatform::joinPaths
     */
    public function testGetLocalSharedDirectory() {
        $this->assertFileExists($this->platform->getLocalSharedDirectory());
    }
}


1		<?php
2
3		/**
4		* Moodle component manager.
5		*
6		* @author Luke Carrier <[email protected]>
7		* @copyright 2016 Luke Carrier
8		* @license GPL-3.0+
9		*/
10
11		namespace ComponentManager\Test\Platform;
12
13		use ComponentManager\Platform\LinuxPlatform;
14		use PHPUnit\Framework\TestCase;
15		use Symfony\Component\Filesystem\Filesystem;
16
17		/**
18		* @coversDefaultClass \ComponentManager\Platform\LinuxPlatform
19		* @group platform
20		* @group platform-linux
21		*/
22		class LinuxPlatformTest extends TestCase {
23		/**
24		* @var string
25		*/
26		protected $oldPath;
27
28		/**
29		* @var LinuxPlatform
30		*/
31		protected $platform;
32
33		/**
34		* @inheritdoc TestCase
35		*/
36	View Code Duplication	public function setUp() {
		0 ignored issues – show Duplication introduced 2017-10-22 14:25 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37		$this->oldPath = getenv('PATH');
38		putenv("PATH=/bin:{$this->oldPath}");
		0 ignored issues – show Coding Style Best Practice introduced 2016-06-08 11:33 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$this` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
39
40		$filesystem = $this->createMock(Filesystem::class);
41		$this->platform = new LinuxPlatform($filesystem);
42		}
43
44		/**
45		* @inheritdoc TestCase
46		*/
47		public function tearDown() {
48		putenv("PATH={$this->oldPath}");
		0 ignored issues – show Coding Style Best Practice introduced 2016-06-08 11:33 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$this` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
49		}
50
51		/**
52		* @covers ::expandPath
53		* @covers \ComponentManager\Platform\AbstractPlatform::__construct
54		* @covers \ComponentManager\Platform\AbstractPlatform::getDirectorySeparator
55		* @covers \ComponentManager\Platform\LinuxPlatform::getHomeDirectory
56		*/
57		public function testExpandPath() {
58		$expected = getenv('HOME') . '/test';
59		$actual = $this->platform->expandPath('~/test');
60
61		$this->assertEquals($expected, $actual);
62		}
63
64		/**
65		* @covers ::getExecutablePath
66		* @covers \ComponentManager\Platform\AbstractPlatform::__construct
67		* @covers \ComponentManager\Platform\AbstractPlatform::getDirectorySeparator
68		* @covers \ComponentManager\Platform\AbstractPlatform::joinPaths
69		*/
70		public function testGetExecutablePath() {
71		$this->assertEquals(
72		'/bin/sh', $this->platform->getExecutablePath('sh'));
73		}
74
75		/**
76		* @covers ::getExecutablePath
77		* @covers \ComponentManager\Platform\AbstractPlatform::__construct
78		* @covers \ComponentManager\Platform\AbstractPlatform::getDirectorySeparator
79		* @covers \ComponentManager\Platform\AbstractPlatform::joinPaths
80		* @expectedException \ComponentManager\Exception\PlatformException
81		* @expectedExceptionCode 2
82		*/
83		public function testGetExecutablePathThrows() {
84		$this->platform->getExecutablePath('likelynotathing');
85		}
86
87		/**
88		* @covers ::getHomeDirectory
89		* @covers \ComponentManager\Platform\AbstractPlatform::__construct
90		*/
91		public function testGetHomeDirectory() {
92		$this->assertFileExists($this->platform->getHomeDirectory());
93		}
94
95		/**
96		* @covers ::getHomeDirectory
97		* @covers ::getLocalSharedDirectory
98		* @covers \ComponentManager\Platform\AbstractPlatform::__construct
99		* @covers \ComponentManager\Platform\AbstractPlatform::getDirectorySeparator
100		* @covers \ComponentManager\Platform\AbstractPlatform::joinPaths
101		*/
102		public function testGetLocalSharedDirectory() {
103		$this->assertFileExists($this->platform->getLocalSharedDirectory());
104		}
105		}
106

LukeCarrier / moodle-componentmgr

LinuxPlatformTest A last analyzed 2018-03-07 12:10 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

LinuxPlatformTest A
last analyzed 2018-03-07 12:10 UTC