Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
32 | abstract class ProjectAwareCommand extends Command { |
||
33 | /** |
||
34 | * Project filename. |
||
35 | * |
||
36 | * @var string |
||
37 | */ |
||
38 | const PROJECT_FILENAME = 'componentmgr.json'; |
||
39 | |||
40 | /** |
||
41 | * Project lock filename. |
||
42 | * |
||
43 | * @var string |
||
44 | */ |
||
45 | const PROJECT_LOCK_FILENAME = 'componentmgr.lock.json'; |
||
46 | |||
47 | /** |
||
48 | * Filesystem. |
||
49 | * |
||
50 | * @var Filesystem |
||
51 | */ |
||
52 | protected $filesystem; |
||
53 | |||
54 | /** |
||
55 | * Logger. |
||
56 | * |
||
57 | * @var LoggerInterface |
||
58 | */ |
||
59 | protected $logger; |
||
60 | |||
61 | /** |
||
62 | * Moodle bridge. |
||
63 | * |
||
64 | * @var Moodle |
||
65 | */ |
||
66 | protected $moodle; |
||
67 | |||
68 | /** |
||
69 | * Package format factory. |
||
70 | * |
||
71 | * @var PackageFormatFactory |
||
72 | */ |
||
73 | protected $packageFormatFactory; |
||
74 | |||
75 | /** |
||
76 | * Package repository factory. |
||
77 | * |
||
78 | * @var PackageRepositoryFactory |
||
79 | */ |
||
80 | protected $packageRepositoryFactory; |
||
81 | |||
82 | /** |
||
83 | * Package source factory. |
||
84 | * |
||
85 | * @var PackageSourceFactory |
||
86 | */ |
||
87 | protected $packageSourceFactory; |
||
88 | |||
89 | /** |
||
90 | * Project. |
||
91 | * |
||
92 | * Lazily loaded -- be sure to call getProject() in order to ensure the |
||
93 | * value is defined. |
||
94 | * |
||
95 | * @var Project |
||
96 | */ |
||
97 | protected $project; |
||
98 | |||
99 | /** |
||
100 | * Platform support library. |
||
101 | * |
||
102 | * @var Platform |
||
103 | */ |
||
104 | protected $platform; |
||
105 | |||
106 | /** |
||
107 | * Initialiser. |
||
108 | * |
||
109 | * @param PackageRepositoryFactory $packageRepositoryFactory |
||
110 | * @param PackageSourceFactory $packageSourceFactory |
||
111 | * @param PackageFormatFactory $packageFormatFactory |
||
112 | * @param Platform $platform |
||
113 | * @param Filesystem $filesystem |
||
114 | * @param LoggerInterface $logger |
||
115 | */ |
||
116 | public function __construct(PackageRepositoryFactory $packageRepositoryFactory, |
||
132 | |||
133 | /** |
||
134 | * Get the Moodle bridge. |
||
135 | * |
||
136 | * @param string|null $moodleDirectory |
||
137 | * |
||
138 | * @return Moodle |
||
139 | */ |
||
140 | protected function getMoodle($moodleDirectory=null) { |
||
150 | |||
151 | /** |
||
152 | * Get project. |
||
153 | * |
||
154 | * @param string|null $projectFilename |
||
155 | * @param string|null $projectLockFilename |
||
156 | * |
||
157 | * @return Project |
||
158 | */ |
||
159 | protected function getProject($projectFilename=null, $projectLockFilename=null) { |
||
196 | } |
||
197 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.