LukasMeine / vigilance

application/services/updater.js

module.exports = Updater;
var exec = require("child_process").exec;
var log = require("captains-log")();
const isOnline = require("is-online");
var lostConnection = false;
const notifier = require("node-notifier");
const pathModule = require("path");

var commands = null;

function Updater() {}

Updater.prototype.verify_git = function(path, branch, command) {
  commands = command;

  check_connection(path, branch);
};

function send_notification(notification_message) {
  notifier.notify({
    title: "Devmind Vigilance",
    message: notification_message,
    icon: pathModule.join(
      pathModule.resolve(__dirname, "..") + "/includes",
      "devmind.png"
    ), // Absolute path (doesn't work on balloons)
    sound: true, // Only Notification Center or Windows Toasters
    wait: false
  });
}

function check_connection(path, branch) {
  isOnline().then(online => {
    if (online == true) {

Comparing online to true using the == operator is not safe. Consider using === instead.

      if (lostConnection == true) {

Comparing lostConnection to true using the == operator is not safe. Consider using === instead.

        log.info("Connection restablished.");
        send_notification("Vigilance Connection restablished.");
        lostConnection = false;
      }
      timed_check(path, branch);
    } else {
      setTimeout(function() {
        log.info("Connection lost. Trying again in 3 seconds.");
        send_notification(
          "Vigilance connection lost. Trying again in 3 seconds."
        );
        lostConnection = true;
        check_connection(path, branch);
      }, 3000);
    }
  });
}

function timed_check(path, branch) {
  shell_exec(
    path,
    "git fetch &&  git diff " +
      branch +
      " origin/" +
      branch +
      ' --quiet || echo "untracked"',
    false,
    branch
  );
}

function work_on_response(response, path, stop, branch) {
  if (response.trim().includes("untracked")) {
    log.info("updating local files..");
    exec_str =

The variable exec_str seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.exec_str.

      " git reset --hard origin/" + branch + " && git pull origin " + branch;
    if (commands !== null) {
      commands.forEach(function(object, index) {

The parameter index is not used and could be removed.

        log.info("running " + object);
        exec_str = exec_str + " && " + object;

The variable exec_str seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.exec_str.

      });
    }
    shell_exec(path, exec_str, true, branch);
  } else {
    if (stop == true) {

Comparing stop to true using the == operator is not safe. Consider using === instead.

      log.info("Update successful");
      send_notification("Vigilance Update successful.");
    }
    check_connection(path, branch);
  }
}

function shell_exec(path, command, stop, branch) {
  exec(path + command, function(error, stdout, stderr) {

The parameter stderr is not used and could be removed.

    if (typeof error != null) {

Comparing typeof error to null using the != operator is not safe. Consider using !== instead.

      work_on_response(stdout, path, stop, branch);
    }
  });
}