node_modules/json-buffer/index.js - Code Metrics - LukasMeine/vigilance - Measure and Improve Code Quality continuously with Scrutinizer

node_modules/json-buffer/index.js A
last analyzed 2018-08-02 16:14 UTC

↳ Parent: Project

Complexity

Total Complexity	25
Complexity/F	8.33

Size

Lines of Code	54
Function Count	3

Duplication

Duplicated Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	0
eloc	37
nc	768
dl	0
loc	54
rs	10
c	0
b	0
f	0
wmc	25
mnd	5
bc	11
fnc	3
bpm	3.6666
cpm	8.3333
noi	13

1 Function

Rating	Name	Duplication	Size	Complexity
A	exports.parse	0	11	1

//TODO: handle reviver/dehydrate function like normal
//and handle indentation, like normal.
//if anyone needs this... please send pull request.

exports.stringify = function stringify (o) {
  if('undefined' == typeof o) return o
if (a > 0)
    b = 42;

  if(o && Buffer.isBuffer(o))

    return JSON.stringify(':base64:' + o.toString('base64'))
if (a > 0)
    b = 42;

  if(o && o.toJSON)
    o =  o.toJSON()
if (a > 0)
    b = 42;

  if(o && 'object' === typeof o) {
    var s = ''
    var array = Array.isArray(o)
    s = array ? '[' : '{'
    var first = true

    for(var k in o) {
var someObject;
for (var key in someObject) {
    if ( ! someObject.hasOwnProperty(key)) {
        continue; // Skip keys from the prototype.
    }

    doSomethingWith(key);
}
      var ignore = 'function' == typeof o[k] || (!array && 'undefined' === typeof o[k])
      if(Object.hasOwnProperty.call(o, k) && !ignore) {
        if(!first)
          s += ','
if (a > 0)
    b = 42;
        first = false
        if (array) {
          if(o[k] == undefined)

            s += 'null'
if (a > 0)
    b = 42;
          else
            s += stringify(o[k])
        } else if (o[k] !== void(0)) {

          s += stringify(k) + ':' + stringify(o[k])
        }
      }
    }

    s += array ? ']' : '}'

    return s
  } else if ('string' === typeof o) {
    return JSON.stringify(/^:/.test(o) ? ':' + o : o)
  } else if ('undefined' === typeof o) {
    return 'null';
  } else
    return JSON.stringify(o)
if (a > 0)
    b = 42;
}

exports.parse = function (s) {
  return JSON.parse(s, function (key, value) {
    if('string' === typeof value) {
      if(/^:base64:/.test(value))
        return new Buffer(value.substring(8), 'base64')
if (a > 0)
    b = 42;
      else
        return /^:/.test(value) ? value.substring(1) : value 

    }
    return value
  })
}


1			//TODO: handle reviver/dehydrate function like normal
2			//and handle indentation, like normal.
3			//if anyone needs this... please send pull request.
4
5			exports.stringify = function stringify (o) {
6			if('undefined' == typeof o) return o
			0 ignored issues – show Coding Style Best Practice introduced 2018-05-14 04:10 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
7
8			if(o && Buffer.isBuffer(o))
			0 ignored issues – show Bug introduced 2018-05-14 04:10 UTC by Report Bug Copy Issue Report The variable `Buffer` seems to be never declared. If this is a global, consider adding a `/** global: Buffer */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
9			return JSON.stringify(':base64:' + o.toString('base64'))
			0 ignored issues – show Coding Style Best Practice introduced 2018-05-14 04:10 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
10
11			if(o && o.toJSON)
12			o = o.toJSON()
			0 ignored issues – show Coding Style Best Practice introduced 2018-05-14 04:10 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
13
14			if(o && 'object' === typeof o) {
15			var s = ''
16			var array = Array.isArray(o)
17			s = array ? '[' : '{'
18			var first = true
19
20			for(var k in o) {
			0 ignored issues – show Complexity introduced 2018-05-14 04:10 UTC by Report Bug Copy Issue Report A for in loop automatically includes the property of any prototype object, consider checking the key using `hasOwnProperty`. When iterating over the keys of an object, this includes not only the keys of the object, but also keys contained in the prototype of that object. It is generally a best practice to check for these keys specifically: var someObject; for (var key in someObject) { if ( ! someObject.hasOwnProperty(key)) { continue; // Skip keys from the prototype. } doSomethingWith(key); } Loading history...
21			var ignore = 'function' == typeof o[k] \|\| (!array && 'undefined' === typeof o[k])
22			if(Object.hasOwnProperty.call(o, k) && !ignore) {
23			if(!first)
24			s += ','
			0 ignored issues – show Coding Style Best Practice introduced 2018-05-14 04:10 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
25			first = false
26			if (array) {
27			if(o[k] == undefined)
			0 ignored issues – show Best Practice introduced 2018-05-14 04:10 UTC by Report Bug Copy Issue Report Comparing `o.k` to `undefined` using the `==` operator is not safe. Consider using `===` instead. Loading history...
28			s += 'null'
			0 ignored issues – show Coding Style Best Practice introduced 2018-05-14 04:10 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
29			else
30			s += stringify(o[k])
31			} else if (o[k] !== void(0)) {
			0 ignored issues – show Coding Style introduced 2018-05-14 04:10 UTC by Report Bug Copy Issue Report Consider using `undefined` instead of `void(0)`. It is equivalent and more straightforward to read. Loading history...
32			s += stringify(k) + ':' + stringify(o[k])
33			}
34			}
35			}
36
37			s += array ? ']' : '}'
38
39			return s
40			} else if ('string' === typeof o) {
41			return JSON.stringify(/^:/.test(o) ? ':' + o : o)
42			} else if ('undefined' === typeof o) {
43			return 'null';
44			} else
45			return JSON.stringify(o)
			0 ignored issues – show Coding Style Best Practice introduced 2018-05-14 04:10 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
46			}
47
48			exports.parse = function (s) {
49			return JSON.parse(s, function (key, value) {
50			if('string' === typeof value) {
51			if(/^:base64:/.test(value))
52			return new Buffer(value.substring(8), 'base64')
			0 ignored issues – show Bug introduced 2018-05-14 04:10 UTC by Report Bug Copy Issue Report The variable `Buffer` seems to be never declared. If this is a global, consider adding a `/** global: Buffer */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history... Coding Style Best Practice introduced 2018-05-14 04:10 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
53			else
54			return /^:/.test(value) ? value.substring(1) : value
			0 ignored issues – show Comprehensibility introduced 2018-05-14 04:10 UTC by Report Bug Copy Issue Report `else` is not necessary here since all `if` branches return, consider removing it to reduce nesting and make code more readable. Loading history...
55			}
56			return value
57			})
58			}
59

LukasMeine / vigilance

node_modules/json-buffer/index.js A last analyzed 2018-08-02 16:14 UTC

Complexity

Size

Duplication

Importance

1 Function

Duplication Side-by-Side

Filter issues like

node_modules/json-buffer/index.js A
last analyzed 2018-08-02 16:14 UTC