LukasMeine / devmind-beautifier

lib/devmind-beautifier.js

"use babel";

import DevmindBeautifierView from "./devmind-beautifier-view";
import { CompositeDisposable } from "atom";
var qs = require("qs");

function request(ext, text, url) {
  data = { extension: ext, content: text };

The variable data seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.data.

  var http = new XMLHttpRequest();

The variable XMLHttpRequest seems to be never declared. If this is a global, consider adding a /** global: XMLHttpRequest */ comment.

  http.open("POST", url, true);
  http.setRequestHeader("Content-type", "application/x-www-form-urlencoded");
  http.send(qs.stringify(data));
  changeState(http);
}

function changeState(http) {
  http.onreadystatechange = function() {
    if (http.readyState == 4 && http.status == 200) {
      success(http);
    }
    if (http.status !== 200) {
      fail();
    }
  };
}

function success(http) {
  if (typeof http.responseText.status === "undefined") {
    editor.setText(http.responseText);

The variable editor seems to be never declared. If this is a global, consider adding a /** global: editor */ comment.

    atom.notifications.addSuccess("Now your code looks fancy");

The variable atom seems to be never declared. If this is a global, consider adding a /** global: atom */ comment.

    panel.modalPanel.hide();

The variable panel seems to be never declared. If this is a global, consider adding a /** global: panel */ comment.

  } else {
    atom.notifications.addInfo("File extension not supported. Yet.");
  }
}

function fail() {
  panel.modalPanel.hide();

The variable panel seems to be never declared. If this is a global, consider adding a /** global: panel */ comment.

  atom.notifications.addError(

The variable atom seems to be never declared. If this is a global, consider adding a /** global: atom */ comment.

    "Something went wrong, please check your internet connection"
  );
}

export default {
  devmindBeautifierView: null,
  modalPanel: null,
  subscriptions: null,

  activate(state) {
    this.devmindBeautifierView = new DevmindBeautifierView(
      state.devmindBeautifierViewState
    );
    this.modalPanel = atom.workspace.addModalPanel({

The variable atom seems to be never declared. If this is a global, consider adding a /** global: atom */ comment.

      item: this.devmindBeautifierView.getElement(),
      visible: false
    });

    // Events subscribed to in atom's system can be easily cleaned up with a CompositeDisposable
    this.subscriptions = new CompositeDisposable();

    // Register command that toggles this view
    this.subscriptions.add(
      atom.commands.add("atom-workspace", {
        "devmind-beautifier:toggle": () => this.toggle()
      })
    );
  },

  deactivate() {
    this.modalPanel.destroy();
    this.subscriptions.dispose();
    this.devmindBeautifierView.destroy();
  },

  serialize() {
    return {
      devmindBeautifierViewState: this.devmindBeautifierView.serialize()
    };
  },

  toggle() {
    panel = this;

The variable panel seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.panel.

    editor = atom.workspace.getActiveTextEditor();

The variable editor seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.editor.

The variable atom seems to be never declared. If this is a global, consider adding a /** global: atom */ comment.

    text = editor.getText().trim();

The variable text seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.text.

    fileName = editor.getTitle();

The variable fileName seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.fileName.

    ext = fileName

The variable ext seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.ext.

      .split(".")
      .pop()
      .trim();
    request(ext, text, "https://beautifier.devmind.io/format");
  }
};