TachesController - Code Metrics - Inspection of ":squirrel: Bdd Update + fixing redirect for tasks..." - Luctum/Increase - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — Projets ( 4109c3...54d1e1 )

by Hugo

created 2015-12-14 11:11 UTC

TachesController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	58
Duplicated Lines	20.69 %

Coupling/Cohesion

Components	1
Dependencies	3

Metric	Value
wmc	6
lcom	1
cbo	3
dl	12
loc	58
rs	10

5 Methods

Rating	Name	Duplication	Size	Complexity
A	initialize()	0	6	1
A	updateAction()	0	6	1
A	soloUpdateAction()	12	12	1
A	deleteAction()	0	9	1
A	useCaseUpdate()	0	13	2

How to fix Duplicated Code

<?php

class TachesController extends \ControllerBase
namespace YourVendor;

class YourClass { }
{

    protected $model;
    protected $title;
    protected $controller;

    public function initialize()
    {
        $this->model = "Tache";
        $this->title = "Taches";
        $this->controller = "Taches";
    }

    public function updateAction($id = null)
    {
        parent::updateAction();
        $this->response->redirect("Projets/read/$id/2");

    }

    public function soloUpdateAction()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        $name = $this->request->getPost('name', 'string');
        //Cr�er la fonction variable 'set' en fonction du name en POST
        $func = 'set' . ucfirst($name);
        $projet = call_user_func($this->model . '::findFirst', $_POST['pk']);
        $projet->$func($_POST['value']);
        $projet->save();

        $this->useCaseUpdate($projet);
    }

    public function deleteAction($id = null)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $object = call_user_func($this->model . '::findFirst', "$id");
        $object->delete();

        $this->useCaseUpdate($object);
        $this->response->redirect("$this->controller/index");
        $this->response->redirect($_SERVER['HTTP_REFERER'] . "/2");
    }

    public function useCaseUpdate($obj)
    {
        //Update l'avancement de la usecase lors de changements sur une usecase
        $avancementTotal = 0;
        $usecase = Usecase::findFirst("code='" . $obj->getCodeUseCase() . "'");
        $taches = Tache::find("codeUseCase LIKE '" . $obj->getCodeUseCase() . "'");
        foreach ($taches as $tache) {
            $avancementTotal += $tache->getAvancement();
        }
        $avancementTotal = $avancementTotal / count($taches);
        $usecase->setAvancement($avancementTotal);
        $usecase->save();
    }
}



1		<?php
2
3		class TachesController extends \ControllerBase
		0 ignored issues – show Coding Style Compatibility introduced 2015-12-10 11:19 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4		{
5
6		protected $model;
7		protected $title;
8		protected $controller;
9
10		public function initialize()
11		{
12		$this->model = "Tache";
13		$this->title = "Taches";
14		$this->controller = "Taches";
15		}
16
17		public function updateAction($id = null)
18		{
19		parent::updateAction();
20		$this->response->redirect("Projets/read/$id/2");
21
22		}
23
24	View Code Duplication	public function soloUpdateAction()
		0 ignored issues – show Coding Style introduced 2015-12-14 09:42 UTC by Report Bug Copy Issue Report `soloUpdateAction` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Duplication introduced 2015-12-14 11:17 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25		{
26
27		$name = $this->request->getPost('name', 'string');
28		//Cr�er la fonction variable 'set' en fonction du name en POST
29		$func = 'set' . ucfirst($name);
30		$projet = call_user_func($this->model . '::findFirst', $_POST['pk']);
31		$projet->$func($_POST['value']);
32		$projet->save();
33
34		$this->useCaseUpdate($projet);
35		}
36
37		public function deleteAction($id = null)
		0 ignored issues – show Coding Style introduced 2015-12-14 11:17 UTC by Report Bug Copy Issue Report `deleteAction` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
38		{
39		$object = call_user_func($this->model . '::findFirst', "$id");
40		$object->delete();
41
42		$this->useCaseUpdate($object);
43		$this->response->redirect("$this->controller/index");
44		$this->response->redirect($_SERVER['HTTP_REFERER'] . "/2");
45		}
46
47		public function useCaseUpdate($obj)
48		{
49		//Update l'avancement de la usecase lors de changements sur une usecase
50		$avancementTotal = 0;
51		$usecase = Usecase::findFirst("code='" . $obj->getCodeUseCase() . "'");
52		$taches = Tache::find("codeUseCase LIKE '" . $obj->getCodeUseCase() . "'");
53		foreach ($taches as $tache) {
54		$avancementTotal += $tache->getAvancement();
55		}
56		$avancementTotal = $avancementTotal / count($taches);
57		$usecase->setAvancement($avancementTotal);
58		$usecase->save();
59		}
60		}
61
62

Luctum / Increase

Push — Projets ( 4109c3...54d1e1 )

TachesController A

Complexity

Size/Duplication

Coupling/Cohesion

5 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like