ControllerBase - Code Metrics - Inspection of "Adding more editable fields, trying to do it with..." - Luctum/Increase - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — Projets ( 098438...291da2 )

by Hugo

created 2015-12-07 11:12 UTC

ControllerBase A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	189
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	2

Metric	Value
wmc	26
lcom	2
cbo	2
dl	0
loc	189
rs	10

18 Methods

Rating	Name	Size	Complexity
A	afterExecuteRoute()	7	1
A	indexAction()	15	3
A	frmAction()	4	1
A	getInstance()	10	2
A	readAction()	8	2
A	setValuesToObject()	4	1
B	updateAction()	23	5
A	soloUpdateAction()	9	1
A	deleteAction()	5	1
A	asAdminAction()	6	1
A	asUserAction()	6	1
A	logoutAction()	5	1
A	_showDisplayedMessage()	4	1
A	_showMessage()	5	1
A	messageSuccess()	4	1
A	messageWarning()	4	1
A	messageDanger()	4	1
A	messageInfo()	4	1

<?php

use Phalcon\Mvc\Controller;
use Phalcon\Mvc\Url;

class ControllerBase extends Controller
namespace YourVendor;

class YourClass { }
{

    protected $model;
    protected $title;
    protected $controller;
    protected $messageTimerInterval = 3000;

    public function afterExecuteRoute($dispatcher)
    {
        $baseUrl = $this->baseUrl;
        $this->view->setVar("baseUrl", $baseUrl);
        $this->view->setVar("controller", $this->controller);
        $this->view->setVar("title", $this->title);
    }

    public function indexAction($message = NULL)
    {
        $msg = "";
        if (isset($message)) {
            if (is_string($message)) {
                $message = new DisplayedMessage($message);
            }
            $message->setTimerInterval($this->messageTimerInterval);
            $msg = $this->_showDisplayedMessage($message);
        }
        $this->view->setVar("msg", $msg);
        $objects = call_user_func($this->model . "::find");
        $this->view->setVar("objects", $objects);
        $this->view->pick("main/index");
    }

    public function frmAction($id = NULL)
    {
        echo "Pas encore implémenté...";
    }

    public function getInstance($id = NULL)
    {
        if (isset($id)) {
            $object = call_user_func($this->model . "::findfirst", $id);
        } else {
            $className = $this->model;
            $object = new $className();
        }
        return $object;
    }

    public function readAction($id = NULL)
    {
        if ($id != null) {
            $object = call_user_func($this->model . '::find', "id = $id");
            $this->view->setVar("object", $object);
            $this->view->pick("main/read");
        }
    }

    protected function setValuesToObject(&$object)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $object->assign($_POST);
    }

    /////////////////////////////////////////
    public function updateAction()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if ($this->request->isPost()) {
            $object = $this->getInstance(@$_POST["id"]);
            $this->setValuesToObject($object);
            if (@$_POST["id"]) {
                try {
                    $object->save();
                    $msg = new DisplayedMessage("Instance de " . $this->model . " modifiée");
                } catch (\Exception $e) {
                    $msg = new DisplayedMessage("Impossible d'ajouter l'instance de " . $this->model, "danger : $e");
                }
            } else {
                try {
                    $object->save();
                    $msg = new DisplayedMessage("Instance de " . $this->model . " ajoutée");
                } catch (\Exception $e) {
                    $msg = new DisplayedMessage("Impossible d'ajouter l'instance de " . $this->model, "danger : $e");
                }
            }
            $this->dispatcher->forward(array("controller" => $this->dispatcher->getControllerName(), "action" => "index", "params" => array($msg)));
        }
    }

    //PErmet l'édition d'un seul champ à la fois
    public function soloUpdateAction()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        //Créer la fonction variable 'set' en fonction du name en POST
        $func = 'set' . ucfirst($_POST['name']);
        $projet = call_user_func($this->model . '::findFirst', $_POST['pk']);
        $projet->$func($_POST['value']);
        $projet->save();

    }


    public function deleteAction($id = null)
    {
        $object = call_user_func($this->model . '::find', "id = $id");
        $object->delete();
    }

    public function asAdminAction()
    {
        $user = User::findFirst("id=3");
        $this->session->set("user", $user);
        $this->response->redirect("Index/index");
    }

    public function asUserAction()
    {
        $user = User::findFirst("id=1");
        $this->session->set("user", $user);
        $this->response->redirect("Index/index");
    }

    public function logoutAction()
    {
        $this->session->destroy();
        $this->response->redirect("Index/index");
    }


    /**
     * Affiche un message Alert bootstrap
     * @param DisplayedMessage $message
     */
    public function _showDisplayedMessage($message)
    {
        return $message->compile($this->jquery);
    }

    /**
     * Affiche un message Alert bootstrap
     * @param string $message texte du message
     * @param string $type type du message (info, success, warning ou danger)
     * @param number $timerInterval durée en millisecondes d'affichage du message (0 pour que le message reste affiché)
     * @param string $dismissable si vrai, l'alert dispose d'une croix de fermeture
     */
    public function _showMessage($message, $type = "success", $timerInterval = 0, $dismissable = true, $visible = true)
    {
        $message = new DisplayedMessage($message, $type, $timerInterval, $dismissable, $visible);

        $this->_showDisplayedMessage($message);
    }


    public function messageSuccess($message, $timerInterval = 0, $dismissable = true)
    {
        $this->_showMessage($message, "success", $timerInterval, $dismissable);
    }

    /**
     * Affiche un message Alert bootstrap de type warning
     * @param string $message texte du message
     * @param number $timerInterval durée en millisecondes d'affichage du message (0 pour que le message reste affiché)
     * @param string $dismissable si vrai, l'alert dispose d'une croix de fermeture
     */
    public function messageWarning($message, $timerInterval = 0, $dismissable = true)
    {
        $this->_showMessage($message, "warning", $timerInterval, $dismissable);
    }

    /**
     * Affiche un message Alert bootstrap de type danger
     * @param string $message texte du message
     * @param number $timerInterval durée en millisecondes d'affichage du message (0 pour que le message reste affiché)
     * @param string $dismissable si vrai, l'alert dispose d'une croix de fermeture
     */
    public function messageDanger($message, $timerInterval = 0, $dismissable = true)
    {
        $this->_showMessage($message, "danger", $timerInterval, $dismissable);
    }

    /**
     * Affiche un message Alert bootstrap de type info
     * @param string $message texte du message
     * @param number $timerInterval durée en millisecondes d'affichage du message (0 pour que le message reste affiché)
     * @param string $dismissable si vrai, l'alert dispose d'une croix de fermeture
     */
    public function messageInfo($message, $timerInterval = 0, $dismissable = true)
    {
        $this->_showMessage($message, "info", $timerInterval, $dismissable);
    }


}


1			<?php
2
3			use Phalcon\Mvc\Controller;
4			use Phalcon\Mvc\Url;
5
6			class ControllerBase extends Controller
			0 ignored issues – show Coding Style Compatibility introduced 2015-12-01 16:27 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7			{
8
9			protected $model;
10			protected $title;
11			protected $controller;
12			protected $messageTimerInterval = 3000;
13
14			public function afterExecuteRoute($dispatcher)
15			{
16			$baseUrl = $this->baseUrl;
17			$this->view->setVar("baseUrl", $baseUrl);
18			$this->view->setVar("controller", $this->controller);
19			$this->view->setVar("title", $this->title);
20			}
21
22			public function indexAction($message = NULL)
23			{
24			$msg = "";
25			if (isset($message)) {
26			if (is_string($message)) {
27			$message = new DisplayedMessage($message);
28			}
29			$message->setTimerInterval($this->messageTimerInterval);
30			$msg = $this->_showDisplayedMessage($message);
31			}
32			$this->view->setVar("msg", $msg);
33			$objects = call_user_func($this->model . "::find");
34			$this->view->setVar("objects", $objects);
35			$this->view->pick("main/index");
36			}
37
38			public function frmAction($id = NULL)
39			{
40			echo "Pas encore implémenté...";
41			}
42
43			public function getInstance($id = NULL)
44			{
45			if (isset($id)) {
46			$object = call_user_func($this->model . "::findfirst", $id);
47			} else {
48			$className = $this->model;
49			$object = new $className();
50			}
51			return $object;
52			}
53
54			public function readAction($id = NULL)
55			{
56			if ($id != null) {
57			$object = call_user_func($this->model . '::find', "id = $id");
58			$this->view->setVar("object", $object);
59			$this->view->pick("main/read");
60			}
61			}
62
63			protected function setValuesToObject(&$object)
			0 ignored issues – show Coding Style introduced 2015-12-01 16:27 UTC by Report Bug Copy Issue Report `setValuesToObject` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
64			{
65			$object->assign($_POST);
66			}
67
68			/////////////////////////////////////////
69			public function updateAction()
			0 ignored issues – show Coding Style introduced 2015-12-01 16:27 UTC by Report Bug Copy Issue Report `updateAction` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
70			{
71			if ($this->request->isPost()) {
72			$object = $this->getInstance(@$_POST["id"]);
73			$this->setValuesToObject($object);
74			if (@$_POST["id"]) {
75			try {
76			$object->save();
77			$msg = new DisplayedMessage("Instance de " . $this->model . " modifiée");
78			} catch (\Exception $e) {
79			$msg = new DisplayedMessage("Impossible d'ajouter l'instance de " . $this->model, "danger : $e");
80			}
81			} else {
82			try {
83			$object->save();
84			$msg = new DisplayedMessage("Instance de " . $this->model . " ajoutée");
85			} catch (\Exception $e) {
86			$msg = new DisplayedMessage("Impossible d'ajouter l'instance de " . $this->model, "danger : $e");
87			}
88			}
89			$this->dispatcher->forward(array("controller" => $this->dispatcher->getControllerName(), "action" => "index", "params" => array($msg)));
90			}
91			}
92
93			//PErmet l'édition d'un seul champ à la fois
94			public function soloUpdateAction()
			0 ignored issues – show Coding Style introduced 2015-12-07 11:16 UTC by Report Bug Copy Issue Report `soloUpdateAction` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
95			{
96			//Créer la fonction variable 'set' en fonction du name en POST
97			$func = 'set' . ucfirst($_POST['name']);
98			$projet = call_user_func($this->model . '::findFirst', $_POST['pk']);
99			$projet->$func($_POST['value']);
100			$projet->save();
101
102			}
103
104
105			public function deleteAction($id = null)
106			{
107			$object = call_user_func($this->model . '::find', "id = $id");
108			$object->delete();
109			}
110
111			public function asAdminAction()
112			{
113			$user = User::findFirst("id=3");
114			$this->session->set("user", $user);
115			$this->response->redirect("Index/index");
116			}
117
118			public function asUserAction()
119			{
120			$user = User::findFirst("id=1");
121			$this->session->set("user", $user);
122			$this->response->redirect("Index/index");
123			}
124
125			public function logoutAction()
126			{
127			$this->session->destroy();
128			$this->response->redirect("Index/index");
129			}
130
131
132			/**
133			* Affiche un message Alert bootstrap
134			* @param DisplayedMessage $message
135			*/
136			public function _showDisplayedMessage($message)
137			{
138			return $message->compile($this->jquery);
139			}
140
141			/**
142			* Affiche un message Alert bootstrap
143			* @param string $message texte du message
144			* @param string $type type du message (info, success, warning ou danger)
145			* @param number $timerInterval durée en millisecondes d'affichage du message (0 pour que le message reste affiché)
146			* @param string $dismissable si vrai, l'alert dispose d'une croix de fermeture
147			*/
148			public function _showMessage($message, $type = "success", $timerInterval = 0, $dismissable = true, $visible = true)
149			{
150			$message = new DisplayedMessage($message, $type, $timerInterval, $dismissable, $visible);
			0 ignored issues – show Bug introduced 2015-12-07 11:16 UTC by Report Bug Copy Issue Report It seems like `$dismissable` defined by parameter `$dismissable` on line 148 can also be of type `string`; however, `DisplayedMessage::DisplayedMessage()` does only seem to accept `boolean`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
151			$this->_showDisplayedMessage($message);
152			}
153
154
155			public function messageSuccess($message, $timerInterval = 0, $dismissable = true)
156			{
157			$this->_showMessage($message, "success", $timerInterval, $dismissable);
158			}
159
160			/**
161			* Affiche un message Alert bootstrap de type warning
162			* @param string $message texte du message
163			* @param number $timerInterval durée en millisecondes d'affichage du message (0 pour que le message reste affiché)
164			* @param string $dismissable si vrai, l'alert dispose d'une croix de fermeture
165			*/
166			public function messageWarning($message, $timerInterval = 0, $dismissable = true)
167			{
168			$this->_showMessage($message, "warning", $timerInterval, $dismissable);
169			}
170
171			/**
172			* Affiche un message Alert bootstrap de type danger
173			* @param string $message texte du message
174			* @param number $timerInterval durée en millisecondes d'affichage du message (0 pour que le message reste affiché)
175			* @param string $dismissable si vrai, l'alert dispose d'une croix de fermeture
176			*/
177			public function messageDanger($message, $timerInterval = 0, $dismissable = true)
178			{
179			$this->_showMessage($message, "danger", $timerInterval, $dismissable);
180			}
181
182			/**
183			* Affiche un message Alert bootstrap de type info
184			* @param string $message texte du message
185			* @param number $timerInterval durée en millisecondes d'affichage du message (0 pour que le message reste affiché)
186			* @param string $dismissable si vrai, l'alert dispose d'une croix de fermeture
187			*/
188			public function messageInfo($message, $timerInterval = 0, $dismissable = true)
189			{
190			$this->_showMessage($message, "info", $timerInterval, $dismissable);
191			}
192
193
194			}
195

Luctum / Increase

Push — Projets ( 098438...291da2 )

ControllerBase A

Complexity

Size/Duplication

Coupling/Cohesion

18 Methods

Duplication Side-by-Side

Filter issues like