Louzet / ComposerLockFileParser

src/SearcherTrait.php

<?php

/**
 * Author: mickael Louzet @micklouzet
 * File: SearcherTrait.php
 * Created: 08/12/2019
 */

namespace ComposerLockParser;

use ComposerLockParser\Package\Package;

trait SearcherTrait {

    /**
     * @param string $name
     *
     * @return Package
     */
    public function getByName(string $name): Package
    {
        if (!$this->nameExists($name)) {
            throw new \UnexpectedValueException(sprintf('Sorry, Package %s not found !', $name));
        }
        return $this->getIndexedByName()[$name];

It seems like getIndexedByName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param string $namespace
     *
     * @return Package
     */
    public function getByNamespace(string $namespace): Package
    {
        if (!$this->namespaceExists($namespace)) {
            throw new \UnexpectedValueException(sprintf('Sorry, namespace %s not found !', $namespace));
        }
        return $this->getIndexedByNamespace()[$namespace];

It seems like getIndexedByNamespace() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param string $name
     *
     * @return bool
     */
    public function nameExists(string $name): bool
    {
        return array_key_exists($name, $this->getIndexedByName());
    }

    /**
     * @param string $namespace
     *
     * @return bool
     */
    public function namespaceExists($namespace): bool
    {
        return array_key_exists($namespace, $this->getIndexedByNamespace());
    }
}