ComposerLockParser\SearcherTrait

Complexity

Total Complexity

6

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getByNamespace()	0	6	2
A	nameExists()	0	3	1
A	namespaceExists()	0	3	1
A	getByName()	0	6	2

<?php

namespace ComposerLockParser;

use ComposerLockParser\Package\Package;

trait SearcherTrait {

    /**
     * @param string $name
     *
     * @return Package
     */
    public function getByName(string $name): Package
    {
        if (!$this->nameExists($name)) {
            throw new \UnexpectedValueException(sprintf('Sorry, Package %s not found !', $name));
        }
        return $this->getIndexedByName()[$name];

It seems like getIndexedByName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param string $namespace
     *
     * @return Package
     */
    public function getByNamespace(string $namespace): Package
    {
        if (!$this->namespaceExists($namespace)) {
            throw new \UnexpectedValueException(sprintf('Sorry, namespace %s not found !', $namespace));
        }
        return $this->getIndexedByNamespace()[$namespace];

It seems like getIndexedByNamespace() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param string $name
     *
     * @return bool
     */
    public function nameExists(string $name): bool
    {
        return array_key_exists($name, $this->getIndexedByName());
    }

    /**
     * @param string $namespace
     *
     * @return bool
     */
    public function namespaceExists($namespace): bool
    {
        return array_key_exists($namespace, $this->getIndexedByNamespace());
    }
}