ComposerLockParser\Package\PackageCollection

Complexity

Total Complexity

14

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Importance

Changes	2
Bugs	2	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getIndexedByNamespace()	0	12	4
A	getPackages()	0	6	2
A	offsetSet()	0	7	2
A	getIndexedByName()	0	13	4
A	getNameSpaces()	0	6	2

<?php

/**
 * Author: mickael Louzet @micklouzet
 * File: PackageCollection.php
 * Created: 07/12/2019
 */

declare(strict_types=1);

namespace ComposerLockParser\Package;

use ComposerLockParser\SearcherTrait;
use ArrayObject;

/**
 * Class PackageCollection
 *
 * @package ComposerLockParser\Package
 */
class PackageCollection extends ArrayObject
{
    use SearcherTrait;

    /** @var array|null */
    public $indexedBy;

    /**
     * @return array|null
     */
    public function getPackages(): ?array
    {
        if (null === $this->indexedBy) {
            return [];
        }
        return $this->getIndexedByName();
    }

    /**
     * @return array|null
     */
    public function getNameSpaces(): ?array
    {
        if (null === $this->indexedBy) {
            return [];
        }
        return $this->getIndexedByNamespace();
    }

    /**
     * @param mixed $index
     * @param Package $package
     *
     * @return void
     */
    public function offsetSet($index, $package): void
    {
        if ($package instanceof Package) {

$package is always a sub-type of ComposerLockParser\Package\Package.

            $this->indexedBy['name'][$package->getName()] = $package;
            $this->indexedBy['namespace'][$package->getNamespace()] = $package;
        }
        parent::offsetSet($index, $package);
    }
    
    /**
     * @return array|null
     */
    private function getIndexedByName(): ?array
    {
        if (!empty($this->indexedBy['name'])) {
            return $this->indexedBy['name'];
        }
        /** @var Package $package */
        foreach ($this->getArrayCopy() as $package) {
            if (!$package instanceof Package) {
                continue;
            }
            $this->indexedBy['name'][$package->getName()] = $package;
        }
        return $this->indexedBy['name'];
    }

    /**
     * @return array|null
     */
    private function getIndexedByNamespace(): ?array
    {
        if (!empty($this->indexedBy['namespace'])) {
            return $this->indexedBy['namespace'];
        }
        /** @var Package $package */
        foreach ($this->getArrayCopy() as $package) {
            if (!($package instanceof Package)) {
                continue;
            }
        }
        return $this->indexedBy['namespace'][$package->getNamespace()];

The variable $package seems to be defined by a foreach iteration on line 92. Are you sure the iterator is never empty, otherwise this variable is not defined?

    }
}