Issues in View.php (master) - Issues in master - Logi-CE/fmup - Measure and Improve Code Quality continuously with Scrutinizer

Issues (183)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/View.php (3 issues)

Labels

Duplication 3

Severity

Informational 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace FMUP;

use FMUP\Exception\UnexpectedValue;

/**
 * Class View
 * /!\ Beware this version is not compliant with FMU View since layout are hardcoded.
 * With FMUP\View you'll be able to inject Views to views
 *
 * @package FMUP
 */
class View
{
    private $viewPath;
    private $params = array();

    /**
     * @param array $params
     */
    public function __construct(array $params = array())
    {
        $this->addParams((array)$params);
    }

    /**
     * Define multiple value for key (associative array)
     * @param array $params
     * @return $this
     */
    public function addParams(array $params = array())
    {
        $this->params = array_merge($this->params, $params);
        return $this;
    }

    /**
     * Define a value for a specific key
     * @param string $name
     * @param mixed $value
     * @throws UnexpectedValue
     * @return $this
     */
    public function setParam($name, $value)

    {
        if (!is_string($name)) {
            throw new UnexpectedValue(UnexpectedValue::MESSAGE_TYPE_NOT_STRING, UnexpectedValue::CODE_TYPE_NOT_STRING);
        }
        if (empty($name)) {
            throw new UnexpectedValue(UnexpectedValue::MESSAGE_VALUE_EMPTY, UnexpectedValue::CODE_VALUE_EMPTY);
        }
        $this->params[$name] = $value;
        return $this;
    }

    /**
     * Get defined value for a specific key
     * @param string $name
     * @throws UnexpectedValue
     * @return mixed
     */
    public function getParam($name)

    {
        if (!is_string($name)) {
            throw new UnexpectedValue(UnexpectedValue::MESSAGE_TYPE_NOT_STRING, UnexpectedValue::CODE_TYPE_NOT_STRING);
        }
        if (empty($name)) {
            throw new UnexpectedValue(UnexpectedValue::MESSAGE_VALUE_EMPTY, UnexpectedValue::CODE_VALUE_EMPTY);
        }
        return isset($this->params[$name]) ? $this->params[$name] : null;
    }

    /**
     * Return defined params
     * @return array
     */
    public function getParams()
    {
        return $this->params;
    }

    /**
     * Return string of interpreted template
     * @return string
     * @throws UnexpectedValue
     */
    public function render()
    {
        if (is_null($this->getViewPath())) {
            throw new UnexpectedValue(
                'View must be defined : ' . $this->getViewPath(),
                UnexpectedValue::CODE_VALUE_NULL
            );
        }
        if (!file_exists($this->getViewPath())) {
            throw new UnexpectedValue(
                'File does not exist : ' . $this->getViewPath(),
                UnexpectedValue::CODE_VALUE_INVALID_FILE_PATH
            );
        }
        ob_start();
        $vars = $this->getParams();
        extract($vars); //for compliance only - @todo remove this line
        require($this->getViewPath());
        return ob_get_clean();
    }

    /**
     * Define view to use
     * @param string $viewPath Full path to view
     * @throws UnexpectedValue
     * @return $this
     */
    public function setViewPath($viewPath)

    {
        if (!is_string($viewPath)) {
            throw new UnexpectedValue(UnexpectedValue::MESSAGE_TYPE_NOT_STRING, UnexpectedValue::CODE_TYPE_NOT_STRING);
        }
        if (empty($viewPath)) {
            throw new UnexpectedValue(UnexpectedValue::MESSAGE_VALUE_EMPTY, UnexpectedValue::CODE_VALUE_EMPTY);
        }

        $this->viewPath = $viewPath;
        return $this;
    }

    /**
     * Return defined view path
     * @return mixed
     */
    public function getViewPath()
    {
        return $this->viewPath;
    }

    /**
     * Implements object use
     * @param string $param
     * @return mixed
     */
    public function __get($param)
    {
        return $this->getParam($param);
    }

    /**
     * Implements object use
     * @param string $param
     * @param mixed $value
     * @throws UnexpectedValue
     * @return View
     */
    public function __set($param, $value)
    {
        return $this->setParam($param, $value);
    }
}


1			<?php
2			namespace FMUP;
3
4			use FMUP\Exception\UnexpectedValue;
5
6			/**
7			* Class View
8			* /!\ Beware this version is not compliant with FMU View since layout are hardcoded.
9			* With FMUP\View you'll be able to inject Views to views
10			*
11			* @package FMUP
12			*/
13			class View
14			{
15			private $viewPath;
16			private $params = array();
17
18			/**
19			* @param array $params
20			*/
21	4		public function __construct(array $params = array())
22			{
23	4		$this->addParams((array)$params);
24	4		}
25
26			/**
27			* Define multiple value for key (associative array)
28			* @param array $params
29			* @return $this
30			*/
31	6		public function addParams(array $params = array())
32			{
33	6		$this->params = array_merge($this->params, $params);
34	6		return $this;
35			}
36
37			/**
38			* Define a value for a specific key
39			* @param string $name
40			* @param mixed $value
41			* @throws UnexpectedValue
42			* @return $this
43			*/
44	2	View Code Duplication	public function setParam($name, $value)
			0 ignored issues – show Duplication introduced 2017-08-25 13:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45			{
46	2		if (!is_string($name)) {
47	1		throw new UnexpectedValue(UnexpectedValue::MESSAGE_TYPE_NOT_STRING, UnexpectedValue::CODE_TYPE_NOT_STRING);
48			}
49	2		if (empty($name)) {
50	1		throw new UnexpectedValue(UnexpectedValue::MESSAGE_VALUE_EMPTY, UnexpectedValue::CODE_VALUE_EMPTY);
51			}
52	2		$this->params[$name] = $value;
53	2		return $this;
54			}
55
56			/**
57			* Get defined value for a specific key
58			* @param string $name
59			* @throws UnexpectedValue
60			* @return mixed
61			*/
62	4	View Code Duplication	public function getParam($name)
			0 ignored issues – show Duplication introduced 2017-08-25 13:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
63			{
64	4		if (!is_string($name)) {
65	1		throw new UnexpectedValue(UnexpectedValue::MESSAGE_TYPE_NOT_STRING, UnexpectedValue::CODE_TYPE_NOT_STRING);
66			}
67	4		if (empty($name)) {
68	1		throw new UnexpectedValue(UnexpectedValue::MESSAGE_VALUE_EMPTY, UnexpectedValue::CODE_VALUE_EMPTY);
69			}
70	4		return isset($this->params[$name]) ? $this->params[$name] : null;
71			}
72
73			/**
74			* Return defined params
75			* @return array
76			*/
77	4		public function getParams()
78			{
79	4		return $this->params;
80			}
81
82			/**
83			* Return string of interpreted template
84			* @return string
85			* @throws UnexpectedValue
86			*/
87	2		public function render()
88			{
89	2		if (is_null($this->getViewPath())) {
90	1		throw new UnexpectedValue(
91	1		'View must be defined : ' . $this->getViewPath(),
92	1		UnexpectedValue::CODE_VALUE_NULL
93			);
94			}
95	2		if (!file_exists($this->getViewPath())) {
96	1		throw new UnexpectedValue(
97	1		'File does not exist : ' . $this->getViewPath(),
98	1		UnexpectedValue::CODE_VALUE_INVALID_FILE_PATH
99			);
100			}
101	2		ob_start();
102	2		$vars = $this->getParams();
103	2		extract($vars); //for compliance only - @todo remove this line
104	2		require($this->getViewPath());
105	2		return ob_get_clean();
106			}
107
108			/**
109			* Define view to use
110			* @param string $viewPath Full path to view
111			* @throws UnexpectedValue
112			* @return $this
113			*/
114	3	View Code Duplication	public function setViewPath($viewPath)
			0 ignored issues – show Duplication introduced 2017-08-25 13:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
115			{
116	3		if (!is_string($viewPath)) {
117	1		throw new UnexpectedValue(UnexpectedValue::MESSAGE_TYPE_NOT_STRING, UnexpectedValue::CODE_TYPE_NOT_STRING);
118			}
119	3		if (empty($viewPath)) {
120	1		throw new UnexpectedValue(UnexpectedValue::MESSAGE_VALUE_EMPTY, UnexpectedValue::CODE_VALUE_EMPTY);
121			}
122
123	3		$this->viewPath = $viewPath;
124	3		return $this;
125			}
126
127			/**
128			* Return defined view path
129			* @return mixed
130			*/
131	3		public function getViewPath()
132			{
133	3		return $this->viewPath;
134			}
135
136			/**
137			* Implements object use
138			* @param string $param
139			* @return mixed
140			*/
141	1		public function __get($param)
142			{
143	1		return $this->getParam($param);
144			}
145
146			/**
147			* Implements object use
148			* @param string $param
149			* @param mixed $value
150			* @throws UnexpectedValue
151			* @return View
152			*/
153	1		public function __set($param, $value)
154			{
155	1		return $this->setParam($param, $value);
156			}
157			}
158

Logi-CE / fmup

Issues (183)

Security Analysis not enabled

src/View.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like