Issues in Socket.php (master) - Issues in master - Logi-CE/fmup - Measure and Improve Code Quality continuously with Scrutinizer

Issues (183)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Socket.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * @author jyamin
 */

namespace FMUP;

class Socket
{
    /** @var resource $socket */
    protected $socket;

    /** @var int $errorNumber */
    protected $errorNumber;

    /** @var string $errorString */
    protected $errorString;

    /**
     * @param $host
     * @param $port
     * @return $this
     */
    public function connect($host, $port, $timeout = null)
    {
        if (!$timeout) {
            $timeout = ini_get('default_socket_timeout');
        }
        $this->socket = $this->phpFSockOpen($host, $port, $this->errorNumber, $this->errorString, $timeout);
        return $this;
    }

    /**
     * @return bool
     */
    public function isConnected()
    {
        return (bool)$this->socket;
    }

    /**
     * @param $str
     * @param int|null $length
     * @return int
     */
    public function write($str, $length = null)
    {
        if ($length) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            return $this->phpFWrite($this->socket, $str, $length);
        }
        return $this->phpFWrite($this->socket, $str);
    }

    /**
     * @param $length
     * @return string
     */
    public function read($length)
    {
        return $this->phpFRead($this->socket, $length);
    }

    /**
     * @return int
     */
    public function getErrorNumber()
    {
        return $this->errorNumber;
    }

    /**
     * @return string
     */
    public function getErrorString()
    {
        return $this->errorString;
    }

    /**
     * @param string $host
     * @param int $port
     * @param int $errno
     * @param string $errstr
     * @param float $timeout
     * @return resource
     * @codeCoverageIgnore
     */
    protected function phpFSockOpen($host, $port, $errno, $errstr, $timeout)
    {
        return fsockopen($host, $port, $errno, $errstr, $timeout);
    }

    /**
     * @return int
     * @codeCoverageIgnore
     */
    protected function phpFWrite()
    {
        return call_user_func_array('fwrite', func_get_args());
    }

    /**
     * @param resource $handle
     * @param int $length
     * @return string
     * @codeCoverageIgnore
     */
    protected function phpFRead($handle, $length)
    {
        return fread($handle, $length);
    }

    /**
     * @param resource $handle
     * @return bool
     * @codeCoverageIgnore
     */
    protected function phpFClose($handle)
    {
        return fclose($handle);
    }
}


1		<?php
2		/**
3		* @author jyamin
4		*/
5
6		namespace FMUP;
7
8		class Socket
9		{
10		/** @var resource $socket */
11		protected $socket;
12
13		/** @var int $errorNumber */
14		protected $errorNumber;
15
16		/** @var string $errorString */
17		protected $errorString;
18
19		/**
20		* @param $host
21		* @param $port
22		* @return $this
23		*/
24	2	public function connect($host, $port, $timeout = null)
25		{
26	2	if (!$timeout) {
27	1	$timeout = ini_get('default_socket_timeout');
28		}
29	2	$this->socket = $this->phpFSockOpen($host, $port, $this->errorNumber, $this->errorString, $timeout);
30	2	return $this;
31		}
32
33		/**
34		* @return bool
35		*/
36	2	public function isConnected()
37		{
38	2	return (bool)$this->socket;
39		}
40
41		/**
42		* @param $str
43		* @param int\|null $length
44		* @return int
45		*/
46	1	public function write($str, $length = null)
47		{
48	1	if ($length) {
		0 ignored issues – show Bug Best Practice introduced 2017-04-18 14:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$length` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be zero. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
49	1	return $this->phpFWrite($this->socket, $str, $length);
50		}
51	1	return $this->phpFWrite($this->socket, $str);
52		}
53
54		/**
55		* @param $length
56		* @return string
57		*/
58	1	public function read($length)
59		{
60	1	return $this->phpFRead($this->socket, $length);
61		}
62
63		/**
64		* @return int
65		*/
66	3	public function getErrorNumber()
67		{
68	3	return $this->errorNumber;
69		}
70
71		/**
72		* @return string
73		*/
74	3	public function getErrorString()
75		{
76	3	return $this->errorString;
77		}
78
79		/**
80		* @param string $host
81		* @param int $port
82		* @param int $errno
83		* @param string $errstr
84		* @param float $timeout
85		* @return resource
86		* @codeCoverageIgnore
87		*/
88		protected function phpFSockOpen($host, $port, $errno, $errstr, $timeout)
89		{
90		return fsockopen($host, $port, $errno, $errstr, $timeout);
91		}
92
93		/**
94		* @return int
95		* @codeCoverageIgnore
96		*/
97		protected function phpFWrite()
98		{
99		return call_user_func_array('fwrite', func_get_args());
100		}
101
102		/**
103		* @param resource $handle
104		* @param int $length
105		* @return string
106		* @codeCoverageIgnore
107		*/
108		protected function phpFRead($handle, $length)
109		{
110		return fread($handle, $length);
111		}
112
113		/**
114		* @param resource $handle
115		* @return bool
116		* @codeCoverageIgnore
117		*/
118		protected function phpFClose($handle)
119		{
120		return fclose($handle);
121		}
122		}
123

Logi-CE / fmup

Issues (183)

Security Analysis not enabled

src/Socket.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like