Issues in Mail.php (master) - Issues in master - Logi-CE/fmup - Measure and Improve Code Quality continuously with Scrutinizer

Issues (183)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/ErrorHandler/Plugin/Mail.php (3 issues)

Labels

Severity

Minor 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace FMUP\ErrorHandler\Plugin;

use FMUP\Sapi;

class Mail extends Abstraction
{
    public function canHandle()
    {
        $config = $this->getBootstrap()->getConfig();
        return (
            (!$this->getException() instanceof \FMUP\Exception\Status)
            && !$config->get('use_daily_alert') && !$this->iniGet('display_errors')
        );
    }

    /**
     * @param string $key
     * @return string
     * @codeCoverageIgnore
     */
    protected function iniGet($key)
    {
        return ini_get($key);
    }

    /**
     * @return $this
     */
    public function handle()
    {
        $this->sendMail($this->getBody());
        return $this;
    }

    /**
     * @param string $body
     * @return bool
     * @throws \Exception
     * @throws \FMUP\Config\Exception
     * @throws \FMUP\Exception
     * @throws \phpmailerException
     */
    protected function sendMail($body)
    {
        $config = $this->getBootstrap()->getConfig();
        /** @var \FMUP\Request\Http $request */
        $request = $this->getRequest();
        $serverName = $this->getBootstrap()->getSapi()->get() != Sapi::CLI
            ? $request->getServer(\FMUP\Request\Http::SERVER_NAME)
            : $config->get('erreur_mail_sujet');
        $mail = $this->createMail($config);
        $mail->From = $config->get('mail_robot');
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $mail->FromName = $config->get('mail_robot_name');
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $mail->Subject = '[Erreur] ' . $serverName;
        $mail->AltBody = (string)$body;
        $mail->WordWrap = 50; // set word wrap

        $mail->Body = (string)$body;

        $recipients = $config->get('mail_support');
        if (strpos($recipients, ',') === false) {
            $mail->AddAddress($recipients, "Support");
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        } else {
            $tab_recipients = explode(',', $recipients);
            foreach ($tab_recipients as $recipient) {
                $mail->AddAddress($recipient);
            }
        }
        return $mail->Send();
    }

    /**
     * Creates a new mail for config
     * @param \FMUP\Config\ConfigInterface $config
     * @return \FMUP\Mail
     * @codeCoverageIgnore
     */
    protected function createMail(\FMUP\Config\ConfigInterface $config)
    {
        return new \FMUP\Mail($config);
    }

    /**
     * @todo clean this
     * @return string
     */
    protected function getBody()
    {
        $view = new \FMUP\View(array('exception' => $this->getException()));
        return $view->setViewPath($this->getViewPath())->render();
    }

    protected function getViewPath()
    {
        return __DIR__ . DIRECTORY_SEPARATOR . implode(DIRECTORY_SEPARATOR, array('Mail', 'render.phtml'));
    }
}


1		<?php
2		namespace FMUP\ErrorHandler\Plugin;
3
4		use FMUP\Sapi;
5
6		class Mail extends Abstraction
7		{
8	1	public function canHandle()
9		{
10	1	$config = $this->getBootstrap()->getConfig();
11		return (
12	1	(!$this->getException() instanceof \FMUP\Exception\Status)
13	1	&& !$config->get('use_daily_alert') && !$this->iniGet('display_errors')
14		);
15		}
16
17		/**
18		* @param string $key
19		* @return string
20		* @codeCoverageIgnore
21		*/
22		protected function iniGet($key)
23		{
24		return ini_get($key);
25		}
26
27		/**
28		* @return $this
29		*/
30	1	public function handle()
31		{
32	1	$this->sendMail($this->getBody());
33	1	return $this;
34		}
35
36		/**
37		* @param string $body
38		* @return bool
39		* @throws \Exception
40		* @throws \FMUP\Config\Exception
41		* @throws \FMUP\Exception
42		* @throws \phpmailerException
43		*/
44	1	protected function sendMail($body)
45		{
46	1	$config = $this->getBootstrap()->getConfig();
47		/** @var \FMUP\Request\Http $request */
48	1	$request = $this->getRequest();
49	1	$serverName = $this->getBootstrap()->getSapi()->get() != Sapi::CLI
50	1	? $request->getServer(\FMUP\Request\Http::SERVER_NAME)
51	1	: $config->get('erreur_mail_sujet');
52	1	$mail = $this->createMail($config);
53	1	$mail->From = $config->get('mail_robot');
		0 ignored issues – show Documentation Bug introduced 2017-04-18 14:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$config->get('mail_robot')` can also be of type `array`. However, the property `$From` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
54	1	$mail->FromName = $config->get('mail_robot_name');
		0 ignored issues – show Documentation Bug introduced 2017-04-18 14:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$config->get('mail_robot_name')` can also be of type `array`. However, the property `$FromName` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
55	1	$mail->Subject = '[Erreur] ' . $serverName;
56	1	$mail->AltBody = (string)$body;
57	1	$mail->WordWrap = 50; // set word wrap
58
59	1	$mail->Body = (string)$body;
60
61	1	$recipients = $config->get('mail_support');
62	1	if (strpos($recipients, ',') === false) {
63	1	$mail->AddAddress($recipients, "Support");
		0 ignored issues – show Bug introduced 2017-05-04 09:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$recipients` defined by `$config->get('mail_support')` on line `61` can also be of type `array` or `null`; however, `PHPMailer::addAddress()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
64		} else {
65	1	$tab_recipients = explode(',', $recipients);
66	1	foreach ($tab_recipients as $recipient) {
67	1	$mail->AddAddress($recipient);
68		}
69		}
70	1	return $mail->Send();
71		}
72
73		/**
74		* Creates a new mail for config
75		* @param \FMUP\Config\ConfigInterface $config
76		* @return \FMUP\Mail
77		* @codeCoverageIgnore
78		*/
79		protected function createMail(\FMUP\Config\ConfigInterface $config)
80		{
81		return new \FMUP\Mail($config);
82		}
83
84		/**
85		* @todo clean this
86		* @return string
87		*/
88	1	protected function getBody()
89		{
90	1	$view = new \FMUP\View(array('exception' => $this->getException()));
91	1	return $view->setViewPath($this->getViewPath())->render();
92		}
93
94	1	protected function getViewPath()
95		{
96	1	return __DIR__ . DIRECTORY_SEPARATOR . implode(DIRECTORY_SEPARATOR, array('Mail', 'render.phtml'));
97		}
98		}
99

Logi-CE / fmup

Issues (183)

Security Analysis not enabled

src/ErrorHandler/Plugin/Mail.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like