Logi-CE / fmup

src/Config/Ini.php

<?php
namespace FMUP\Config;

use FMUP\Config;

class Ini implements ConfigInterface
{
    private $filePath;
    private $section;
    private $config = array();

    /**
     * @param string $filePath
     * @param string|null $section
     */
    public function __construct($filePath, $section = null)
    {
        $this->filePath = (string)$filePath;
        $this->section = is_null($section) ? null : (string) $section;
    }

    /**
     * @return string
     * @throws Exception if file do not exists
     */
    protected function getFilePath()
    {
        if (!file_exists($this->filePath)) {
            throw new Exception('File does not exist');
        }
        return $this->filePath;
    }

    /**
     * @return null|string
     */
    protected function getSection()
    {
        return $this->section;
    }

    /**
     * @return array
     * @throws Exception if file do not exists
     */
    protected function getConfig()
    {
        if (!$this->config) {

The expression $this->config of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            $this->config = parse_ini_file($this->getFilePath(), $this->getSection());
        }
        return $this->config;
    }

    /**
     * @param string|null $key
     * @return mixed|null
     */
    public function get($key = null)
    {
        if ($this->has($key) || is_null($key)) {
            $config = $this->getConfig();
            return is_null($key) ? $config : $config[$key];
        }
        return null;
    }

    /**
     * @param string $paramName
     * @param string|null $value
     * @return $this
     */
    public function set($paramName, $value = null)
    {
        $this->config = $this->getConfig();
        $this->config[$paramName] = $value;
        return $this;
    }

    /**
     * @param string $paramName
     * @return bool
     */
    public function has($paramName)
    {
        $config = $this->getConfig();
        return isset($config[$paramName]);
    }

    /**
     * @param array $paramArray
     * @param bool|false $before
     * @return $this
     */
    public function mergeConfig(array $paramArray = array(), $before = false)
    {
        if ($before) {
            $this->config = $this->getConfig() + $paramArray;
        } else {
            $this->config = $paramArray + $this->getConfig();
        }
        return $this;
    }
}