FMUP\ProjectVersion

Complexity

Total Complexity

17

Size/Duplication

Total Lines	110
Duplicated Lines	11.82 %

Coupling/Cohesion

Components	2
Dependencies	0

Importance

Changes	5
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	getInstance()	0	8	2
A	__construct()	0	3	1
A	__clone()	0	3	1
B	get()	0	21	5
A	getGitHeadFilePath()	0	4	1
A	getEnv()	0	4	1
A	name()	0	4	1
A	getComposerPath()	0	4	1
A	getStructure()	13	13	4

<?php
namespace FMUP;

/**
 * Class ProjectVersion
 * @package LogiCE
 */
class ProjectVersion
{
    private static $instance;
    private $structure;

    /**
     * @return $this
     */
    final public static function getInstance()
    {
        if (!self::$instance) {
            $class = get_called_class();
            self::$instance = new $class;
        }
        return self::$instance;
    }

    /**
     * private construct - singleton
     */
    private function __construct()
    {
    }

    /**
     * private clone - singleton
     * @codeCoverageIgnore
     */
    private function __clone()
    {
    }

    /**
     * Get version name
     * @return string
     */
    public function get()
    {
        $version = $this->getEnv('PROJECT_VERSION');

The expression $this->getEnv('PROJECT_VERSION'); of type array|false|string adds the type array to the return on line 48 which is incompatible with the return type documented by FMUP\ProjectVersion::get of type string.

        if ($version) {
            return $version;
        }
        try {
            if (isset($this->getStructure()->version)) {
                return $this->getStructure()->version;
            }
        } catch (\LogicException $e) {

Consider adding a comment why this CATCH block is empty.

        }
        $rootPath = $this->getGitHeadFilePath();
        if (file_exists($rootPath)) {
            $stringFromFile = file($rootPath);
            $firstLine = $stringFromFile[0]; //get the string from the array
            $explodedString = explode("/", $firstLine, 3); //seperate out by the "/" in the string
            return trim($explodedString[2]); //get the one that is always the branch name
        }
        return 'v0.0.0';
    }

    /**
     * @return string
     * @codeCoverageIgnore
     */
    protected function getGitHeadFilePath()
    {
        return implode(DIRECTORY_SEPARATOR, array(__DIR__, '..', '..', '..', '..', '.git', 'HEAD'));
    }

    /**
     * Retrieve environment variable
     * @param string $name
     * @return array|false|string
     * @codeCoverageIgnore
     */
    protected function getEnv($name)
    {
        return getenv($name);
    }

    public function name()
    {
        return $this->getStructure()->name;
    }

    /**
     * Return composer.json path to project
     * @return string
     */
    protected function getComposerPath()
    {
        return implode(DIRECTORY_SEPARATOR, array(__DIR__, '..', '..', '..', '..', 'composer.json'));
    }

    /**
     * Get composer file structure
     * @return Object
     */
    protected function getStructure()

This method seems to be duplicated in your project.

    {
        if (!$this->structure) {
            if (!is_file($this->getComposerPath())) {
                throw new \LogicException('composer.json does not exist');
            }
            $this->structure = json_decode(file_get_contents($this->getComposerPath()));
            if (!$this->structure) {
                throw new \LogicException('composer.json invalid structure');
            }
        }
        return $this->structure;
    }
}