Error::configure() - Code Metrics - Logi-CE/fmup - Measure and Improve Code Quality continuously with Scrutinizer

Error::configure() A
last analyzed 2017-12-05 10:44 UTC

↳ Parent: Error

Complexity

Conditions	1
Paths	1

Size

Total Lines	16
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	12
nc	1
nop	0
dl	0
loc	16
ccs	12
cts	12
cp	1
crap	1
rs	9.4285
c	0
b	0
f	0

<?php
namespace FMUP\Logger\Channel;

use FMUP\Logger\Channel;
use Monolog\Formatter\HtmlFormatter;
use Monolog\Handler\NativeMailerHandler;
use Monolog\Logger;
use Monolog\Processor\IntrospectionProcessor;
use Monolog\Processor\WebProcessor;

/**
 * Class Error
 * @package FMUP\Logger\Channel
 */
class Error extends Channel
{
    const NAME = 'Error';

    private $projectVersion;

    public function configure()
    {
        $handler = new NativeMailerHandler(
            explode(',', $this->getConfig()->get('mail_support')),
            '[Erreur] ' . $this->getProjectVersion()->name(),
            $this->getConfig()->get('mail_robot'),

            Logger::CRITICAL
        );
        $handler->setFormatter(new HtmlFormatter());

        $this->getLogger()
            ->pushProcessor(new IntrospectionProcessor())
            ->pushProcessor(new WebProcessor())
            ->pushHandler($handler);
        return $this;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @return \FMUP\ProjectVersion
     */
    public function getProjectVersion()
    {
        if (!$this->projectVersion) {
            $this->projectVersion = \FMUP\ProjectVersion::getInstance();
        }
        return $this->projectVersion;
    }

    /**
     * @param \FMUP\ProjectVersion $projectVersion
     * @return $this
     */
    public function setProjectVersion(\FMUP\ProjectVersion $projectVersion)
    {
        $this->projectVersion = $projectVersion;
        return $this;
    }
}


1		<?php
2		namespace FMUP\Logger\Channel;
3
4		use FMUP\Logger\Channel;
5		use Monolog\Formatter\HtmlFormatter;
6		use Monolog\Handler\NativeMailerHandler;
7		use Monolog\Logger;
8		use Monolog\Processor\IntrospectionProcessor;
9		use Monolog\Processor\WebProcessor;
10
11		/**
12		* Class Error
13		* @package FMUP\Logger\Channel
14		*/
15		class Error extends Channel
16		{
17		const NAME = 'Error';
18
19		private $projectVersion;
20
21	1	public function configure()
22		{
23	1	$handler = new NativeMailerHandler(
24	1	explode(',', $this->getConfig()->get('mail_support')),
25	1	'[Erreur] ' . $this->getProjectVersion()->name(),
26	1	$this->getConfig()->get('mail_robot'),
		0 ignored issues – show Bug introduced 2017-05-04 09:41 UTC by Report Bug Copy Issue Report It seems like `$this->getConfig()->get('mail_robot')` targeting `FMUP\Config\ConfigInterface::get()` can also be of type `array` or `null`; however, `Monolog\Handler\NativeMailerHandler::__construct()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
27	1	Logger::CRITICAL
28		);
29	1	$handler->setFormatter(new HtmlFormatter());
30
31	1	$this->getLogger()
32	1	->pushProcessor(new IntrospectionProcessor())
33	1	->pushProcessor(new WebProcessor())
34	1	->pushHandler($handler);
35	1	return $this;
		0 ignored issues – show Bug Best Practice introduced 2017-04-18 14:53 UTC by Report Bug Copy Issue Report The return type of `return $this;` (`FMUP\Logger\Channel\Error`) is incompatible with the return type declared by the abstract method `FMUP\Logger\Channel::configure` of type `Monolog\Logger`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
36		}
37
38		/**
39		* @return \FMUP\ProjectVersion
40		*/
41	1	public function getProjectVersion()
42		{
43	1	if (!$this->projectVersion) {
44	1	$this->projectVersion = \FMUP\ProjectVersion::getInstance();
45		}
46	1	return $this->projectVersion;
47		}
48
49		/**
50		* @param \FMUP\ProjectVersion $projectVersion
51		* @return $this
52		*/
53	1	public function setProjectVersion(\FMUP\ProjectVersion $projectVersion)
54		{
55	1	$this->projectVersion = $projectVersion;
56	1	return $this;
57		}
58		}
59

Logi-CE / fmup

Error::configure() A last analyzed 2017-12-05 10:44 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

Error::configure() A
last analyzed 2017-12-05 10:44 UTC