ErrorController::handle() - Code Metrics - Logi-CE/fmup - Measure and Improve Code Quality continuously with Scrutinizer

ErrorController::handle() A
last analyzed 2017-12-05 10:44 UTC

↳ Parent: ErrorController

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	11
nc	1
nop	0
dl	0
loc	13
ccs	10
cts	10
cp	1
crap	1
rs	9.4285
c	0
b	0
f	0

<?php
namespace FMUP\ErrorHandler\Plugin;

use FMUP\Controller\Error;
use FMUP\Exception;

/**
 * Class ErrorController
 * @package FMUP\ErrorHandler
 */
class ErrorController extends Abstraction
{
    private $errorController;

    /**
     * @param Error $errorController
     */
    public function __construct(Error $errorController)
    {
        $this->setErrorController($errorController);
    }

    /**
     * @param Error $errorController
     * @return $this
     */
    public function setErrorController(Error $errorController)
    {
        $this->errorController = $errorController;
        return $this;
    }

    /**
     * @return Error
     * @throws Exception
     */
    public function getErrorController()
    {
        if (!$this->errorController) {
            throw new Exception('Error Controller must be set');
        }
        return $this->errorController;
    }

    /**
     * Always handle error with error controller
     * @return bool
     */
    public function canHandle()
    {
        return true;
    }

    /**
     * @return $this
     * @throws \FMUP\Exception
     */
    public function handle()
    {
        $errorController = $this->getErrorController();
        $errorController
            ->setBootstrap($this->getBootstrap())
            ->setRequest($this->getRequest())
            ->setResponse($this->getResponse())
            ->setException($this->getException());
        $errorController->preFilter('index');
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        $errorController->indexAction();
        $errorController->postFilter('index');
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        return $this;
    }
}


1		<?php
2		namespace FMUP\ErrorHandler\Plugin;
3
4		use FMUP\Controller\Error;
5		use FMUP\Exception;
6
7		/**
8		* Class ErrorController
9		* @package FMUP\ErrorHandler
10		*/
11		class ErrorController extends Abstraction
12		{
13		private $errorController;
14
15		/**
16		* @param Error $errorController
17		*/
18	3	public function __construct(Error $errorController)
19		{
20	3	$this->setErrorController($errorController);
21	3	}
22
23		/**
24		* @param Error $errorController
25		* @return $this
26		*/
27	3	public function setErrorController(Error $errorController)
28		{
29	3	$this->errorController = $errorController;
30	3	return $this;
31		}
32
33		/**
34		* @return Error
35		* @throws Exception
36		*/
37	3	public function getErrorController()
38		{
39	3	if (!$this->errorController) {
40	1	throw new Exception('Error Controller must be set');
41		}
42	2	return $this->errorController;
43		}
44
45		/**
46		* Always handle error with error controller
47		* @return bool
48		*/
49	1	public function canHandle()
50		{
51	1	return true;
52		}
53
54		/**
55		* @return $this
56		* @throws \FMUP\Exception
57		*/
58	1	public function handle()
59		{
60	1	$errorController = $this->getErrorController();
61		$errorController
62	1	->setBootstrap($this->getBootstrap())
63	1	->setRequest($this->getRequest())
64	1	->setResponse($this->getResponse())
65	1	->setException($this->getException());
66	1	$errorController->preFilter('index');
		0 ignored issues – show Unused Code introduced 2017-04-18 14:53 UTC by Report Bug Copy Issue Report The call to the method `FMUP\Controller\Error::preFilter()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
67	1	$errorController->indexAction();
68	1	$errorController->postFilter('index');
		0 ignored issues – show Unused Code introduced 2017-04-18 14:53 UTC by Report Bug Copy Issue Report The call to the method `FMUP\Controller\Error::postFilter()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
69	1	return $this;
70		}
71		}
72

Logi-CE / fmup

ErrorController::handle() A last analyzed 2017-12-05 10:44 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

ErrorController::handle() A
last analyzed 2017-12-05 10:44 UTC