Standard - Code Metrics - Logi-CE/fmup - Measure and Improve Code Quality continuously with Scrutinizer

Standard A
last analyzed 2017-12-05 10:44 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
dl	0
loc	26
ccs	9
cts	9
cp	1
rs	10
c	0
b	0
f	0
wmc	7
lcom	1
cbo	5

2 Methods

Rating	Name	Duplication	Size	Complexity
A	headerSent()	0	4	1
B	configure()	0	12	6

<?php
namespace FMUP\Logger\Channel;

use FMUP\Environment;
use FMUP\Sapi;
use Monolog\Handler\ChromePHPHandler;
use Monolog\Handler\FirePHPHandler;
use FMUP\Logger\Channel;

class Standard extends Channel
{
    const NAME = 'Standard';

    public function configure()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $canSendHeaders = !$this->headerSent() && $this->getSapi()->get() != Sapi::CLI;
        $isDev = $this->getEnvironment()->get() == Environment::DEV;
        $allowBrowser = isset($_SERVER['HTTP_USER_AGENT']) && strpos($_SERVER['HTTP_USER_AGENT'], 'Castelis') !== false;
        if ($canSendHeaders && ($allowBrowser || $isDev)) {
            $this->getLogger()
                ->pushHandler(new FirePHPHandler())
                ->pushHandler(new ChromePHPHandler());
        }
        return $this;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @codeCoverageIgnore
     * @return bool
     */
    protected function headerSent()
    {
        return headers_sent();
    }
}


1		<?php
2		namespace FMUP\Logger\Channel;
3
4		use FMUP\Environment;
5		use FMUP\Sapi;
6		use Monolog\Handler\ChromePHPHandler;
7		use Monolog\Handler\FirePHPHandler;
8		use FMUP\Logger\Channel;
9
10		class Standard extends Channel
11		{
12		const NAME = 'Standard';
13
14	1	public function configure()
		0 ignored issues – show Coding Style introduced 2017-05-04 09:41 UTC by Report Bug Copy Issue Report `configure` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
15		{
16	1	$canSendHeaders = !$this->headerSent() && $this->getSapi()->get() != Sapi::CLI;
17	1	$isDev = $this->getEnvironment()->get() == Environment::DEV;
18	1	$allowBrowser = isset($_SERVER['HTTP_USER_AGENT']) && strpos($_SERVER['HTTP_USER_AGENT'], 'Castelis') !== false;
19	1	if ($canSendHeaders && ($allowBrowser \|\| $isDev)) {
20	1	$this->getLogger()
21	1	->pushHandler(new FirePHPHandler())
22	1	->pushHandler(new ChromePHPHandler());
23		}
24	1	return $this;
		0 ignored issues – show Bug Best Practice introduced 2017-04-18 14:53 UTC by Report Bug Copy Issue Report The return type of `return $this;` (`FMUP\Logger\Channel\Standard`) is incompatible with the return type declared by the abstract method `FMUP\Logger\Channel::configure` of type `Monolog\Logger`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
25		}
26
27		/**
28		* @codeCoverageIgnore
29		* @return bool
30		*/
31		protected function headerSent()
32		{
33		return headers_sent();
34		}
35		}
36

Logi-CE / fmup

Standard A last analyzed 2017-12-05 10:44 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like

Standard A
last analyzed 2017-12-05 10:44 UTC