Locastic\SymfonyTranslationBundle\Controller\SaveTranslationsAction

Complexity

Total Complexity

2

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	__invoke()	0	8	1

<?php

declare(strict_types=1);

namespace Locastic\SymfonyTranslationBundle\Controller;

use Locastic\SymfonyTranslationBundle\Saver\TranslationValueSaverInterface;
use Locastic\SymfonyTranslationBundle\Transformer\TranslationValueToFormFieldTransformerInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

final class SaveTranslationsAction
{
    private TranslationValueToFormFieldTransformerInterface $translationValueToFormTransformer;

    private TranslationValueSaverInterface $translationValueSaver;

    public function __construct(
        TranslationValueToFormFieldTransformerInterface $translationValueToFormTransformer,
        TranslationValueSaverInterface $translationValueSaver
    ) {
        $this->translationValueToFormTransformer = $translationValueToFormTransformer;
        $this->translationValueSaver = $translationValueSaver;
    }

    public function __invoke(Request $request): Response
    {
        $translations = $request->request->all('translations');
        $translationValue = $this->translationValueToFormTransformer->reverseTransform($translations);

        $this->translationValueSaver->saveTranslationValue($translationValue);

It seems like $translationValue can also be of type null; however, parameter $translationValue of Locastic\SymfonyTranslationBundle\Saver\TranslationValueSaverInterface::saveTranslationValue() does only seem to accept Locastic\SymfonyTranslationBundle\Model\TranslationValueInterface, maybe add an additional type check?

        return new Response(null, Response::HTTP_NO_CONTENT);
    }
}