Locastic / SyliusComparerPlugin

src/DependencyInjection/LocasticSyliusComparerExtension.php

<?php

declare(strict_types=1);

namespace Locastic\SyliusComparerPlugin\DependencyInjection;

use Symfony\Component\Config\FileLocator;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Extension\Extension;
use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;

final class LocasticSyliusComparerExtension extends Extension
{
    /**
     * {@inheritdoc}
     */
    public function load(array $config, ContainerBuilder $container): void
    {
        $config = $this->processConfiguration($this->getConfiguration([], $container), $config);

The assignment to $config is dead and can be removed.

It seems like $this->getConfiguration(array(), $container) can also be of type null; however, parameter $configuration of Symfony\Component\DependencyInjection\Extension\Extension::processConfiguration() does only seem to accept Symfony\Component\Config\Definition\ConfigurationInterface, maybe add an additional type check?

        $loader = new YamlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));

        $loader->load('services.yml');
    }
}