Locastic\SyliusComparerPlugin\Factory\RemoveProductFromComparerRequestFactory

Complexity

Total Complexity

2

Size/Duplication

Total Lines	15
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	create()	0	5	1

<?php

declare(strict_types=1);

namespace Locastic\SyliusComparerPlugin\Factory;

use Locastic\SyliusComparerPlugin\Context\ComparerContextInterface;
use Locastic\SyliusComparerPlugin\Request\ComparerRequestInterface;
use Locastic\SyliusComparerPlugin\Request\RemoveProductFromComparerRequest;
use Symfony\Component\HttpFoundation\Request;

class RemoveProductFromComparerRequestFactory implements ComparerRequestFactoryInterface
{
    /** @var ComparerContextInterface */
    private $comparerContext;

    public function __construct(ComparerContextInterface $comparerContext)
    {
        $this->comparerContext = $comparerContext;
    }

    public function create(Request $request): ComparerRequestInterface
    {
        return new RemoveProductFromComparerRequest(
            $request->get('productId'),

It seems like $request->get('productId') can also be of type null; however, parameter $productId of Locastic\SyliusComparerPlugin\Request\RemoveProductFromComparerRequest::__construct() does only seem to accept string, maybe add an additional type check?

            $this->comparerContext->getComparer($request)

It seems like $this->comparerContext->getComparer($request) can also be of type null; however, parameter $comparer of Locastic\SyliusComparerPlugin\Request\RemoveProductFromComparerRequest::__construct() does only seem to accept Locastic\SyliusComparerPlugin\Entity\ComparerInterface, maybe add an additional type check?

        );
    }
}