PostDetailViewModel - Code Metrics - Lloople/blog - Measure and Improve Code Quality continuously with Scrutinizer

PostDetailViewModel A
last analyzed 2018-02-13 21:55 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
wmc	8
lcom	1
cbo	3
dl	0
loc	38
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	__construct()	14	2
A	setTitle()	6	2
A	setAction()	6	2
A	setMethod()	6	2

<?php

namespace App\ViewModels;

use App\Models\Tag;
use App\Models\Post;
use App\Models\Category;
use Illuminate\Support\Carbon;

class PostDetailViewModel extends FormViewModel
{
    public function __construct(Post $post)
    {
        parent::__construct($post);

        $this->published_at = $this->model->exists
class MyClass { }

$x = new MyClass();
$x->foo = true;
            ? $this->model->published_at->format('Y-m-d\TH:i')
            : Carbon::now()->format('Y-m-d\TH:i');

        $this->categories = Category::select('id', 'name')->pluck('name', 'id');
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $this->currentTags = $this->model->tags->pluck('name');
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $this->tags = Tag::orderBy('name')->pluck('name');
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    protected function setTitle()
    {
        $this->title = $this->model->exists
            ? "Edit Post: {$this->model->title}"
            : 'Create Post';
    }

    protected function setAction()
    {
        $this->action = $this->model->exists
            ? route('backend.posts.update', $this->model)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            : route('backend.posts.store');
    }

    protected function setMethod()
    {
        $this->method = $this->model->exists
            ? 'PUT'
            : 'POST';
    }
}


1			<?php
2
3			namespace App\ViewModels;
4
5			use App\Models\Tag;
6			use App\Models\Post;
7			use App\Models\Category;
8			use Illuminate\Support\Carbon;
9
10			class PostDetailViewModel extends FormViewModel
11			{
12			public function __construct(Post $post)
13			{
14			parent::__construct($post);
15
16			$this->published_at = $this->model->exists
			0 ignored issues – show Bug introduced 2018-01-07 15:37 UTC by Report Bug Copy Issue Report The property `published_at` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
17			? $this->model->published_at->format('Y-m-d\TH:i')
18			: Carbon::now()->format('Y-m-d\TH:i');
19
20			$this->categories = Category::select('id', 'name')->pluck('name', 'id');
			0 ignored issues – show Bug introduced 2018-01-30 22:39 UTC by Report Bug Copy Issue Report The property `categories` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
21
22			$this->currentTags = $this->model->tags->pluck('name');
			0 ignored issues – show Bug introduced 2018-01-30 22:39 UTC by Report Bug Copy Issue Report The property `currentTags` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
23
24			$this->tags = Tag::orderBy('name')->pluck('name');
			0 ignored issues – show Bug introduced 2018-01-30 22:39 UTC by Report Bug Copy Issue Report The property `tags` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
25			}
26
27			protected function setTitle()
28			{
29			$this->title = $this->model->exists
30			? "Edit Post: {$this->model->title}"
31			: 'Create Post';
32			}
33
34			protected function setAction()
35			{
36			$this->action = $this->model->exists
37			? route('backend.posts.update', $this->model)
			0 ignored issues – show Documentation introduced 2018-01-07 15:37 UTC by Report Bug Copy Issue Report `$this->model` is of type `object<Illuminate\Database\Eloquent\Model>`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
38			: route('backend.posts.store');
39			}
40
41			protected function setMethod()
42			{
43			$this->method = $this->model->exists
44			? 'PUT'
45			: 'POST';
46			}
47			}
48

Lloople / blog

PostDetailViewModel A last analyzed 2018-02-13 21:55 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like

PostDetailViewModel A
last analyzed 2018-02-13 21:55 UTC