App\Http\Controllers\Backend\ThemesController

Complexity

Total Complexity

13

Size/Duplication

Total Lines	142
Duplicated Lines	33.8 %

Coupling/Cohesion

Components	2
Dependencies	8

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	4	1
A	create()	0	4	1
A	store()	20	20	2
A	edit()	0	4	1
A	update()	18	18	2
B	destroy()	0	28	4
A	resource()	10	10	2

<?php

namespace App\Http\Controllers\Backend;

use App\Models\Theme;
use Illuminate\Http\Request;
use App\Http\Controllers\Controller;
use Lloople\Notificator\Notificator;
use App\Http\Resources\ThemeResource;
use App\Http\Requests\ThemeFormRequest;
use App\ViewModels\ThemeDetailViewModel;

class ThemesController extends Controller
{
    private $pagination = 50;

    /**
     * Display a listing of the resource.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)

The parameter $request is not used and could be removed.

    {
        return view('backend.themes.index');
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        return view('backend.themes.edit', ['view' => new ThemeDetailViewModel(new Theme())]);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  ThemeFormRequest $request
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store(ThemeFormRequest $request)

This method seems to be duplicated in your project.

    {
        $theme = new Theme();

        $theme->name = $request->name;

The property name does not seem to exist in App\Http\Requests\ThemeFormRequest.

        $theme->selected = $request->has('selected');

        $theme->updateColors($request->all());

        $theme->save();

        if ($theme->selected) {
            $theme->disableOtherThemes();
        }

        Notificator::success('Theme created successfully');

        return redirect()->route('backend.themes.edit', $theme);

$theme is of type object<App\Models\Theme>, but the function expects a array.

    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param \App\Models\Theme $theme
     *
     * @return void
     */
    public function edit(Theme $theme)
    {
        return view('backend.themes.edit', ['view' => new ThemeDetailViewModel($theme)]);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \App\Http\Requests\ThemeFormRequest $request
     * @param  \App\Models\Theme $theme
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function update(ThemeFormRequest $request, Theme $theme)

This method seems to be duplicated in your project.

    {
        $theme->name = $request->name;

The property name does not seem to exist in App\Http\Requests\ThemeFormRequest.

        $theme->selected = $request->has('selected');

        $theme->updatecolors($request->all());

        $theme->save();

        if ($theme->selected) {
            $theme->disableOtherThemes();
        }

        Notificator::success('Theme edited successfully');

        return redirect()->route('backend.themes.edit', $theme);

$theme is of type object<App\Models\Theme>, but the function expects a array.

    }

    /**
     * Remove the specified resource from storage.
     *
     * @param \Illuminate\Http\Request $request
     * @param  \App\Models\Theme $theme
     *
     * @return array
     * @throws \Exception
     */
    public function destroy(Request $request, Theme $theme)
    {
        if ($theme->selected) {
            if ($request->ajax()) {
                return [
                    'result' => false,
                    'message' => 'Default theme cannot be deleted.',
                ];
            }

            Notificator::error('Default theme cannot be deleted.');

            return back();
        }

        $theme->delete();

        if ($request->ajax()) {
            return [
                'result'  => true,
                'message' => 'Theme deleted successfully.',
            ];
        }

        Notificator::success('Theme deleted successfully.');

        return redirect()->route('backend.themes.index');
    }

    public function resource(Request $request)

This method seems to be duplicated in your project.

    {
        $themes = Theme::select('*');

        if ($request->has('q')) {
            $themes->where('name', 'like', "%{$request->q}%");
        }

        return ThemeResource::collection($themes->orderBy('selected', 'DESC')->orderBy('name')->paginate($this->pagination));
    }
}