App\Http\Controllers\Backend\PostsController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	129
Duplicated Lines	36.43 %

Coupling/Cohesion

Components	2
Dependencies	10

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	4	1
A	create()	0	4	1
A	store()	19	19	1
A	edit()	0	4	1
A	update()	18	18	1
A	destroy()	0	17	2
A	resource()	10	10	2

<?php

namespace App\Http\Controllers\Backend;

use Carbon\Carbon;
use App\Models\Post;
use Illuminate\Http\Request;
use App\Http\Controllers\Controller;
use App\Http\Resources\PostResource;
use Lloople\Notificator\Notificator;
use App\Http\Requests\PostFormRequest;
use App\ViewModels\PostDetailViewModel;

class PostsController extends Controller
{
    private $pagination = 15;

    /**
     * Display a listing of the resource.
     *
     * @param \Illuminate\Http\Request $request
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)

The parameter $request is not used and could be removed.

    {
        return view('backend.posts.index');
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        return view('backend.posts.edit', ['view' => new PostDetailViewModel(new Post())]);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param \App\Http\Requests\PostFormRequest $request
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store(PostFormRequest $request)

This method seems to be duplicated in your project.

    {
        $post = new Post();
        $post->title = $request->title;

The property title does not seem to exist in App\Http\Requests\PostFormRequest.

        $post->slug = str_slug($request->title);

The property title does not exist on object<App\Http\Requests\PostFormRequest>. Since you implemented __get, maybe consider adding a @property annotation.

        $post->category_id = $request->category;

The property category does not seem to exist in App\Http\Requests\PostFormRequest.

        $post->published_at = Carbon::createFromFormat('Y-m-d\TH:i', $request->published_at);

The property published_at does not exist on object<App\Http\Requests\PostFormRequest>. Since you implemented __get, maybe consider adding a @property annotation.

        $post->featured = $request->has('featured');
        $post->visible = $request->has('visible');

The property $visible is declared protected in Illuminate\Database\Eloquent\Concerns\HidesAttributes. Since you implemented __set(), maybe consider adding a @property or @property-write annotation. This makes it easier for IDEs to provide auto-completion.

It seems like $request->has('visible') of type boolean is incompatible with the declared type array of property $visible.

        $post->body = $request->body;

The property body does not seem to exist in App\Http\Requests\PostFormRequest.

        $post->save();

        $post->syncTags($request->tags);

The property tags does not exist on object<App\Http\Requests\PostFormRequest>. Since you implemented __get, maybe consider adding a @property annotation.

        Notificator::success('Post created successfully');

        return redirect()->route('backend.posts.edit', $post);

$post is of type object<App\Models\Post>, but the function expects a array.

    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param \App\Models\Post $post
     *
     * @return void
     */
    public function edit(Post $post)
    {
        return view('backend.posts.edit', ['view' => new PostDetailViewModel($post)]);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param \App\Http\Requests\PostFormRequest $request
     * @param  Post $post
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function update(PostFormRequest $request, Post $post)

This method seems to be duplicated in your project.

    {
        $post->title = $request->title;

The property title does not seem to exist in App\Http\Requests\PostFormRequest.

        $post->slug = str_slug($request->title);

The property title does not exist on object<App\Http\Requests\PostFormRequest>. Since you implemented __get, maybe consider adding a @property annotation.

        $post->category_id = $request->category;

The property category does not seem to exist in App\Http\Requests\PostFormRequest.

        $post->published_at = Carbon::createFromFormat('Y-m-d\TH:i', $request->published_at);

The property published_at does not exist on object<App\Http\Requests\PostFormRequest>. Since you implemented __get, maybe consider adding a @property annotation.

        $post->featured = $request->has('featured');
        $post->visible = $request->has('visible');

The property $visible is declared protected in Illuminate\Database\Eloquent\Concerns\HidesAttributes. Since you implemented __set(), maybe consider adding a @property or @property-write annotation. This makes it easier for IDEs to provide auto-completion.

It seems like $request->has('visible') of type boolean is incompatible with the declared type array of property $visible.

        $post->body = $request->body;

The property body does not seem to exist in App\Http\Requests\PostFormRequest.

        $post->save();

        $post->syncTags($request->tags);

The property tags does not exist on object<App\Http\Requests\PostFormRequest>. Since you implemented __get, maybe consider adding a @property annotation.

        Notificator::success('Post edited successfully');

        return redirect()->route('backend.posts.edit', $post);

$post is of type object<App\Models\Post>, but the function expects a array.

    }

    /**
     * Remove the specified resource from storage.
     *
     * @param \Illuminate\Http\Request $request
     * @param  Post $post
     *
     * @return array
     * @throws \Exception
     */
    public function destroy(Request $request, Post $post)
    {
        $post->tags()->sync([]);

        $post->delete();

        if ($request->ajax()) {
            return [
                'result' => true,
                'message' => 'Post deleted successfully.',
            ];
        }

        Notificator::success('Post deleted successfully.');

        return redirect()->route('backend.posts.index');
    }

    public function resource(Request $request)

This method seems to be duplicated in your project.

    {
        $posts = Post::with('tags');

        if ($request->has('q')) {
            $posts->searchLike($request->q);
        }

        return PostResource::collection($posts->orderBy('published_at', 'DESC')->paginate($this->pagination));
    }
}