App\Http\Controllers\Backend\CategoriesController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	120
Duplicated Lines	29.17 %

Coupling/Cohesion

Components	2
Dependencies	8

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	4	1
A	create()	0	4	1
A	store()	13	13	1
A	edit()	0	4	1
A	update()	12	12	1
B	destroy()	0	20	5
A	resource()	10	10	2

<?php

namespace App\Http\Controllers\Backend;

use App\Models\Category;
use Illuminate\Http\Request;
use App\Http\Controllers\Controller;
use Lloople\Notificator\Notificator;
use App\Http\Resources\CategoryResource;
use App\Http\Requests\CategoryFormRequest;
use App\ViewModels\CategoryDetailViewModel;

class CategoriesController extends Controller
{
    private $pagination = 50;

    /**
     * Display a listing of the resource.
     *
     * @param \Illuminate\Http\Request $request
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)

The parameter $request is not used and could be removed.

    {
        return view('backend.categories.index');
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        return view('backend.categories.edit', ['view' => new CategoryDetailViewModel(new Category())]);
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param  \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store(CategoryFormRequest $request)

This method seems to be duplicated in your project.

    {
        $category = new Category();
        $category->name = $request->name;

The property name does not seem to exist in App\Http\Requests\CategoryFormRequest.

        $category->slug = str_slug($request->name);

The property name does not exist on object<App\Http\Requests\CategoryFormRequest>. Since you implemented __get, maybe consider adding a @property annotation.

        $category->active = $request->has('active');

        $category->save();

        Notificator::success('Category created successfully');

        return redirect()->route('backend.categories.edit', $category);

$category is of type object<App\Models\Category>, but the function expects a array.

    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param \App\Models\Category $category
     *
     * @return void
     */
    public function edit(Category $category)
    {
        return view('backend.categories.edit', ['view' => new CategoryDetailViewModel($category)]);
    }

    /**
     * Update the specified resource in storage.
     *
     * @param  \Illuminate\Http\Request $request
     * @param  \App\Models\Category $category
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function update(CategoryFormRequest $request, Category $category)

This method seems to be duplicated in your project.

    {
        $category->name = $request->name;

The property name does not seem to exist in App\Http\Requests\CategoryFormRequest.

        $category->slug = str_slug($request->name);

The property name does not exist on object<App\Http\Requests\CategoryFormRequest>. Since you implemented __get, maybe consider adding a @property annotation.

        $category->active = $request->has('active');

        $category->save();

        Notificator::success('Category edited successfully');

        return redirect()->route('backend.categories.edit', $category);

$category is of type object<App\Models\Category>, but the function expects a array.

    }

    /**
     * Remove the specified resource from storage.
     *
     * @param \Illuminate\Http\Request $request
     * @param  \App\Models\Category $category
     *
     * @return array
     * @throws \Exception
     */
    public function destroy(Request $request, Category $category)
    {
        if ($canDelete = $category->posts->count() === 0) {
            $category->delete();
        }

        $message = $canDelete
            ? 'Category deleted successfully.'
            : 'Cannot delete this category because it has posts.';

        if ($request->ajax()) {
            return ['result' => $canDelete, 'message' => $message];
        }

        $notificationType = $canDelete ? 'success' : 'error';

        Notificator::$notificationType($message);

        return redirect()->route('backend.categories.index');
    }

    public function resource(Request $request)

This method seems to be duplicated in your project.

    {
        $categories = Category::select('*');

        if ($request->has('q')) {
            $categories->where('name', 'like', "%{$request->q}%");
        }

        return CategoryResource::collection($categories->orderBy('name')->paginate($this->pagination));
    }
}