ConversationHistory::prev() - Code Metrics - Inspection of "add the yml?" - LivePersonInc/LiveEngageLaravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (4d174b)

by Robert

created 2018-06-12 16:58 UTC

ConversationHistory::prev() B

↳ Parent: ConversationHistory

Complexity

Conditions	4
Paths	4

Size

Total Lines	22
Code Lines	13

Duplication

Lines	22
Ratio	100 %

Importance

Changes

Metric	Value
dl	22
loc	22
c	0
b	0
f	0
rs	8.9197
cc	4
eloc	13
nc	4
nop	0

<?php

namespace LivePersonInc\LiveEngageLaravel\Collections;

use Illuminate\Support\Collection;
use LivePersonInc\LiveEngageLaravel\LiveEngageLaravel;
use LivePersonInc\LiveEngageLaravel\Models\Conversation;

class ConversationHistory extends Collection

{
    private $instance;

    public function __construct(array $models = [], LiveEngageLaravel $instance = null)
    {
        $this->instance = $instance;

        parent::__construct($models);
    }

    public function next()
    {
        if (! $this->instance) {
            return false;
        }

        $instance = $this->instance;

        $next = $instance->retrieveMsgHistory($instance->start, $instance->end, $instance->next);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        if (property_exists($next->_metadata, 'next')) {
            $instance->next = $next->_metadata->next->href;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

            $history = [];
            foreach ($next->conversationHistoryRecords as $item) {
                $history[] = new Conversation((array) $item);
            }

            return $this->merge(new self($history));
        } else {
            return false;
        }
    }

    public function prev()
    {
        if (! $this->instance) {
            return false;
        }

        $instance = $this->instance;

        $prev = $instance->retrieveMsgHistory($instance->start, $instance->end, $instance->prev);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        if (property_exists($prev->_metadata, 'prev')) {
            $instance->prev = $prev->_metadata->prev->href;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

            $history = [];
            foreach ($next->conversationHistoryRecords as $item) {

                $history[] = new Conversation((array) $item);
            }

            return $this->merge(new self($history));
        } else {
            return false;
        }
    }
}


1		<?php
2
3		namespace LivePersonInc\LiveEngageLaravel\Collections;
4
5		use Illuminate\Support\Collection;
6		use LivePersonInc\LiveEngageLaravel\LiveEngageLaravel;
7		use LivePersonInc\LiveEngageLaravel\Models\Conversation;
8
9	View Code Duplication	class ConversationHistory extends Collection
		0 ignored issues – show Duplication introduced 2018-06-12 17:05 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
10		{
11		private $instance;
12
13		public function __construct(array $models = [], LiveEngageLaravel $instance = null)
14		{
15		$this->instance = $instance;
16
17		parent::__construct($models);
18		}
19
20		public function next()
21		{
22		if (! $this->instance) {
23		return false;
24		}
25
26		$instance = $this->instance;
27
28		$next = $instance->retrieveMsgHistory($instance->start, $instance->end, $instance->next);
		0 ignored issues – show Documentation introduced 2018-06-12 17:05 UTC by Report Bug Copy Issue Report The property `$start` is declared private in `LivePersonInc\LiveEngageLaravel\LiveEngageLaravel`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2018-06-12 17:05 UTC by Report Bug Copy Issue Report The property `$end` is declared private in `LivePersonInc\LiveEngageLaravel\LiveEngageLaravel`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2018-06-12 17:05 UTC by Report Bug Copy Issue Report The property `$next` is declared private in `LivePersonInc\LiveEngageLaravel\LiveEngageLaravel`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
29		if (property_exists($next->_metadata, 'next')) {
30		$instance->next = $next->_metadata->next->href;
		0 ignored issues – show Documentation introduced 2018-06-12 17:05 UTC by Report Bug Copy Issue Report The property `$next` is declared private in `LivePersonInc\LiveEngageLaravel\LiveEngageLaravel`. Since you implemented `__set()`, maybe consider adding a @property or @property-write annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
31
32		$history = [];
33		foreach ($next->conversationHistoryRecords as $item) {
34		$history[] = new Conversation((array) $item);
35		}
36
37		return $this->merge(new self($history));
38		} else {
39		return false;
40		}
41		}
42
43		public function prev()
44		{
45		if (! $this->instance) {
46		return false;
47		}
48
49		$instance = $this->instance;
50
51		$prev = $instance->retrieveMsgHistory($instance->start, $instance->end, $instance->prev);
		0 ignored issues – show Documentation introduced 2018-06-12 17:05 UTC by Report Bug Copy Issue Report The property `$start` is declared private in `LivePersonInc\LiveEngageLaravel\LiveEngageLaravel`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2018-06-12 17:05 UTC by Report Bug Copy Issue Report The property `$end` is declared private in `LivePersonInc\LiveEngageLaravel\LiveEngageLaravel`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2018-06-12 17:05 UTC by Report Bug Copy Issue Report The property `$prev` is declared private in `LivePersonInc\LiveEngageLaravel\LiveEngageLaravel`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
52		if (property_exists($prev->_metadata, 'prev')) {
53		$instance->prev = $prev->_metadata->prev->href;
		0 ignored issues – show Documentation introduced 2018-06-12 17:05 UTC by Report Bug Copy Issue Report The property `$prev` is declared private in `LivePersonInc\LiveEngageLaravel\LiveEngageLaravel`. Since you implemented `__set()`, maybe consider adding a @property or @property-write annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
54
55		$history = [];
56		foreach ($next->conversationHistoryRecords as $item) {
		0 ignored issues – show Bug introduced 2018-06-12 17:05 UTC by Report Bug Copy Issue Report The variable `$next` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
57		$history[] = new Conversation((array) $item);
58		}
59
60		return $this->merge(new self($history));
61		} else {
62		return false;
63		}
64		}
65		}
66

LivePersonInc / LiveEngageLaravel

Branch — master (4d174b)

ConversationHistory::prev() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like