LivePersonInc\LiveEngageLaravel\Traits\Timeable

Complexity

Total Complexity

4

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	averageDurationMinutes()	0	3	1
A	totalDurationSeconds()	0	4	1
A	totalDurationMinutes()	0	4	1
A	averageDurationSeconds()	0	3	1

<?php
	
namespace LivePersonInc\LiveEngageLaravel\Traits;

use LivePersonInc\LiveEngageLaravel\Facades\LiveEngageLaravel as LiveEngage;

trait Timeable
{
	
	public function averageDurationMinutes()
	{
		return $this->totalDurationMinutes() / $this->count();

It seems like count() must be provided by classes using this trait. How about adding it as abstract method to this trait?

	}
	
	public function averageDurationSeconds()
	{
		return $this->totalDurationSeconds() / $this->count();
	}
	
	public function totalDurationMinutes($filter = [])
	{
		return $this->sum(function($item) use ($filter) {

The import $filter is not used and could be removed.

It seems like sum() must be provided by classes using this trait. How about adding it as abstract method to this trait?

			return $item->info->minutes;
		});
	}
	
	public function totalDurationSeconds($filter = [])
	{
		return $this->sum(function($item) use ($filter) {

The import $filter is not used and could be removed.

			return $item->info->seconds;
		});
	}
	
}