MessagingInfo::getEndTimeAttribute() - Code Metrics - Inspection of "Check for attributes" - LivePersonInc/LiveEngageLaravel - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( e60cf2...290fb6 )

by Robert

created 2019-09-17 14:27 UTC

MessagingInfo::getEndTimeAttribute() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2.0625

Importance

Changes

Metric	Value
eloc	4
dl	0
loc	6
ccs	3
cts	4
cp	0.75
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	0
crap	2.0625

<?php
/**
 * MessagingInfo
 *
 * @package LivePersonInc\LiveEngageLaravel\Models
 */

namespace LivePersonInc\LiveEngageLaravel\Models;

use Carbon\Carbon;
use Illuminate\Database\Eloquent\Model;

class MessagingInfo extends Model
{
	protected $guarded = [];
	protected $appends = [
		'startTime',
		'endTime'
	];

	public function getStartTimeAttribute()
	{
        if (isset($this->attributes['startTime']))
		    return new Carbon($this->attributes['startTime']);
	}
	
	public function getEndTimeAttribute()
	{
        if (if (isset($this->attributes['endTime']))) {

            if ($this->attributes['status'] == 'CLOSE') {
                return new Carbon($this->attributes['endTime']);
            } else {
                return null;
            }
        }
	}

	public function getMinutesAttribute()
	{
		return round(($this->attributes['duration'] / 1000) / 60, 2);
	}

	public function getSecondsAttribute()
	{
		return $this->attributes['duration'] / 1000;
	}

	public function getHoursAttribute()
	{
		return round($this->minutes / 60, 2);
	}
}


1		<?php
2		/**
3		* MessagingInfo
4		*
5		* @package LivePersonInc\LiveEngageLaravel\Models
6		*/
7
8		namespace LivePersonInc\LiveEngageLaravel\Models;
9
10		use Carbon\Carbon;
11		use Illuminate\Database\Eloquent\Model;
12
13		class MessagingInfo extends Model
14		{
15		protected $guarded = [];
16		protected $appends = [
17		'startTime',
18		'endTime'
19		];
20
21	1	public function getStartTimeAttribute()
22		{
23	1	if (isset($this->attributes['startTime']))
24		return new Carbon($this->attributes['startTime']);
25		}
26	1
27		public function getEndTimeAttribute()
28	1	{
29	1	if (if (isset($this->attributes['endTime']))) {
		0 ignored issues – show Bug introduced 2019-09-17 14:45 UTC by Report Bug Copy Issue Report A parse error occurred: Syntax error, unexpected T_IF on line 29 at column 12 Loading history...
30		if ($this->attributes['status'] == 'CLOSE') {
31		return new Carbon($this->attributes['endTime']);
32		} else {
33		return null;
34		}
35	1	}
36		}
37	1
38		public function getMinutesAttribute()
39		{
40	1	return round(($this->attributes['duration'] / 1000) / 60, 2);
41		}
42	1
43		public function getSecondsAttribute()
44		{
45	1	return $this->attributes['duration'] / 1000;
46		}
47	1
48		public function getHoursAttribute()
49		{
50		return round($this->minutes / 60, 2);
51		}
52		}
53

LivePersonInc / LiveEngageLaravel

Push — master ( e60cf2...290fb6 )

MessagingInfo::getEndTimeAttribute() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like