AttachToRequestTrait::fromRequest() - Code Metrics - Inspection of "e46a7e29d45b9e4dc43ebf4e16be1a7466a7be11" - LitPHP/nimo - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Branch — master (e46a7e)

by mcfog

created 2018-02-12 16:31 UTC

AttachToRequestTrait::fromRequest() A

↳ Parent: AttachToRequestTrait

Complexity

Conditions	4
Paths	6

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	0
cts	7
cp	0
rs	9.2
c	0
b	0
f	0
cc	4
eloc	7
nc	6
nop	1
crap	20

<?php

declare(strict_types=1);

namespace Lit\Nimo\Traits;

use Psr\Http\Message\ServerRequestInterface;

trait AttachToRequestTrait
{
    /**
     * @param ServerRequestInterface $request
     * @return static
     */
    public static function fromRequest(ServerRequestInterface $request)
    {
        /** @noinspection PhpUndefinedClassConstantInspection */
        $key = defined('static::ATTR_KEY') ? static::ATTR_KEY : static::class;
        if (!$instance = $request->getAttribute($key)) {
            throw new \RuntimeException('middleware not found:' . $key);
        }
        if (!$instance instanceof static) {
            throw new \RuntimeException('middleware class error:' . $key);
        }

        return $instance;
    }

    /**
     * @param ServerRequestInterface $request
     * @return ServerRequestInterface
     */
    protected function attachToRequest(ServerRequestInterface $request = null): ServerRequestInterface
    {
        /**
         * @var ServerRequestInterface $request
         */
        /** @noinspection PhpUndefinedFieldInspection */
        $request = $request ?: $this->request;
class MyClass { }

$x = new MyClass();
$x->foo = true;

        /** @noinspection PhpUndefinedClassConstantInspection */
        $key = defined('static::ATTR_KEY') ? static::ATTR_KEY : static::class;
        if ($request->getAttribute($key)) {
            throw new \RuntimeException('middleware collision:' . $key);
        }

        return $this->request = $request->withAttribute($key, $this);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Lit\Nimo\Traits;
6
7			use Psr\Http\Message\ServerRequestInterface;
8
9			trait AttachToRequestTrait
10			{
11			/**
12			* @param ServerRequestInterface $request
13			* @return static
14			*/
15			public static function fromRequest(ServerRequestInterface $request)
16			{
17			/** @noinspection PhpUndefinedClassConstantInspection */
18			$key = defined('static::ATTR_KEY') ? static::ATTR_KEY : static::class;
19			if (!$instance = $request->getAttribute($key)) {
20			throw new \RuntimeException('middleware not found:' . $key);
21			}
22			if (!$instance instanceof static) {
23			throw new \RuntimeException('middleware class error:' . $key);
24			}
25
26			return $instance;
27			}
28
29			/**
30			* @param ServerRequestInterface $request
31			* @return ServerRequestInterface
32			*/
33			protected function attachToRequest(ServerRequestInterface $request = null): ServerRequestInterface
34			{
35			/**
36			* @var ServerRequestInterface $request
37			*/
38			/** @noinspection PhpUndefinedFieldInspection */
39			$request = $request ?: $this->request;
			0 ignored issues – show Bug introduced 2017-12-06 15:05 UTC by Report Bug Copy Issue Report The property `request` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
40
41			/** @noinspection PhpUndefinedClassConstantInspection */
42			$key = defined('static::ATTR_KEY') ? static::ATTR_KEY : static::class;
43			if ($request->getAttribute($key)) {
44			throw new \RuntimeException('middleware collision:' . $key);
45			}
46
47			return $this->request = $request->withAttribute($key, $this);
48			}
49			}
50

LitPHP / nimo

Branch — master (e46a7e)

AttachToRequestTrait::fromRequest() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like