MiddlewarePipeTest::testAppend() - Code Metrics - Inspection of "fix case" - LitPHP/nimo - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( d8d5ef...b9f7fc )

by mcfog

created 2018-01-06 14:35 UTC

MiddlewarePipeTest::testAppend() A

↳ Parent: MiddlewarePipeTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	18
Code Lines	14

Duplication

Lines	18
Ratio	100 %

Importance

Changes

Metric	Value
dl	18
loc	18
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	14
nc	1
nop	0

<?php namespace Nimo\Tests;

use Nimo\MiddlewarePipe;

/**
 * User: mcfog
 * Date: 15/9/12
 */
class MiddlewarePipeTest extends NimoTestCase
{
    public function testEmptyStack()

    {
        $stack = new MiddlewarePipe();
        $answerRes = $this->getResponseMock();
        $request = $this->getRequestMock();

        $handler = $this->assertedHandler($request, $answerRes);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $res = $stack->process($request, $handler);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        self::assertSame($answerRes, $res);
    }

    public function testAppend()

    {
        $stack = new MiddlewarePipe();
        $request = $this->getRequestMock();
        $request2 = $this->getRequestMock();
        $request3 = $this->getRequestMock();
        $response = $this->getResponseMock();
        $middleware1 = $this->assertedNoopMiddleware($request, $request2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $middleware2 = $this->assertedNoopMiddleware($request2, $request3);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $handler = $this->assertedHandler($request3, $response);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $stack
            ->append($middleware1)
            ->append($middleware2);

        $res = $stack->process($request, $handler);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        self::assertSame($response, $res);
    }

    public function testPrepend()

    {
        $stack = new MiddlewarePipe();
        $request = $this->getRequestMock();
        $request2 = $this->getRequestMock();
        $request3 = $this->getRequestMock();
        $response = $this->getResponseMock();
        $middleware1 = $this->assertedNoopMiddleware($request, $request2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $middleware2 = $this->assertedNoopMiddleware($request2, $request3);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $handler = $this->assertedHandler($request3, $response);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $stack
            ->prepend($middleware2)
            ->prepend($middleware1);

        $res = $stack->process($request, $handler);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        self::assertSame($response, $res);
    }
}


1		<?php namespace Nimo\Tests;
2
3		use Nimo\MiddlewarePipe;
4
5		/**
6		* User: mcfog
7		* Date: 15/9/12
8		*/
9		class MiddlewarePipeTest extends NimoTestCase
10		{
11	View Code Duplication	public function testEmptyStack()
		0 ignored issues – show Duplication introduced 2018-01-06 14:37 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
12		{
13		$stack = new MiddlewarePipe();
14		$answerRes = $this->getResponseMock();
15		$request = $this->getRequestMock();
16
17		$handler = $this->assertedHandler($request, $answerRes);
		0 ignored issues – show Documentation introduced 2018-01-06 14:37 UTC by Report Bug Copy Issue Report `$request` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Psr\Http\Message\ServerRequestInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2018-01-06 14:37 UTC by Report Bug Copy Issue Report `$answerRes` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Psr\Http\Message\ResponseInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
18		$res = $stack->process($request, $handler);
		0 ignored issues – show Documentation introduced 2018-01-06 14:37 UTC by Report Bug Copy Issue Report `$request` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Psr\Http\Message\ServerRequestInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
19		self::assertSame($answerRes, $res);
20		}
21
22	View Code Duplication	public function testAppend()
		0 ignored issues – show Duplication introduced 2018-01-06 14:37 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
23		{
24		$stack = new MiddlewarePipe();
25		$request = $this->getRequestMock();
26		$request2 = $this->getRequestMock();
27		$request3 = $this->getRequestMock();
28		$response = $this->getResponseMock();
29		$middleware1 = $this->assertedNoopMiddleware($request, $request2);
		0 ignored issues – show Documentation introduced 2018-01-06 14:37 UTC by Report Bug Copy Issue Report `$request` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Psr\Http\Message\ServerRequestInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2018-01-06 14:37 UTC by Report Bug Copy Issue Report `$request2` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `null\|object<Psr\Http\Mes...ServerRequestInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
30		$middleware2 = $this->assertedNoopMiddleware($request2, $request3);
		0 ignored issues – show Documentation introduced 2018-01-06 14:37 UTC by Report Bug Copy Issue Report `$request2` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Psr\Http\Message\ServerRequestInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2018-01-06 14:37 UTC by Report Bug Copy Issue Report `$request3` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `null\|object<Psr\Http\Mes...ServerRequestInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
31		$handler = $this->assertedHandler($request3, $response);
		0 ignored issues – show Documentation introduced 2018-01-06 14:37 UTC by Report Bug Copy Issue Report `$request3` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Psr\Http\Message\ServerRequestInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2018-01-06 14:37 UTC by Report Bug Copy Issue Report `$response` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Psr\Http\Message\ResponseInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
32
33		$stack
34		->append($middleware1)
35		->append($middleware2);
36
37		$res = $stack->process($request, $handler);
		0 ignored issues – show Documentation introduced 2018-01-06 14:37 UTC by Report Bug Copy Issue Report `$request` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Psr\Http\Message\ServerRequestInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
38		self::assertSame($response, $res);
39		}
40
41	View Code Duplication	public function testPrepend()
		0 ignored issues – show Duplication introduced 2018-01-06 14:37 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
42		{
43		$stack = new MiddlewarePipe();
44		$request = $this->getRequestMock();
45		$request2 = $this->getRequestMock();
46		$request3 = $this->getRequestMock();
47		$response = $this->getResponseMock();
48		$middleware1 = $this->assertedNoopMiddleware($request, $request2);
		0 ignored issues – show Documentation introduced 2018-01-06 14:37 UTC by Report Bug Copy Issue Report `$request` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Psr\Http\Message\ServerRequestInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2018-01-06 14:37 UTC by Report Bug Copy Issue Report `$request2` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `null\|object<Psr\Http\Mes...ServerRequestInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
49		$middleware2 = $this->assertedNoopMiddleware($request2, $request3);
		0 ignored issues – show Documentation introduced 2018-01-06 14:37 UTC by Report Bug Copy Issue Report `$request2` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Psr\Http\Message\ServerRequestInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2018-01-06 14:37 UTC by Report Bug Copy Issue Report `$request3` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `null\|object<Psr\Http\Mes...ServerRequestInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
50		$handler = $this->assertedHandler($request3, $response);
		0 ignored issues – show Documentation introduced 2018-01-06 14:37 UTC by Report Bug Copy Issue Report `$request3` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Psr\Http\Message\ServerRequestInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2018-01-06 14:37 UTC by Report Bug Copy Issue Report `$response` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Psr\Http\Message\ResponseInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
51
52		$stack
53		->prepend($middleware2)
54		->prepend($middleware1);
55
56		$res = $stack->process($request, $handler);
		0 ignored issues – show Documentation introduced 2018-01-06 14:37 UTC by Report Bug Copy Issue Report `$request` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Psr\Http\Message\ServerRequestInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
57		self::assertSame($response, $res);
58		}
59		}
60

LitPHP / nimo

Push — master ( d8d5ef...b9f7fc )

MiddlewarePipeTest::testAppend() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like