Issues in CachedContainerBuilder.php (7.x-1.x) - Issues in 7.x-1.x - LionsAd/service_container - Measure and Improve Code Quality continuously with Scrutinizer

Issues (737)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/DependencyInjection/CachedContainerBuilder.php (4 issues)

Labels

Severity

Major 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * @file
 * Contains \Drupal\service_container\DependencyInjection\CachedContainerBuilder
 */

namespace Drupal\service_container\DependencyInjection;

use Drupal\Component\Plugin\PluginManagerInterface;
use DrupalCacheInterface;

/**
 * CachedContainerBuilder retrieves the container definition from cache
 * or builds it.
 *
 * The reason is to skip invoking all the ctools_* functions via the discovery
 * interface, which needs all modules loaded.
 *
 * This is especially useful to use the ServiceContainer safely within
 * hook_boot() or even earlier.
 *
 * @ingroup dic
 */
class CachedContainerBuilder extends ContainerBuilder {

  /**
   * The Drupal core cache bin.
   *
   * @var \DrupalCacheInterface
   */
  protected $cache;

  /**
   * The cached definition.
   *
   * @var array
   */
  protected $cachedDefinition;

  /**
   * Constructs a ContainerBuilder object.
   *
   * @param PluginManagerInterface $service_provider_manager
   *   The service provider manager that provides the service providers,
   *   which define the services used in the container.
   * @param \DrupalCacheInterface $cache
   *   The cache bin used to store retrieve the container to/from.
   *   To get a cache object use e.g.: $cache = _cache_get_object('cache');
   */
  public function __construct(PluginManagerInterface $service_provider_manager, DrupalCacheInterface $cache) {
    $this->cache = $cache;
    parent::__construct($service_provider_manager);
  }

  /**
   * {@inheritdoc}
   */
  public function getContainerDefinition() {
    $definition = $this->getCache();

    if (!$definition) {
      $definition = parent::getContainerDefinition();
      $this->setCache($definition);
    }

    return $definition;
  }

  /**
   * Determines if the container is cached.
   *
   * @return bool
   *   Returns TRUE if the container definition is cached, FALSE otherwise.
   */
  public function isCached() {
    $definition = $this->getCache();

    return (bool) $definition;
  }

  /**
   * Returns the cache id of the container definition.
   *
   * @return string
   *   The hardcoded cache id or via variable_get() if defined.
   *
   * @codeCoverageIgnore
   */
  protected function getCacheId() {
    return variable_get('service_container_container_cid', 'service_container:container_definition');
  }

  /**
   * Retrieves the cache id of the container definition.
   *
   * @return string
   *   The hardcoded cache id or via variable_get() if defined.
   */
  protected function getCache() {
    if (isset($this->cachedDefinition)) {
      return $this->cachedDefinition;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    $cache =  $this->cache->get($this->getCacheId());

    $this->cachedDefinition = FALSE;

    if (!empty($cache->data)) {
      $this->cachedDefinition = $cache->data;
    }

    return $this->cachedDefinition;
  }

  /**
   * Caches the builded container definition.
   *
   * @param array
   *   The container definition array.
   */
  protected function setCache(array $definition) {
    $this->cache->set($this->getCacheId(), $definition);
    $this->cachedDefinition = $definition;
  }

  /**
   * Reset the internal cache.
   *
   * Note: This is just thought for tests.
   */
  public function reset() {
    $this->cachedDefinition = NULL;

    $this->cache->clear($this->getCacheId());
  }

}


1			<?php
2
3			/**
4			* @file
5			* Contains \Drupal\service_container\DependencyInjection\CachedContainerBuilder
6			*/
7
8			namespace Drupal\service_container\DependencyInjection;
9
10			use Drupal\Component\Plugin\PluginManagerInterface;
11			use DrupalCacheInterface;
12
13			/**
14			* CachedContainerBuilder retrieves the container definition from cache
15			* or builds it.
16			*
17			* The reason is to skip invoking all the ctools_* functions via the discovery
18			* interface, which needs all modules loaded.
19			*
20			* This is especially useful to use the ServiceContainer safely within
21			* hook_boot() or even earlier.
22			*
23			* @ingroup dic
24			*/
25			class CachedContainerBuilder extends ContainerBuilder {
26
27			/**
28			* The Drupal core cache bin.
29			*
30			* @var \DrupalCacheInterface
31			*/
32			protected $cache;
33
34			/**
35			* The cached definition.
36			*
37			* @var array
38			*/
39			protected $cachedDefinition;
40
41			/**
42			* Constructs a ContainerBuilder object.
43			*
44			* @param PluginManagerInterface $service_provider_manager
45			* The service provider manager that provides the service providers,
46			* which define the services used in the container.
47			* @param \DrupalCacheInterface $cache
48			* The cache bin used to store retrieve the container to/from.
49			* To get a cache object use e.g.: $cache = _cache_get_object('cache');
50			*/
51			public function __construct(PluginManagerInterface $service_provider_manager, DrupalCacheInterface $cache) {
52			$this->cache = $cache;
53			parent::__construct($service_provider_manager);
54			}
55
56			/**
57			* {@inheritdoc}
58			*/
59			public function getContainerDefinition() {
60			$definition = $this->getCache();
			0 ignored issues – show Bug Compatibility introduced 2016-03-02 07:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$this->getCache();` of type `string` adds the type `string` to the return on line 66 which is incompatible with the return type declared by the interface `Drupal\service_container...:getContainerDefinition` of type `array`. Loading history...
61			if (!$definition) {
62			$definition = parent::getContainerDefinition();
63			$this->setCache($definition);
64			}
65
66			return $definition;
67			}
68
69			/**
70			* Determines if the container is cached.
71			*
72			* @return bool
73			* Returns TRUE if the container definition is cached, FALSE otherwise.
74			*/
75			public function isCached() {
76			$definition = $this->getCache();
77
78			return (bool) $definition;
79			}
80
81			/**
82			* Returns the cache id of the container definition.
83			*
84			* @return string
85			* The hardcoded cache id or via variable_get() if defined.
86			*
87			* @codeCoverageIgnore
88			*/
89			protected function getCacheId() {
90			return variable_get('service_container_container_cid', 'service_container:container_definition');
91			}
92
93			/**
94			* Retrieves the cache id of the container definition.
95			*
96			* @return string
97			* The hardcoded cache id or via variable_get() if defined.
98			*/
99			protected function getCache() {
100			if (isset($this->cachedDefinition)) {
101			return $this->cachedDefinition;
			0 ignored issues – show Bug Best Practice introduced 2015-11-20 22:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return $this->cachedDefinition;` (`array`) is incompatible with the return type documented by `Drupal\service_container...tainerBuilder::getCache` of type `string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
102			}
103
104			$cache = $this->cache->get($this->getCacheId());
105
106			$this->cachedDefinition = FALSE;
			0 ignored issues – show Documentation Bug introduced 2015-11-20 22:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `FALSE` of type `false` is incompatible with the declared type `array` of property `$cachedDefinition`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
107			if (!empty($cache->data)) {
108			$this->cachedDefinition = $cache->data;
109			}
110
111			return $this->cachedDefinition;
112			}
113
114			/**
115			* Caches the builded container definition.
116			*
117			* @param array
118			* The container definition array.
119			*/
120			protected function setCache(array $definition) {
121			$this->cache->set($this->getCacheId(), $definition);
122			$this->cachedDefinition = $definition;
123			}
124
125			/**
126			* Reset the internal cache.
127			*
128			* Note: This is just thought for tests.
129			*/
130			public function reset() {
131			$this->cachedDefinition = NULL;
			0 ignored issues – show Documentation Bug introduced 2015-11-20 22:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `NULL` of type `null` is incompatible with the declared type `array` of property `$cachedDefinition`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
132			$this->cache->clear($this->getCacheId());
133			}
134
135			}
136

LionsAd / service_container

Issues (737)

Security Analysis not enabled

src/DependencyInjection/CachedContainerBuilder.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like