Majora\Component\OAuth\Entity\Token

Complexity

Total Complexity

10

Size/Duplication

Total Lines	99
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	1	Features	2

8 Methods

Rating	Name	Duplication	Size	Complexity
A	getId()	0	4	1
A	getHash()	0	4	1
A	getExpireIn()	0	4	1
A	getAccount()	0	4	1
A	getApplication()	0	4	1
A	getRoles()	0	4	1
A	__construct()	0	15	3
A	__toString()	0	4	1

<?php

namespace Majora\Component\OAuth\Entity;

use Majora\Component\OAuth\Model\TokenInterface;
use Majora\Component\OAuth\Model\AccountInterface;
use Majora\Component\OAuth\Model\ApplicationInterface;
use Symfony\Component\Security\Core\Encoder\MessageDigestPasswordEncoder;

/**
 * Abstract token class.
 */
abstract class Token implements TokenInterface
{
    /**
     * @var int
     */
    protected $id;

    /**
     * @var string
     */
    protected $hash;

    /**
     * @var int
     */
    protected $expireIn;

    /**
     * @var AccountInterface
     */
    protected $account;

    /**
     * @var ApplicationInterface
     */
    protected $application;

    /**
     * @see TokenInterface::__construct()
     */
    public function __construct(
        ApplicationInterface $application,
        AccountInterface $account = null,
        $expireIn = TokenInterface::DEFAULT_TTL,
        $hash = null
    ) {
        $this->application = $application;
        $this->account = $account;
        $this->expireIn = $expireIn;

        $this->hash = $hash ?: (new MessageDigestPasswordEncoder())->encodePassword(
            sprintf('[%s\o/%s]', $application->getSecret(), $account->getPassword() ?: time()),

It seems like $account is not always an object, but can also be of type null. Maybe add an additional type check?

            uniqid(mt_rand(), true)
        );
    }

    /**
     * @see TokenInterface::__toString()
     */
    public function __toString()
    {
        return $this->hash;
    }

    public function getId()
    {
        return $this->id;
    }

    /**
     * @see TokenInterface::getHash()
     */
    public function getHash()
    {
        return $this->hash;
    }

    /**
     * @see TokenInterface::getExpireIn()
     */
    public function getExpireIn()
    {
        return $this->expireIn;
    }

    /**
     * @see TokenInterface::getAccount()
     */
    public function getAccount()
    {
        return $this->account;
    }

    /**
     * @see TokenInterface::getApplication()
     */
    public function getApplication()
    {
        return $this->application;
    }

    /**
     * @see TokenInterface::getRoles()
     */
    public function getRoles()
    {
        return array_intersect($this->account->getRoles(), $this->application->getRoles());
    }
}