RandomTokenGeneratorTest::setUp() - Code Metrics - Inspection of "Tests unitaires du serveur et de ses dépendances" - LinkValue/MajoraOAuthServerBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — release-v2.1 (#15)

by Quentin

created 2016-03-02 15:24 UTC

RandomTokenGeneratorTest::setUp() A

↳ Parent: RandomTokenGeneratorTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	6
rs	9.4285
cc	1
eloc	3
nc	1
nop	0

<?php

namespace {
    $mockRandomPseudoBytes = false;
}

namespace Majora\Component\OAuth\Generator {
    /**
     * override global method to tests if function cannot get a strong hash.
     */
    function openssl_random_pseudo_bytes($length, &$strong)
    {
        global $mockRandomPseudoBytes;
function myFunction($a, $b) {
    // Do something
}
        if (isset($mockRandomPseudoBytes) && $mockRandomPseudoBytes === true) {
            $strong = false;

            return 12345;
        } else {
            return \openssl_random_pseudo_bytes($length, $strong);
        }
    }
}

namespace Majora\Component\OAuth\Tests\Generator {

    use Majora\Component\OAuth\Generator\RandomTokenGenerator;


    /**
     * Unit test class for Majora\Component\OAuth\Generator\RandomTokenGenerator.
     */
    class RandomTokenGeneratorTest extends \PHPUnit_Framework_TestCase
    {
        /**
         * SetUp method overriden to reset global mock boolean.
         */
        public function setUp()
        {
            global $mockRandomPseudoBytes;
function myFunction($a, $b) {
    // Do something
}

            $mockRandomPseudoBytes = false;
        }

        /**
         * Cases provider for token generation.
         */
        public function generateCaseProvider()
        {
            return array(
                'openssl_pseudo_bytes' => array(false, 50, 100),
                'mt_rand_sha_512' => array(true, 64, 100),
            );
        }

        /**
         * Tests generate() method.
         *
         * @dataProvider generateCaseProvider
         */
        public function testGenerate($enableMock, $tokenLength, $iterations)
        {
            global $mockRandomPseudoBytes;
function myFunction($a, $b) {
    // Do something
}

            $mockRandomPseudoBytes = $enableMock;

            $generator = new RandomTokenGenerator('mocked_secret');
            $alreadyGenerated = array();

            for ($i = 0; $i < $iterations; ++$i) {
                $token = $generator->generate('test_seed');

                $this->assertEquals($tokenLength, strlen($token));
                $this->assertNotContains($token, $alreadyGenerated);

                $alreadyGenerated[] = $token;
            }
        }
    }
}


Pull Request — release-v2.1 (#15)

RandomTokenGeneratorTest::setUp() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2
3			namespace {
4			$mockRandomPseudoBytes = false;
5			}
6
7			namespace Majora\Component\OAuth\Generator {
8			/**
9			* override global method to tests if function cannot get a strong hash.
10			*/
11			function openssl_random_pseudo_bytes($length, &$strong)
12			{
13			global $mockRandomPseudoBytes;
			0 ignored issues – show Compatibility Best Practice introduced 2016-03-02 15:33 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
14			if (isset($mockRandomPseudoBytes) && $mockRandomPseudoBytes === true) {
15			$strong = false;
16
17			return 12345;
18			} else {
19			return \openssl_random_pseudo_bytes($length, $strong);
20			}
21			}
22			}
23
24			namespace Majora\Component\OAuth\Tests\Generator {
25
26			use Majora\Component\OAuth\Generator\RandomTokenGenerator;
			0 ignored issues – show Coding Style introduced 2016-03-02 15:33 UTC by Report Bug Copy Issue Report USE declarations must go after the first namespace declaration Loading history...
27
28			/**
29			* Unit test class for Majora\Component\OAuth\Generator\RandomTokenGenerator.
30			*/
31			class RandomTokenGeneratorTest extends \PHPUnit_Framework_TestCase
32			{
33			/**
34			* SetUp method overriden to reset global mock boolean.
35			*/
36			public function setUp()
37			{
38			global $mockRandomPseudoBytes;
			0 ignored issues – show Compatibility Best Practice introduced 2016-03-02 15:33 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
39
40			$mockRandomPseudoBytes = false;
41			}
42
43			/**
44			* Cases provider for token generation.
45			*/
46			public function generateCaseProvider()
47			{
48			return array(
49			'openssl_pseudo_bytes' => array(false, 50, 100),
50			'mt_rand_sha_512' => array(true, 64, 100),
51			);
52			}
53
54			/**
55			* Tests generate() method.
56			*
57			* @dataProvider generateCaseProvider
58			*/
59			public function testGenerate($enableMock, $tokenLength, $iterations)
60			{
61			global $mockRandomPseudoBytes;
			0 ignored issues – show Compatibility Best Practice introduced 2016-03-02 15:33 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
62
63			$mockRandomPseudoBytes = $enableMock;
64
65			$generator = new RandomTokenGenerator('mocked_secret');
66			$alreadyGenerated = array();
67
68			for ($i = 0; $i < $iterations; ++$i) {
69			$token = $generator->generate('test_seed');
70
71			$this->assertEquals($tokenLength, strlen($token));
72			$this->assertNotContains($token, $alreadyGenerated);
73
74			$alreadyGenerated[] = $token;
75			}
76			}
77			}
78			}
79

LinkValue / MajoraOAuthServerBundle

Pull Request — release-v2.1 (#15)

RandomTokenGeneratorTest::setUp() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like