Majora\Framework\Loader\LoaderTrait

Complexity

Total Complexity

6

Size/Duplication

Total Lines	84
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes	14
Bugs	2	Features	7

3 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	16	2
A	configureMetadata()	0	11	2
A	getLoadingDelegate()	0	6	2

<?php

namespace Majora\Framework\Loader;

use Majora\Framework\Repository\RepositoryInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

/**
 * Base trait for loaders.
 *
 * @method retrieveById()
 */
trait LoaderTrait
{
    /**
     * @var RepositoryInterface
     */
    protected $entityRepository;

    /**
     * @var array
     */
    protected $entityProperties;

    /**
     * @var string
     */
    protected $entityClass;

    /**
     * @var string
     */
    protected $collectionClass;

    /**
     * @var OptionsResolver
     */
    protected $filterResolver;

    /**
     * @var \Closure
     */
    private $loadingDelegate;

    /**
     * setUp method.
     *
     * @param string              $entityClass
     * @param array               $entityProperties
     * @param string              $collectionClass
     * @param RepositoryInterface $entityRepository
     */
    public function setUp(
        $entityClass,
        array $entityProperties,
        $collectionClass,
        RepositoryInterface $entityRepository = null
    ) {
        @trigger_error(__METHOD__.'() is deprecated and will be removed in 2.0. Please use configureMetadata() instead.', E_USER_DEPRECATED);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        if ($entityRepository) {
            @trigger_error('Repository injection throught '.__METHOD__.'() is deprecated and will be removed in 2.0. Please inject it by constructor.', E_USER_DEPRECATED);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

            $this->entityRepository = $entityRepository;
        }

        return $this->configureMetadata($entityClass, $entityProperties, $collectionClass);
    }

    /**
     * @see LoaderInterface::configureMetadata()
     */
    public function configureMetadata($entityClass, array $entityProperties, $collectionClass)
    {
        $this->entityClass = $entityClass;
        $this->entityProperties = $entityProperties;
        $this->collectionClass = $collectionClass;

        $this->filterResolver = new OptionsResolver();
        foreach ($entityProperties as $propertyName) {
            $this->filterResolver->setDefined($propertyName);
        }
    }

    /**
     * Returns repository loading delegate.
     *
     * @return \Closure
     */
    public function getLoadingDelegate()
    {
        return $this->loadingDelegate = $this->loadingDelegate ?: function ($id) {
            return $this->retrieveById($id);

The call to LoaderTrait::retrieveById() has too many arguments starting with $id.

        };
    }
}