Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
13 | class MajoraSerializer implements SerializerInterface |
||
14 | { |
||
15 | /** |
||
16 | * FormatHandlerInterface[]. |
||
17 | */ |
||
18 | protected $handlers; |
||
19 | |||
20 | /** |
||
21 | * construct. |
||
22 | * |
||
23 | * @param FormatHandlerInterface[] $handlers |
||
24 | */ |
||
25 | 10 | public function __construct(array $handlers) |
|
32 | |||
33 | /** |
||
34 | * Register a format handler under given alias |
||
35 | * |
||
36 | * @param string $alias |
||
37 | * @param FormatHandlerInterface $handler |
||
38 | */ |
||
39 | 6 | public function registerFormatHandler($alias, FormatHandlerInterface $handler) |
|
43 | |||
44 | /** |
||
45 | * {@inheritdoc} |
||
46 | * |
||
47 | * @see SerializerInterface::serialize() |
||
48 | */ |
||
49 | 6 | public function serialize($data, $format, array $context = array()) |
|
63 | |||
64 | /** |
||
65 | * {@inheritdoc} |
||
66 | * |
||
67 | * @see SerializerInterface::deserialize() |
||
68 | */ |
||
69 | 4 | public function deserialize($data, $type, $format, array $context = array()) |
|
80 | } |
||
81 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.